ad150c7126
Sweep every CLI output path through the v0.7 envelope contract.
FormatOptions.Emit signature changes to (w, data, meta *output.Meta)
so list commands surface meta.count / has_more in the wire envelope.
TTY indent decision plumbed via FormatOptions.TTY (set by
ResolveDefault). --format and --jq promoted to persistent root flags
so unknown-subcommand paths still reach the typed-envelope guard
(per-command registration would have rejected --format on unknown
commands as cobra-prose exit 2). WEKNORA_FORMAT env-var fallback
honored before TTY-resolved default. AddFormatFlag retained for the
per-command --jq field-hint Long-text addendum.
~55 production Emit call sites swept across cli/cmd/**: list paths
populate meta.count; mutation paths pass nil meta; envelope.profile
threaded via globalProfile. Existing JSON-shape tests migrated to
decode the envelope wrapper.
Multi-target batch operations get a unified shape via new helpers:
- output.BatchItem + output.WriteBatchEnvelope (§4.5 per-item ok
pattern; data:[{id, ok, result?|error?}], meta:{count, successes*,
failures*}; Successes/Failures *int so explicit zero survives
omitempty in all-fail case).
- cmdutil.RunBatch + cmdutil.EmitBatch + cmdutil.DeletedAtNow +
cmdutil.ClassifyContextErr collapse the three previously-duplicated
multi-delete pipelines (doc / chunk / session) into one call site
pattern. doc upload --recursive uses the same helpers with a per-
file resultFn. Summary error sets Silent:true so the stderr
envelope path doesn't duplicate the stdout batch detail (exit 1
preserved via Code → ExitCode).
ConfirmDestructive / ConfirmDestructiveBatch extended with action +
retryCmd parameters. Every destructive command (kb delete, kb edit,
doc delete, doc delete --all, agent delete, agent edit, session
delete, chunk delete, auth logout, api -X DELETE) now attaches
error.risk.{level:"destructive", action:"<noun.verb>"} +
error.retry_command on the exit-10 envelope. kb edit / agent edit
also gain the destructive guard wiring (CHANGELOG listed them as
gated but they were silently executing without -y).
MCP tool handlers' 31 error paths return CallToolResult with
IsError + Content text fallback + StructuredContent (envelope.error
shape via cmdutil.ErrorToDetail). Handler Out type changed from
typed *sdk.X to any so the go-sdk auto-marshal doesn't overwrite
StructuredContent with a zero-struct on error returns. Success path
manually populates CallToolResult.StructuredContent via successResult
helper.
weknora api cleanup:
- -d/--data flag removed; body via --input <file> or --input -
(stdin) only. Aligns with gh / curl convention.
- HTTP method whitelist removed; any non-empty method accepted.
- HTTP Retry-After header → cmdutil.Error.RetryAfterSeconds →
envelope.error.retry_after_seconds.
- runAPIPaginated raw-passthrough fallback now wraps response in
envelope so --paginate never emits bare JSON to stdout.
Test sweep: ~60 cmd/** tests migrated to decode envelope shape.
9 wire-contract goldens updated under cli/acceptance/testdata/wire/.
Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §4 / §5
106 lines
3.7 KiB
Go
106 lines
3.7 KiB
Go
package chunkcmd
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
type fakeViewSvc struct {
|
|
resp *sdk.Chunk
|
|
err error
|
|
}
|
|
|
|
func (f *fakeViewSvc) GetChunkByIDOnly(_ context.Context, _ string) (*sdk.Chunk, error) {
|
|
return f.resp, f.err
|
|
}
|
|
|
|
func TestView_Happy_RendersAllFields(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeViewSvc{resp: &sdk.Chunk{
|
|
ID: "c1",
|
|
SeqID: 42,
|
|
ChunkIndex: 0,
|
|
KnowledgeID: "doc_abc",
|
|
KnowledgeBaseID: "kb_abc",
|
|
ChunkType: "text",
|
|
IsEnabled: true,
|
|
Content: "the quick brown fox",
|
|
CreatedAt: "2026-05-15T11:00:00Z",
|
|
UpdatedAt: "2026-05-15T12:00:00Z",
|
|
}}
|
|
require.NoError(t, runView(context.Background(), &ViewOptions{ChunkID: "c1"}, &cmdutil.FormatOptions{Mode: cmdutil.FormatHuman}, svc))
|
|
body := out.String()
|
|
assert.Contains(t, body, "c1")
|
|
assert.Contains(t, body, "doc_abc")
|
|
assert.Contains(t, body, "kb_abc")
|
|
assert.Contains(t, body, "text")
|
|
assert.Contains(t, body, "the quick brown fox", "content must render in full")
|
|
}
|
|
|
|
func TestView_HumanLabels_DocAndKB(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeViewSvc{resp: &sdk.Chunk{
|
|
ID: "c1", KnowledgeID: "doc_abc", KnowledgeBaseID: "kb_abc",
|
|
}}
|
|
require.NoError(t, runView(context.Background(), &ViewOptions{ChunkID: "c1"}, &cmdutil.FormatOptions{Mode: cmdutil.FormatHuman}, svc))
|
|
body := out.String()
|
|
// Human KV uses friendlier DOC_ID / KB_ID labels (the SDK's
|
|
// knowledge_id / knowledge_base_id are kept only in --format json output).
|
|
assert.Contains(t, body, "doc_id")
|
|
assert.Contains(t, body, "kb_id")
|
|
assert.NotContains(t, body, "knowledge_id")
|
|
assert.NotContains(t, body, "knowledge_base_id")
|
|
}
|
|
|
|
func TestView_OmitsZeroOrEmpty(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeViewSvc{resp: &sdk.Chunk{ID: "c_min", Content: "x"}}
|
|
require.NoError(t, runView(context.Background(), &ViewOptions{ChunkID: "c_min"}, &cmdutil.FormatOptions{Mode: cmdutil.FormatHuman}, svc))
|
|
body := out.String()
|
|
// status / start_at / end_at all zero → must be omitted from the human KV.
|
|
assert.NotContains(t, body, "status:")
|
|
assert.NotContains(t, body, "start_at:")
|
|
assert.NotContains(t, body, "end_at:")
|
|
// tag_id / image_info empty → omitted.
|
|
assert.NotContains(t, body, "tag_id:")
|
|
assert.NotContains(t, body, "image_info:")
|
|
}
|
|
|
|
func TestView_JSON_BareSDKShape(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeViewSvc{resp: &sdk.Chunk{
|
|
ID: "c_json", KnowledgeID: "doc_abc", KnowledgeBaseID: "kb_abc",
|
|
}}
|
|
require.NoError(t, runView(context.Background(), &ViewOptions{ChunkID: "c_json"}, &cmdutil.FormatOptions{Mode: cmdutil.FormatJSON}, svc))
|
|
var env struct {
|
|
OK bool `json:"ok"`
|
|
Data sdk.Chunk `json:"data"`
|
|
}
|
|
require.NoError(t, json.Unmarshal(out.Bytes(), &env))
|
|
got := env.Data
|
|
assert.Equal(t, "c_json", got.ID)
|
|
assert.Equal(t, "doc_abc", got.KnowledgeID)
|
|
// JSON uses SDK snake_case keys (knowledge_id), not human relabel doc_id.
|
|
assert.Contains(t, out.String(), `"knowledge_id":"doc_abc"`)
|
|
assert.Contains(t, out.String(), `"knowledge_base_id":"kb_abc"`)
|
|
assert.NotContains(t, out.String(), `"doc_id"`)
|
|
assert.NotContains(t, out.String(), `"kb_id"`)
|
|
}
|
|
|
|
func TestView_404(t *testing.T) {
|
|
_, _ = iostreams.SetForTest(t)
|
|
svc := &fakeViewSvc{err: errors.New("HTTP error 404: not found")}
|
|
err := runView(context.Background(), &ViewOptions{ChunkID: "missing"}, &cmdutil.FormatOptions{Mode: cmdutil.FormatHuman}, svc)
|
|
require.Error(t, err)
|
|
assert.Contains(t, err.Error(), "resource.not_found")
|
|
}
|