ad150c7126
Sweep every CLI output path through the v0.7 envelope contract.
FormatOptions.Emit signature changes to (w, data, meta *output.Meta)
so list commands surface meta.count / has_more in the wire envelope.
TTY indent decision plumbed via FormatOptions.TTY (set by
ResolveDefault). --format and --jq promoted to persistent root flags
so unknown-subcommand paths still reach the typed-envelope guard
(per-command registration would have rejected --format on unknown
commands as cobra-prose exit 2). WEKNORA_FORMAT env-var fallback
honored before TTY-resolved default. AddFormatFlag retained for the
per-command --jq field-hint Long-text addendum.
~55 production Emit call sites swept across cli/cmd/**: list paths
populate meta.count; mutation paths pass nil meta; envelope.profile
threaded via globalProfile. Existing JSON-shape tests migrated to
decode the envelope wrapper.
Multi-target batch operations get a unified shape via new helpers:
- output.BatchItem + output.WriteBatchEnvelope (§4.5 per-item ok
pattern; data:[{id, ok, result?|error?}], meta:{count, successes*,
failures*}; Successes/Failures *int so explicit zero survives
omitempty in all-fail case).
- cmdutil.RunBatch + cmdutil.EmitBatch + cmdutil.DeletedAtNow +
cmdutil.ClassifyContextErr collapse the three previously-duplicated
multi-delete pipelines (doc / chunk / session) into one call site
pattern. doc upload --recursive uses the same helpers with a per-
file resultFn. Summary error sets Silent:true so the stderr
envelope path doesn't duplicate the stdout batch detail (exit 1
preserved via Code → ExitCode).
ConfirmDestructive / ConfirmDestructiveBatch extended with action +
retryCmd parameters. Every destructive command (kb delete, kb edit,
doc delete, doc delete --all, agent delete, agent edit, session
delete, chunk delete, auth logout, api -X DELETE) now attaches
error.risk.{level:"destructive", action:"<noun.verb>"} +
error.retry_command on the exit-10 envelope. kb edit / agent edit
also gain the destructive guard wiring (CHANGELOG listed them as
gated but they were silently executing without -y).
MCP tool handlers' 31 error paths return CallToolResult with
IsError + Content text fallback + StructuredContent (envelope.error
shape via cmdutil.ErrorToDetail). Handler Out type changed from
typed *sdk.X to any so the go-sdk auto-marshal doesn't overwrite
StructuredContent with a zero-struct on error returns. Success path
manually populates CallToolResult.StructuredContent via successResult
helper.
weknora api cleanup:
- -d/--data flag removed; body via --input <file> or --input -
(stdin) only. Aligns with gh / curl convention.
- HTTP method whitelist removed; any non-empty method accepted.
- HTTP Retry-After header → cmdutil.Error.RetryAfterSeconds →
envelope.error.retry_after_seconds.
- runAPIPaginated raw-passthrough fallback now wraps response in
envelope so --paginate never emits bare JSON to stdout.
Test sweep: ~60 cmd/** tests migrated to decode envelope shape.
9 wire-contract goldens updated under cli/acceptance/testdata/wire/.
Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §4 / §5
223 lines
8.7 KiB
Go
223 lines
8.7 KiB
Go
package auth
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/config"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
"github.com/Tencent/WeKnora/cli/internal/prompt"
|
|
"github.com/Tencent/WeKnora/cli/internal/secrets"
|
|
"github.com/Tencent/WeKnora/cli/internal/testutil"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
// fakeRefreshService scripts a RefreshToken response.
|
|
type fakeRefreshService struct {
|
|
resp *sdk.RefreshTokenResponse
|
|
err error
|
|
gotTok string
|
|
}
|
|
|
|
func (f *fakeRefreshService) RefreshToken(_ context.Context, refreshToken string) (*sdk.RefreshTokenResponse, error) {
|
|
f.gotTok = refreshToken
|
|
return f.resp, f.err
|
|
}
|
|
|
|
// stubSvc returns a closure conforming to the refresherFor signature; it
|
|
// ignores host since the fake doesn't talk to the network.
|
|
func stubSvc(s cmdutil.Refresher) func(string) cmdutil.Refresher {
|
|
return func(string) cmdutil.Refresher { return s }
|
|
}
|
|
|
|
func newRefreshFactory(t *testing.T, cfg *config.Config, store *secrets.MemStore) *cmdutil.Factory {
|
|
t.Helper()
|
|
testutil.XDGTempDir(t)
|
|
require.NoError(t, config.Save(cfg))
|
|
return &cmdutil.Factory{
|
|
Config: func() (*config.Config, error) { return config.Load() },
|
|
Client: func() (*sdk.Client, error) { panic("client") },
|
|
Prompter: func() prompt.Prompter { return prompt.AgentPrompter{} },
|
|
Secrets: func() (secrets.Store, error) { return store, nil },
|
|
}
|
|
}
|
|
|
|
func TestRefresh_Happy(t *testing.T) {
|
|
iostreams.SetForTest(t)
|
|
store := secrets.NewMemStore()
|
|
require.NoError(t, store.Set("prod", "access", "old-access"))
|
|
require.NoError(t, store.Set("prod", "refresh", "old-refresh"))
|
|
|
|
cfg := &config.Config{
|
|
CurrentContext: "prod",
|
|
Contexts: map[string]config.Context{
|
|
"prod": {
|
|
Host: "https://kb.example.com",
|
|
TokenRef: "mem://prod/access",
|
|
RefreshRef: "mem://prod/refresh",
|
|
User: "alice@example.com",
|
|
},
|
|
},
|
|
}
|
|
f := newRefreshFactory(t, cfg, store)
|
|
svc := &fakeRefreshService{resp: &sdk.RefreshTokenResponse{
|
|
Success: true,
|
|
AccessToken: "new-access",
|
|
RefreshToken: "new-refresh",
|
|
}}
|
|
require.NoError(t, runRefresh(context.Background(), &RefreshOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatHuman}, f, stubSvc(svc)))
|
|
|
|
assert.Equal(t, "old-refresh", svc.gotTok, "must pass stored refresh token to SDK")
|
|
gotAccess, _ := store.Get("prod", "access")
|
|
gotRefresh, _ := store.Get("prod", "refresh")
|
|
assert.Equal(t, "new-access", gotAccess)
|
|
assert.Equal(t, "new-refresh", gotRefresh)
|
|
}
|
|
|
|
func TestRefresh_NamedContext(t *testing.T) {
|
|
iostreams.SetForTest(t)
|
|
store := secrets.NewMemStore()
|
|
require.NoError(t, store.Set("staging", "refresh", "stg-refresh"))
|
|
|
|
cfg := &config.Config{
|
|
CurrentContext: "prod",
|
|
Contexts: map[string]config.Context{
|
|
"prod": {Host: "https://prod", TokenRef: "mem://prod/access", RefreshRef: "mem://prod/refresh"},
|
|
"staging": {Host: "https://stg", TokenRef: "mem://staging/access", RefreshRef: "mem://staging/refresh"},
|
|
},
|
|
}
|
|
f := newRefreshFactory(t, cfg, store)
|
|
svc := &fakeRefreshService{resp: &sdk.RefreshTokenResponse{
|
|
Success: true, AccessToken: "new-stg-access", RefreshToken: "new-stg-refresh",
|
|
}}
|
|
require.NoError(t, runRefresh(context.Background(), &RefreshOptions{Name: "staging"}, &cmdutil.FormatOptions{Mode: cmdutil.FormatHuman}, f, stubSvc(svc)))
|
|
|
|
assert.Equal(t, "stg-refresh", svc.gotTok, "--name=staging must refresh the staging context, not current")
|
|
// current is untouched
|
|
if v, _ := store.Get("prod", "access"); v != "" {
|
|
t.Errorf("prod must not have been touched, got %q", v)
|
|
}
|
|
}
|
|
|
|
func TestRefresh_NoCurrentContext(t *testing.T) {
|
|
iostreams.SetForTest(t)
|
|
f := newRefreshFactory(t, &config.Config{}, secrets.NewMemStore())
|
|
err := runRefresh(context.Background(), &RefreshOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatHuman}, f, stubSvc(&fakeRefreshService{}))
|
|
require.Error(t, err)
|
|
var typed *cmdutil.Error
|
|
require.ErrorAs(t, err, &typed)
|
|
assert.Equal(t, cmdutil.CodeAuthUnauthenticated, typed.Code)
|
|
}
|
|
|
|
func TestRefresh_APIKeyContext(t *testing.T) {
|
|
iostreams.SetForTest(t)
|
|
store := secrets.NewMemStore()
|
|
require.NoError(t, store.Set("ci", "api_key", "sk-123"))
|
|
cfg := &config.Config{
|
|
CurrentContext: "ci",
|
|
Contexts: map[string]config.Context{"ci": {Host: "https://kb", APIKeyRef: "mem://ci/api_key"}},
|
|
}
|
|
f := newRefreshFactory(t, cfg, store)
|
|
err := runRefresh(context.Background(), &RefreshOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatHuman}, f, stubSvc(&fakeRefreshService{}))
|
|
require.Error(t, err)
|
|
var typed *cmdutil.Error
|
|
require.ErrorAs(t, err, &typed)
|
|
assert.Equal(t, cmdutil.CodeInputInvalidArgument, typed.Code)
|
|
assert.Contains(t, typed.Hint, "api-key", "hint should explain api-key contexts cannot be refreshed")
|
|
}
|
|
|
|
func TestRefresh_NoRefreshTokenStored(t *testing.T) {
|
|
iostreams.SetForTest(t)
|
|
cfg := &config.Config{
|
|
CurrentContext: "prod",
|
|
Contexts: map[string]config.Context{
|
|
"prod": {Host: "https://kb", TokenRef: "mem://prod/access", RefreshRef: "mem://prod/refresh"},
|
|
},
|
|
}
|
|
// MemStore is empty - RefreshRef points to a slot that doesn't exist.
|
|
f := newRefreshFactory(t, cfg, secrets.NewMemStore())
|
|
err := runRefresh(context.Background(), &RefreshOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatHuman}, f, stubSvc(&fakeRefreshService{}))
|
|
require.Error(t, err)
|
|
var typed *cmdutil.Error
|
|
require.ErrorAs(t, err, &typed)
|
|
assert.Equal(t, cmdutil.CodeAuthTokenExpired, typed.Code)
|
|
assert.Contains(t, typed.Hint, "auth login")
|
|
}
|
|
|
|
func TestRefresh_ServerRefused(t *testing.T) {
|
|
iostreams.SetForTest(t)
|
|
store := secrets.NewMemStore()
|
|
require.NoError(t, store.Set("prod", "refresh", "stale-refresh"))
|
|
cfg := &config.Config{
|
|
CurrentContext: "prod",
|
|
Contexts: map[string]config.Context{"prod": {Host: "https://kb", TokenRef: "mem://prod/access", RefreshRef: "mem://prod/refresh"}},
|
|
}
|
|
f := newRefreshFactory(t, cfg, store)
|
|
svc := &fakeRefreshService{resp: &sdk.RefreshTokenResponse{Success: false, Message: "refresh token expired"}}
|
|
err := runRefresh(context.Background(), &RefreshOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatHuman}, f, stubSvc(svc))
|
|
require.Error(t, err)
|
|
var typed *cmdutil.Error
|
|
require.ErrorAs(t, err, &typed)
|
|
assert.Equal(t, cmdutil.CodeAuthTokenExpired, typed.Code)
|
|
assert.Contains(t, typed.Hint, "auth login")
|
|
// stored access must NOT have been overwritten with empty
|
|
if v, _ := store.Get("prod", "access"); v == "" {
|
|
// Was never set in this test, that's fine - main thing is no panic.
|
|
_ = v
|
|
}
|
|
}
|
|
|
|
func TestRefresh_TransportError(t *testing.T) {
|
|
iostreams.SetForTest(t)
|
|
store := secrets.NewMemStore()
|
|
require.NoError(t, store.Set("prod", "refresh", "ok-refresh"))
|
|
cfg := &config.Config{
|
|
CurrentContext: "prod",
|
|
Contexts: map[string]config.Context{"prod": {Host: "https://kb", TokenRef: "mem://prod/access", RefreshRef: "mem://prod/refresh"}},
|
|
}
|
|
f := newRefreshFactory(t, cfg, store)
|
|
svc := &fakeRefreshService{err: errors.New("connection reset")}
|
|
err := runRefresh(context.Background(), &RefreshOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatHuman}, f, stubSvc(svc))
|
|
require.Error(t, err)
|
|
var typed *cmdutil.Error
|
|
require.ErrorAs(t, err, &typed)
|
|
// network/transport classified as network.error (mirrors auth login's
|
|
// CodeAuthBadCredential mapping pattern; here we keep network errors
|
|
// distinct since auth/refresh treats them as retryable).
|
|
assert.Equal(t, cmdutil.CodeNetworkError, typed.Code)
|
|
}
|
|
|
|
func TestRefresh_JSONOutput(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
store := secrets.NewMemStore()
|
|
require.NoError(t, store.Set("prod", "refresh", "ok-refresh"))
|
|
cfg := &config.Config{
|
|
CurrentContext: "prod",
|
|
Contexts: map[string]config.Context{"prod": {Host: "https://kb", TokenRef: "mem://prod/access", RefreshRef: "mem://prod/refresh"}},
|
|
}
|
|
f := newRefreshFactory(t, cfg, store)
|
|
svc := &fakeRefreshService{resp: &sdk.RefreshTokenResponse{Success: true, AccessToken: "a", RefreshToken: "r"}}
|
|
require.NoError(t, runRefresh(context.Background(), &RefreshOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatJSON}, f, stubSvc(svc)))
|
|
|
|
body := out.String()
|
|
// payload must not leak the actual token values.
|
|
assert.NotContains(t, body, "ok-refresh", "output must not leak refresh token")
|
|
assert.NotContains(t, body, "\"a\"", "output must not leak the new access token")
|
|
assert.NotContains(t, body, "\"r\"", "output must not leak the new refresh token")
|
|
// must mention the context name so agents can confirm what was refreshed
|
|
assert.True(t, strings.Contains(body, "prod"), "output should reference the refreshed context")
|
|
// v0.7 envelope: ok:true is expected
|
|
var env struct {
|
|
OK bool `json:"ok"`
|
|
}
|
|
require.NoError(t, json.Unmarshal([]byte(body), &env))
|
|
assert.True(t, env.OK, "envelope.ok must be true")
|
|
}
|