ad150c7126
Sweep every CLI output path through the v0.7 envelope contract.
FormatOptions.Emit signature changes to (w, data, meta *output.Meta)
so list commands surface meta.count / has_more in the wire envelope.
TTY indent decision plumbed via FormatOptions.TTY (set by
ResolveDefault). --format and --jq promoted to persistent root flags
so unknown-subcommand paths still reach the typed-envelope guard
(per-command registration would have rejected --format on unknown
commands as cobra-prose exit 2). WEKNORA_FORMAT env-var fallback
honored before TTY-resolved default. AddFormatFlag retained for the
per-command --jq field-hint Long-text addendum.
~55 production Emit call sites swept across cli/cmd/**: list paths
populate meta.count; mutation paths pass nil meta; envelope.profile
threaded via globalProfile. Existing JSON-shape tests migrated to
decode the envelope wrapper.
Multi-target batch operations get a unified shape via new helpers:
- output.BatchItem + output.WriteBatchEnvelope (§4.5 per-item ok
pattern; data:[{id, ok, result?|error?}], meta:{count, successes*,
failures*}; Successes/Failures *int so explicit zero survives
omitempty in all-fail case).
- cmdutil.RunBatch + cmdutil.EmitBatch + cmdutil.DeletedAtNow +
cmdutil.ClassifyContextErr collapse the three previously-duplicated
multi-delete pipelines (doc / chunk / session) into one call site
pattern. doc upload --recursive uses the same helpers with a per-
file resultFn. Summary error sets Silent:true so the stderr
envelope path doesn't duplicate the stdout batch detail (exit 1
preserved via Code → ExitCode).
ConfirmDestructive / ConfirmDestructiveBatch extended with action +
retryCmd parameters. Every destructive command (kb delete, kb edit,
doc delete, doc delete --all, agent delete, agent edit, session
delete, chunk delete, auth logout, api -X DELETE) now attaches
error.risk.{level:"destructive", action:"<noun.verb>"} +
error.retry_command on the exit-10 envelope. kb edit / agent edit
also gain the destructive guard wiring (CHANGELOG listed them as
gated but they were silently executing without -y).
MCP tool handlers' 31 error paths return CallToolResult with
IsError + Content text fallback + StructuredContent (envelope.error
shape via cmdutil.ErrorToDetail). Handler Out type changed from
typed *sdk.X to any so the go-sdk auto-marshal doesn't overwrite
StructuredContent with a zero-struct on error returns. Success path
manually populates CallToolResult.StructuredContent via successResult
helper.
weknora api cleanup:
- -d/--data flag removed; body via --input <file> or --input -
(stdin) only. Aligns with gh / curl convention.
- HTTP method whitelist removed; any non-empty method accepted.
- HTTP Retry-After header → cmdutil.Error.RetryAfterSeconds →
envelope.error.retry_after_seconds.
- runAPIPaginated raw-passthrough fallback now wraps response in
envelope so --paginate never emits bare JSON to stdout.
Test sweep: ~60 cmd/** tests migrated to decode envelope shape.
9 wire-contract goldens updated under cli/acceptance/testdata/wire/.
Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §4 / §5
112 lines
3.3 KiB
Go
112 lines
3.3 KiB
Go
package agentcmd
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"io"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
// AgentStatusResult is the shallow health snapshot for `agent status <id>`.
|
|
//
|
|
// One HTTP call: reachable + model_id. For downstream KB reachability
|
|
// verification use 'agent check <id>' (1 + N HTTP).
|
|
//
|
|
// model_reachable is intentionally OMITTED: the server has no per-agent
|
|
// test endpoint, so we cannot verify model reachability from the agent
|
|
// resource alone.
|
|
type AgentStatusResult struct {
|
|
ID string `json:"id"`
|
|
Reachable bool `json:"reachable"`
|
|
ModelID string `json:"model_id,omitempty"`
|
|
}
|
|
|
|
// AgentStatusService is the narrow SDK surface needed for agent status.
|
|
type AgentStatusService interface {
|
|
GetAgent(ctx context.Context, id string) (*sdk.Agent, error)
|
|
}
|
|
|
|
var agentStatusFields = []string{"id", "reachable", "model_id"}
|
|
|
|
func NewCmdStatus(f *cmdutil.Factory) *cobra.Command {
|
|
cmd := &cobra.Command{
|
|
Use: "status <agent-id>",
|
|
Short: "Show health status of a custom agent",
|
|
Long: `Shallow health snapshot for an agent (1 HTTP call).
|
|
|
|
Returns: reachable / model_id.
|
|
|
|
For downstream KB reachability verification use 'weknora agent check <id>'
|
|
(active verification, 1 + N HTTP). For full agent config / metadata use
|
|
'weknora agent view <id>'.`,
|
|
Example: ` weknora agent status ag_abc
|
|
weknora agent status ag_abc --format json`,
|
|
Args: cobra.ExactArgs(1),
|
|
RunE: func(c *cobra.Command, args []string) error {
|
|
fopts, err := cmdutil.CheckFormatFlag(c)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
fopts.ResolveDefault(iostreams.IO.IsStdoutTTY())
|
|
cli, err := f.Client()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
res, err := runAgentStatus(c.Context(), cli, args[0])
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return emitAgentStatus(res, fopts, iostreams.IO.Out)
|
|
},
|
|
}
|
|
cmdutil.AddFormatFlag(cmd, agentStatusFields...)
|
|
return cmd
|
|
}
|
|
|
|
// runAgentStatus is the testable core. Never errors for "agent not
|
|
// reachable" — Reachable=false carries that signal.
|
|
func runAgentStatus(ctx context.Context, svc AgentStatusService, id string) (*AgentStatusResult, error) {
|
|
a, err := svc.GetAgent(ctx, id)
|
|
if err != nil {
|
|
return &AgentStatusResult{ID: id, Reachable: false}, nil
|
|
}
|
|
res := &AgentStatusResult{ID: a.ID, Reachable: true}
|
|
if a.Config != nil {
|
|
res.ModelID = a.Config.ModelID
|
|
}
|
|
return res, nil
|
|
}
|
|
|
|
// emitAgentStatus renders res per --format. Mirrors emitStatus pattern from
|
|
// cli/cmd/kb/status.go (C3).
|
|
func emitAgentStatus(res *AgentStatusResult, fopts *cmdutil.FormatOptions, w io.Writer) error {
|
|
switch fopts.Mode {
|
|
case cmdutil.FormatJSON, cmdutil.FormatNDJSON:
|
|
return fopts.Emit(w, res, nil)
|
|
case cmdutil.FormatHuman, "":
|
|
return writeAgentStatusText(w, res)
|
|
default:
|
|
return fmt.Errorf("unsupported --format %q for agent status", fopts.Mode)
|
|
}
|
|
}
|
|
|
|
func writeAgentStatusText(w io.Writer, res *AgentStatusResult) error {
|
|
fmt.Fprintf(w, "ID: %s\n", res.ID)
|
|
fmt.Fprintf(w, "Reachable: %v\n", res.Reachable)
|
|
if !res.Reachable {
|
|
return nil
|
|
}
|
|
if res.ModelID != "" {
|
|
fmt.Fprintf(w, "Model: %s\n", res.ModelID)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// compile-time check: SDK client satisfies AgentStatusService.
|
|
var _ AgentStatusService = (*sdk.Client)(nil)
|