9ca4e1f23a
Block chat when agents lack an explicit chat or rerank model, guide users through the selector and editor with field highlight, and align session QA checks with the same readiness rules on backend and frontend.
86 lines
2.0 KiB
Go
86 lines
2.0 KiB
Go
package service
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/Tencent/WeKnora/internal/types"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestResolveChatModelIDRequiresConfiguredAgentModel(t *testing.T) {
|
|
svc := &sessionService{
|
|
modelService: &stubModelService{
|
|
modelsByID: map[string]*types.Model{
|
|
"builtin-chat": {
|
|
ID: "builtin-chat",
|
|
Type: types.ModelTypeKnowledgeQA,
|
|
},
|
|
},
|
|
},
|
|
}
|
|
req := &types.QARequest{
|
|
Session: &types.Session{},
|
|
CustomAgent: &types.CustomAgent{
|
|
ID: "agent-1",
|
|
},
|
|
// Even a valid request-level model must not hide incomplete agent config.
|
|
SummaryModelID: "builtin-chat",
|
|
}
|
|
|
|
modelID, err := svc.resolveChatModelID(context.Background(), req, nil, nil)
|
|
|
|
require.Error(t, err)
|
|
assert.Empty(t, modelID)
|
|
assert.Contains(t, err.Error(), "model_id")
|
|
}
|
|
|
|
func TestResolveChatModelIDRejectsUnavailableConfiguredAgentModel(t *testing.T) {
|
|
svc := &sessionService{
|
|
modelService: &stubModelService{modelsByID: map[string]*types.Model{}},
|
|
}
|
|
req := &types.QARequest{
|
|
Session: &types.Session{},
|
|
CustomAgent: &types.CustomAgent{
|
|
ID: "agent-1",
|
|
Config: types.CustomAgentConfig{
|
|
ModelID: "deleted-model",
|
|
},
|
|
},
|
|
}
|
|
|
|
modelID, err := svc.resolveChatModelID(context.Background(), req, nil, nil)
|
|
|
|
require.Error(t, err)
|
|
assert.Empty(t, modelID)
|
|
assert.Contains(t, err.Error(), "unavailable")
|
|
}
|
|
|
|
func TestResolveChatModelIDUsesValidConfiguredAgentModel(t *testing.T) {
|
|
svc := &sessionService{
|
|
modelService: &stubModelService{
|
|
modelsByID: map[string]*types.Model{
|
|
"agent-chat": {
|
|
ID: "agent-chat",
|
|
Type: types.ModelTypeKnowledgeQA,
|
|
},
|
|
},
|
|
},
|
|
}
|
|
req := &types.QARequest{
|
|
Session: &types.Session{},
|
|
CustomAgent: &types.CustomAgent{
|
|
ID: "agent-1",
|
|
Config: types.CustomAgentConfig{
|
|
ModelID: "agent-chat",
|
|
},
|
|
},
|
|
}
|
|
|
|
modelID, err := svc.resolveChatModelID(context.Background(), req, nil, nil)
|
|
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "agent-chat", modelID)
|
|
}
|