wizardchen
d24e830c85
- Fix grep_chunks dropping the full-KB scope when a turn mixes @KB with @tag/@file: extract scopeClause and OR knowledge-ID and (kb,tenant) predicates together, matching knowledge_search's fan-out. - Consolidate the three scattered per-request @Skill/@MCP scope blocks in buildAgentConfig into applyPerRequestSkillScope / applyPerRequestMCPScope, each narrowing the whitelist and computing the must_use pin in one place. - Dedupe the two identical selection-mode normalizers in Input-field.vue. - Fix knowledge_create_test passing "" for the tagIDs []string parameter, which made the whole service test package fail to compile. - Add unit tests for scopeClause and the per-request scope helpers.
101 lines
3.1 KiB
Go
101 lines
3.1 KiB
Go
package service
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/Tencent/WeKnora/internal/types"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestResolvePerRequestMCPScope_SelectedIntersection(t *testing.T) {
|
|
effective, mode := resolvePerRequestMCPScope(
|
|
[]string{"mcp-b", "mcp-c"},
|
|
[]string{"mcp-a", "mcp-b"},
|
|
"selected",
|
|
false,
|
|
)
|
|
assert.Equal(t, "selected", mode)
|
|
assert.Equal(t, []string{"mcp-b"}, effective)
|
|
}
|
|
|
|
func TestResolvePerRequestMCPScope_SelectedRejectsOutsidePreset(t *testing.T) {
|
|
effective, mode := resolvePerRequestMCPScope(
|
|
[]string{"mcp-x"},
|
|
[]string{"mcp-a"},
|
|
"selected",
|
|
false,
|
|
)
|
|
assert.Empty(t, effective)
|
|
assert.Equal(t, "selected", mode)
|
|
}
|
|
|
|
func TestResolvePerRequestMCPScope_NoneRejectsMention(t *testing.T) {
|
|
effective, mode := resolvePerRequestMCPScope(
|
|
[]string{"mcp-iwiki"},
|
|
nil,
|
|
"none",
|
|
false,
|
|
)
|
|
assert.Empty(t, effective)
|
|
assert.Equal(t, "none", mode)
|
|
}
|
|
|
|
func TestResolvePerRequestMCPScope_SharedAgentBlocksOutsidePreset(t *testing.T) {
|
|
effective, mode := resolvePerRequestMCPScope(
|
|
[]string{"mcp-x"},
|
|
[]string{"mcp-a"},
|
|
"all",
|
|
true,
|
|
)
|
|
assert.Empty(t, effective)
|
|
assert.Equal(t, "all", mode)
|
|
}
|
|
|
|
func TestResolvePerRequestMCPScope_SharedAgentAllowsPreset(t *testing.T) {
|
|
effective, mode := resolvePerRequestMCPScope(
|
|
[]string{"mcp-a", "mcp-x"},
|
|
[]string{"mcp-a", "mcp-b"},
|
|
"all",
|
|
true,
|
|
)
|
|
assert.Equal(t, "selected", mode)
|
|
assert.Equal(t, []string{"mcp-a"}, effective)
|
|
}
|
|
|
|
func TestApplyPerRequestMCPScope_SelectedNarrowsAndPins(t *testing.T) {
|
|
cfg := &types.AgentConfig{MCPSelectionMode: "selected", MCPServices: []string{"mcp-a", "mcp-b"}}
|
|
applyPerRequestMCPScope(context.Background(), cfg, []string{"mcp-a", "mcp-b"}, false, []string{"mcp-b"})
|
|
assert.Equal(t, "selected", cfg.MCPSelectionMode)
|
|
assert.Equal(t, []string{"mcp-b"}, cfg.MCPServices)
|
|
assert.Equal(t, []string{"mcp-b"}, cfg.PinnedMCPServiceIDs)
|
|
}
|
|
|
|
func TestApplyPerRequestMCPScope_NoneIgnoresMentionAndDoesNotPin(t *testing.T) {
|
|
cfg := &types.AgentConfig{MCPSelectionMode: "none", MCPServices: []string{"mcp-a"}}
|
|
applyPerRequestMCPScope(context.Background(), cfg, []string{"mcp-a"}, false, []string{"mcp-a"})
|
|
assert.Equal(t, "none", cfg.MCPSelectionMode)
|
|
assert.Empty(t, cfg.PinnedMCPServiceIDs)
|
|
}
|
|
|
|
func TestApplyPerRequestSkillScope_SelectedEmptyIntersectionDisables(t *testing.T) {
|
|
cfg := &types.AgentConfig{SkillsEnabled: true, AllowedSkills: []string{"a", "b"}}
|
|
applyPerRequestSkillScope(context.Background(), cfg, "selected", []string{"c"})
|
|
assert.False(t, cfg.SkillsEnabled)
|
|
assert.Empty(t, cfg.PinnedSkillNames)
|
|
}
|
|
|
|
func TestApplyPerRequestSkillScope_AllPinsMentioned(t *testing.T) {
|
|
cfg := &types.AgentConfig{SkillsEnabled: true}
|
|
applyPerRequestSkillScope(context.Background(), cfg, "all", []string{"analysis", "analysis"})
|
|
assert.True(t, cfg.SkillsEnabled)
|
|
assert.Equal(t, []string{"analysis"}, cfg.AllowedSkills)
|
|
assert.Equal(t, []string{"analysis"}, cfg.PinnedSkillNames)
|
|
}
|
|
|
|
func TestApplyPerRequestSkillScope_NoneIgnores(t *testing.T) {
|
|
cfg := &types.AgentConfig{SkillsEnabled: true, AllowedSkills: []string{"a"}}
|
|
applyPerRequestSkillScope(context.Background(), cfg, "none", []string{"a"})
|
|
assert.Empty(t, cfg.PinnedSkillNames)
|
|
}
|