Files
Enterprise-Knowledge-Base/cli/cmd/skills/skills_test.go
T
nullkey d3c03b2f34 feat(cli)!: v0.10 reliability, agent-UX, and command-surface hardening
A hardening + finalization pass over the agent-first CLI: correctness fixes,
richer machine-readable signals, flag/naming consistency, and a symmetric
config surface. Pre-1.0, so it includes breaking renames.

Correctness:
- agent update: resolve/validate --model/--rerank-model (was storing a bogus
  name verbatim, corrupting config.model_id).
- doctor: honor WEKNORA_HOST / WEKNORA_API_KEY (headless path no longer reports
  "no host configured").
- session ask / MCP session_ask: text answer was empty on non-TTY — the agent
  stream sets Done=true on an intermediate agent_query frame before the answer,
  and AgentAccumulator treated the first Done as terminal. Terminate on the
  `complete` event (new sdk.AgentResponseTypeComplete), not a per-frame Done.
- batch exit codes: any per-item failure collapses to operation.failed (exit 1),
  including `doc upload --recursive` partial failures — a permanent per-file
  failure (e.g. a duplicate) no longer surfaces as a retryable exit 7 an agent
  would loop on; per-item typed errors stay in the envelope.

Agent-first signals & discovery:
- error.exit_code in the envelope (type + exit_code disambiguate the
  input.invalid_argument exit-2-vs-5 split in one JSON read).
- meta.hint on empty content search and on draft doc create; doc wait fails fast
  on a never-parsing draft instead of hanging to --timeout.
- retrieval-readiness is visible in the natural flow: kb status / kb check emit
  retrieval_ready, and kb create hints the fix when no embedding model is bound
  — an unconfigured KB no longer looks silently healthy.
- schema contract completeness: every leaf declares output + >=1 example
  (drift-guarded); output strings match the meta actually emitted; chunk list
  and search docs now emit meta.total_count (both previously dropped it).
- schema tolerates a quoted multi-word command label; zero-state auth — and
  `link` with no profile — point at profile setup / the headless WEKNORA_KB_ID
  path instead of looping on `auth login`.
- id-addressed reads tolerate a redundant --kb (doc view/wait, chunk list/view
  accept and ignore it, declared in schema) so a carried-over --kb doesn't
  exit 2; streaming commands warn that --jq does not apply to an NDJSON stream.
- keep JSON-always as the default; --jq hints spell out the .data path.

Consistency & gating:
- doc create: drop the deprecated --name alias (--title only; pre-1.0 break).
- chunk list --limit aligned to 1..10000; model list --limit/-L with
  has_more/total_count; api write-gates -X PUT/PATCH (exit 10); skills install
  expands a leading ~.
- docs corrected: search docs / doc list --keyword help is case-insensitive
  (server does LOWER LIKE); AGENTS.md risk-action list (no phantom kb.init; add
  model.update / kb.config.set) and batch example (failed item carries `error`);
  session resume --message id comes from `message list`, not the stream.
- auth/profile ergonomics: env credentials are now first-class — `auth token`
  prints the active WEKNORA_API_KEY / WEKNORA_TOKEN, and auth login/logout/refresh
  give an env-aware message instead of looping on "run auth login". `auth logout`
  clears credentials but keeps the profile registered (host preserved for
  re-login); deleting a profile is `profile remove`'s job (clean logout/remove
  separation, matching gh / lark).

Config surface (symmetric read/write, in-place model edits):
- kb config now returns a secret-free KBModelConfigView (was {}); `kb config`
  reads, new `kb config set` writes; `kb init` removed (misnomer).
- kb create --chat-model: retrieval-ready in one step.
- model update: edit a model in place (id preserved, references survive) —
  rotate --api-key-stdin, change base-url / display-name / etc.
- session continue-stream renamed to session resume.

Docs: AGENTS.md is the single wire-contract source; CHANGELOG slimmed; stale
kb-init / continue-stream references removed; skill wire-vocab guard extended.
AGENTS.md / weknora-shared SKILL document retrieval_ready (a KB needs an
embedding model to be searchable), that --jq does not apply to NDJSON
streams, and the env-credential-first auth path; the KB quickstart example
now creates a retrieval-ready KB.
2026-07-06 22:53:01 +08:00

99 lines
3.1 KiB
Go

package skillscmd
import (
"os"
"path/filepath"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
skillsfs "github.com/Tencent/WeKnora/cli/skills"
)
// TestEmbeddedSkillsPresent: the binary embeds the bundled skills with their
// SKILL.md (the parity tests guard the command vocabulary; this guards the
// embed itself stays wired).
func TestEmbeddedSkillsPresent(t *testing.T) {
skills, err := skillsfs.List()
require.NoError(t, err)
require.NotEmpty(t, skills, "at least one skill must be embedded")
for _, s := range skills {
assert.NotEmpty(t, s.Files, "%s must embed files", s.Name)
var hasMD bool
for _, f := range s.Files {
if filepath.Base(f) == "SKILL.md" {
hasMD = true
}
}
assert.True(t, hasMD, "%s must embed a SKILL.md", s.Name)
}
}
// TestWriteSkills_WritesAndIsIdempotent: install writes every embedded file
// preserving the dir structure; a second run without --force overwrites
// nothing (returns no newly-written paths); --force rewrites them.
func TestWriteSkills_WritesAndIsIdempotent(t *testing.T) {
dir := t.TempDir()
skills, err := skillsfs.List()
require.NoError(t, err)
// First install: every file written.
written, err := writeSkills(skills, dir, false)
require.NoError(t, err)
var total int
for _, s := range skills {
total += len(s.Files)
}
assert.Len(t, written, total, "first install writes every embedded file")
for _, p := range written {
_, statErr := os.Stat(p)
assert.NoError(t, statErr, "written file must exist: %s", p)
}
// Second install without --force: nothing overwritten.
again, err := writeSkills(skills, dir, false)
require.NoError(t, err)
assert.Empty(t, again, "without --force, existing files are left untouched")
// With --force: all rewritten.
forced, err := writeSkills(skills, dir, true)
require.NoError(t, err)
assert.Len(t, forced, total, "--force rewrites every file")
}
// TestResolveDir: explicit --dir wins; empty falls back to ~/.claude/skills.
func TestResolveDir(t *testing.T) {
got, err := resolveDir("/custom/path")
require.NoError(t, err)
assert.Equal(t, "/custom/path", got)
def, err := resolveDir("")
require.NoError(t, err)
assert.True(t, filepath.IsAbs(def), "default dir must be absolute")
assert.Contains(t, def, filepath.Join(".claude", "skills"))
}
// TestResolveDir_ExpandsTilde pins that a leading ~ in --dir is expanded to the
// home directory instead of creating a literal "~" directory. Regression:
// `skills install --dir '~/foo'` (quoted, so the shell doesn't expand it) used
// to create a bogus ./~ tree.
func TestResolveDir_ExpandsTilde(t *testing.T) {
home, err := os.UserHomeDir()
require.NoError(t, err)
got, err := resolveDir("~/agents/skills")
require.NoError(t, err)
assert.Equal(t, filepath.Join(home, "agents", "skills"), got)
assert.NotContains(t, got, "~", "~ must be expanded, not left literal")
bare, err := resolveDir("~")
require.NoError(t, err)
assert.Equal(t, home, bare)
// A ~ that is NOT a leading path segment is left untouched (not a home ref).
lit, err := resolveDir("/tmp/a~b")
require.NoError(t, err)
assert.Equal(t, "/tmp/a~b", lit)
}