9a76a24ce6
Replace scopes JSON with a viewer/contributor/admin role column, move unsafe-method authorization from path-prefix middleware to declarative APIKey* guards on routes, and close remaining KB-scope gaps in handlers.
84 lines
2.3 KiB
Go
84 lines
2.3 KiB
Go
package middleware
|
|
|
|
import (
|
|
"context"
|
|
"net/http"
|
|
"strings"
|
|
|
|
"github.com/Tencent/WeKnora/internal/types"
|
|
"github.com/gin-gonic/gin"
|
|
)
|
|
|
|
// isTenantAPIKeyManagementPath reports tenant API-key lifecycle endpoints that
|
|
// no scoped key may call, regardless of role.
|
|
func isTenantAPIKeyManagementPath(path string) bool {
|
|
for _, marker := range []string{"/api-keys", "/api-principal"} {
|
|
if strings.Contains(path, marker) {
|
|
return true
|
|
}
|
|
}
|
|
// Legacy reset endpoint: POST /tenants/:id/api-key (singular).
|
|
return strings.HasSuffix(path, "/api-key")
|
|
}
|
|
|
|
// RequireAPIKeyDeny rejects all X-API-Key callers. JWT sessions pass through.
|
|
func RequireAPIKeyDeny() gin.HandlerFunc {
|
|
return func(c *gin.Context) {
|
|
if _, ok := types.TenantAPIKeyScopeFromContext(c.Request.Context()); ok {
|
|
c.AbortWithStatusJSON(http.StatusForbidden, gin.H{
|
|
"error": "Forbidden: API key scope does not allow this operation",
|
|
})
|
|
return
|
|
}
|
|
c.Next()
|
|
}
|
|
}
|
|
|
|
// RequireAPIKeyMinRole enforces minRole for X-API-Key callers on every HTTP
|
|
// method. JWT sessions pass through.
|
|
func RequireAPIKeyMinRole(minRole types.TenantRole) gin.HandlerFunc {
|
|
return func(c *gin.Context) {
|
|
if err := requireTenantAPIKeyMinRole(c.Request.Context(), minRole); err != nil {
|
|
c.AbortWithStatusJSON(http.StatusForbidden, gin.H{
|
|
"error": "Forbidden: API key scope does not allow this operation",
|
|
})
|
|
return
|
|
}
|
|
c.Next()
|
|
}
|
|
}
|
|
|
|
// RequireAPIKeyMinRoleForUnsafe enforces minRole for X-API-Key callers on
|
|
// POST/PUT/PATCH/DELETE only. Safe reads (GET/HEAD/OPTIONS) pass through so
|
|
// group-level guards can cover mixed read/write route trees.
|
|
func RequireAPIKeyMinRoleForUnsafe(minRole types.TenantRole) gin.HandlerFunc {
|
|
return func(c *gin.Context) {
|
|
if isSafeHTTPMethod(c.Request.Method) {
|
|
c.Next()
|
|
return
|
|
}
|
|
if err := requireTenantAPIKeyMinRole(c.Request.Context(), minRole); err != nil {
|
|
c.AbortWithStatusJSON(http.StatusForbidden, gin.H{
|
|
"error": "Forbidden: API key scope does not allow this operation",
|
|
})
|
|
return
|
|
}
|
|
c.Next()
|
|
}
|
|
}
|
|
|
|
func requireTenantAPIKeyMinRole(ctx context.Context, minRole types.TenantRole) error {
|
|
scope, ok := types.TenantAPIKeyScopeFromContext(ctx)
|
|
if !ok {
|
|
return nil
|
|
}
|
|
role := scope.Role
|
|
if role == "" {
|
|
role = types.TenantRoleViewer
|
|
}
|
|
if !role.HasPermission(minRole) {
|
|
return errTenantAPIKeyScopeForbidden
|
|
}
|
|
return nil
|
|
}
|