35c79281c8
Final design-pass audit on the v0.3 surface flagged two real gaps. (A) doc view <id> was missing. Every other resource subtree exposes a view verb (kb view, session view) for inspecting a single record, but doc — which has the richest metadata of the three (title, file name, type, size, parse_status, embedding_model, processed_at, error_message) — had no single-doc surface. Users wanting one doc's metadata had to `doc list | grep`. Implementation mirrors kb view: narrow ViewService(GetKnowledge) interface, --json envelope path, human KEY: VALUE renderer. Optional fields are omitted rather than rendered as "-" so the panel is dense. Tested: human renderer, title fallback when FileName empty, omit-empty contract, JSON envelope shape, 404 classification. (B) link had no counterpart. Once .weknora/project.yaml is written, the only way to clear it was `rm` by hand. Both vercel and netlify ship `unlink` as a top-level verb; not having one was a discoverability gap. Top-level rather than `link --clear` follows the verb-noun convention of the rest of the surface — the verb stands alone and the operation isn't parameterised. unlink walks up from cwd via projectlink.Discover (the same parent-chain logic Factory.ResolveKB uses on the read side), so a user in a subdirectory of a linked project can unlink without cd-ing up. Errors with input.invalid_argument when no link is found anywhere in the chain. Idempotent under racy concurrent removal: os.ErrNotExist on os.Remove falls through to a Success envelope since the post-condition holds either way. projectlink package gained Remove() alongside Save / Load / Discover so unlink doesn't reimplement the idempotent-remove pattern inline. Top-level registration in cmd/root.go, alongside link. cli/AGENTS.md verb canon line adds unlink to the locally-introduced list. cli/CHANGELOG.md gains an Added entry for each. 5 unit tests for view + 4 for unlink (cwd / walk-up / no-link error / JSON envelope). Full suite green. Intentionally deferred: - session edit (rename a session): sessions auto-name from the first prompt; polish rather than a gap. - link --clear as an alternative to unlink: top-level unlink is the documented form; aliases would just multiply the surface.
98 lines
2.6 KiB
Go
98 lines
2.6 KiB
Go
package linkcmd
|
|
|
|
import (
|
|
"errors"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
"github.com/Tencent/WeKnora/cli/internal/projectlink"
|
|
)
|
|
|
|
// mkLinkFile seeds .weknora/project.yaml in dir so the unlink path has
|
|
// something to remove. Returns the absolute file path.
|
|
func mkLinkFile(t *testing.T, dir string) string {
|
|
t.Helper()
|
|
full := filepath.Join(dir, projectlink.DirName, projectlink.FileName)
|
|
if err := os.MkdirAll(filepath.Dir(full), 0o755); err != nil {
|
|
t.Fatalf("mkdir: %v", err)
|
|
}
|
|
if err := projectlink.Save(full, &projectlink.Project{Context: "default", KBID: "kb_abc"}); err != nil {
|
|
t.Fatalf("save: %v", err)
|
|
}
|
|
return full
|
|
}
|
|
|
|
func TestUnlink_RemovesLinkInCwd(t *testing.T) {
|
|
_, _ = iostreams.SetForTest(t)
|
|
tmp := t.TempDir()
|
|
linkPath := mkLinkFile(t, tmp)
|
|
t.Chdir(tmp)
|
|
|
|
if err := runUnlink(&UnlinkOptions{}); err != nil {
|
|
t.Fatalf("runUnlink: %v", err)
|
|
}
|
|
if _, err := os.Stat(linkPath); !os.IsNotExist(err) {
|
|
t.Errorf("link file should be gone, got err=%v", err)
|
|
}
|
|
}
|
|
|
|
func TestUnlink_WalksUpFromSubdir(t *testing.T) {
|
|
_, _ = iostreams.SetForTest(t)
|
|
root := t.TempDir()
|
|
linkPath := mkLinkFile(t, root)
|
|
sub := filepath.Join(root, "deep", "nested")
|
|
if err := os.MkdirAll(sub, 0o755); err != nil {
|
|
t.Fatalf("mkdir sub: %v", err)
|
|
}
|
|
t.Chdir(sub)
|
|
|
|
if err := runUnlink(&UnlinkOptions{}); err != nil {
|
|
t.Fatalf("runUnlink: %v", err)
|
|
}
|
|
if _, err := os.Stat(linkPath); !os.IsNotExist(err) {
|
|
t.Errorf("parent link file should be gone, got err=%v", err)
|
|
}
|
|
}
|
|
|
|
func TestUnlink_NoLink_Errors(t *testing.T) {
|
|
_, _ = iostreams.SetForTest(t)
|
|
tmp := t.TempDir()
|
|
t.Chdir(tmp)
|
|
|
|
err := runUnlink(&UnlinkOptions{})
|
|
if err == nil {
|
|
t.Fatal("expected error when no link present")
|
|
}
|
|
var typed *cmdutil.Error
|
|
if !errors.As(err, &typed) {
|
|
t.Fatalf("expected *cmdutil.Error, got %T", err)
|
|
}
|
|
if typed.Code != cmdutil.CodeInputInvalidArgument {
|
|
t.Errorf("expected CodeInputInvalidArgument, got %s", typed.Code)
|
|
}
|
|
if !strings.Contains(typed.Message, projectlink.DirName) {
|
|
t.Errorf("error message should name the missing path; got %q", typed.Message)
|
|
}
|
|
}
|
|
|
|
func TestUnlink_JSON_Envelope(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
tmp := t.TempDir()
|
|
mkLinkFile(t, tmp)
|
|
t.Chdir(tmp)
|
|
|
|
if err := runUnlink(&UnlinkOptions{JSONOut: true}); err != nil {
|
|
t.Fatalf("runUnlink: %v", err)
|
|
}
|
|
got := out.String()
|
|
for _, want := range []string{`"ok":true`, `"project_link_path"`, projectlink.DirName} {
|
|
if !strings.Contains(got, want) {
|
|
t.Errorf("missing %q in envelope:\n%s", want, got)
|
|
}
|
|
}
|
|
}
|