41a98b5743
New v0.3 P0 entry 3-4: kubectl-style context-management subtree using gh's `<noun> <verb>` surface convention consistent with the rest of this CLI. - context list: tabwriter rendering + --json envelope; reads config.yaml only. - context add <name> --host <url> [--user]: validates http(s) URL, first context auto-becomes current, rejects duplicates with did-you-mean. - context remove <name>: best-effort keyring cleanup like `auth logout`. Removing the current context triggers exit-10 confirmation (lark-cli skill protocol) — subsequent commands would lose their default --context. (`context use` predates v0.3; the subtree was previously use-only.) Bugs caught and fixed inline by the post-commit reviewer round: - auth login was accepting `http://` (empty host portion) because the old validateHost only checked the scheme. New cmdutil.NormalizeHost (shared by both login and context add) requires u.Host != "". - context add's validateName claimed `..` was rejected but only denied / \\ space. Switched to positive allowlist [A-Za-z0-9._-] plus explicit ./../path-separator rejection. Helper consolidation: - cli/internal/cmdutil/host.go: NormalizeHost (trim, scheme, host non-empty) — both auth login and context add share it. - cli/internal/format/dash.go: DashIfEmpty — promoted from copies in cmd/auth/list.go and cmd/context/list.go. - recordingStore test stub dropped in favor of secrets.NewMemStore; contextKeyList test helper replaced by the existing contextKeys. 14 unit tests; 13 e2e branches verified. Roadmap: 3-4.
120 lines
3.4 KiB
Go
120 lines
3.4 KiB
Go
package contextcmd
|
|
|
|
import (
|
|
"encoding/json"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/config"
|
|
"github.com/Tencent/WeKnora/cli/internal/format"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
)
|
|
|
|
func TestList_Empty(t *testing.T) {
|
|
t.Setenv("XDG_CONFIG_HOME", t.TempDir())
|
|
out, _ := iostreams.SetForTest(t)
|
|
|
|
if err := runList(&ListOptions{}); err != nil {
|
|
t.Fatalf("runList: %v", err)
|
|
}
|
|
if !strings.Contains(out.String(), "No contexts") {
|
|
t.Errorf("empty output should mention `No contexts`, got %q", out.String())
|
|
}
|
|
}
|
|
|
|
func TestList_MultipleSorted(t *testing.T) {
|
|
t.Setenv("XDG_CONFIG_HOME", t.TempDir())
|
|
out, _ := iostreams.SetForTest(t)
|
|
|
|
cfg := &config.Config{
|
|
CurrentContext: "staging",
|
|
Contexts: map[string]config.Context{
|
|
"production": {Host: "https://prod.example.com", User: "alice@example.com"},
|
|
"staging": {Host: "https://staging.example.com"},
|
|
"alpha": {Host: "https://alpha.example.com"},
|
|
},
|
|
}
|
|
if err := config.Save(cfg); err != nil {
|
|
t.Fatalf("Save: %v", err)
|
|
}
|
|
|
|
if err := runList(&ListOptions{}); err != nil {
|
|
t.Fatalf("runList: %v", err)
|
|
}
|
|
got := out.String()
|
|
// header
|
|
if !strings.Contains(got, "NAME") || !strings.Contains(got, "HOST") {
|
|
t.Errorf("missing header NAME/HOST in %q", got)
|
|
}
|
|
// row ordering: alpha < production < staging
|
|
iAlpha := strings.Index(got, "alpha")
|
|
iProd := strings.Index(got, "production")
|
|
iStg := strings.Index(got, "staging")
|
|
if !(iAlpha < iProd && iProd < iStg) {
|
|
t.Errorf("rows must be alphabetical, got order alpha=%d prod=%d staging=%d in %q", iAlpha, iProd, iStg, got)
|
|
}
|
|
// active marker on staging row
|
|
stgLine := lineContaining(got, "staging")
|
|
if !strings.HasPrefix(stgLine, "*") {
|
|
t.Errorf("active context row must start with `*`, got %q", stgLine)
|
|
}
|
|
}
|
|
|
|
func TestList_JSON(t *testing.T) {
|
|
t.Setenv("XDG_CONFIG_HOME", t.TempDir())
|
|
out, _ := iostreams.SetForTest(t)
|
|
|
|
cfg := &config.Config{
|
|
CurrentContext: "staging",
|
|
Contexts: map[string]config.Context{
|
|
"staging": {Host: "https://staging.example.com", User: "bob@example.com"},
|
|
"production": {Host: "https://prod.example.com"},
|
|
},
|
|
}
|
|
if err := config.Save(cfg); err != nil {
|
|
t.Fatalf("Save: %v", err)
|
|
}
|
|
|
|
if err := runList(&ListOptions{JSONOut: true}); err != nil {
|
|
t.Fatalf("runList: %v", err)
|
|
}
|
|
|
|
var env format.Envelope
|
|
if err := json.Unmarshal(out.Bytes(), &env); err != nil {
|
|
t.Fatalf("invalid JSON envelope: %v\noutput=%q", err, out.String())
|
|
}
|
|
if !env.OK {
|
|
t.Fatalf("envelope.ok=false, error=%+v", env.Error)
|
|
}
|
|
if env.Meta == nil || env.Meta.Context != "staging" {
|
|
t.Errorf("envelope._meta.context should be %q, got %+v", "staging", env.Meta)
|
|
}
|
|
rows, ok := env.Data.([]any)
|
|
if !ok {
|
|
t.Fatalf("envelope.data should be []listEntry, got %T", env.Data)
|
|
}
|
|
if len(rows) != 2 {
|
|
t.Fatalf("expected 2 entries, got %d", len(rows))
|
|
}
|
|
// alphabetical: production before staging
|
|
first := rows[0].(map[string]any)
|
|
if first["name"] != "production" {
|
|
t.Errorf("first row should be production, got %v", first)
|
|
}
|
|
second := rows[1].(map[string]any)
|
|
if second["name"] != "staging" || second["current"] != true {
|
|
t.Errorf("second row should be staging with current=true, got %v", second)
|
|
}
|
|
}
|
|
|
|
// lineContaining returns the first line of s that contains needle (trimmed of
|
|
// the trailing newline) or "" if no line matches.
|
|
func lineContaining(s, needle string) string {
|
|
for l := range strings.SplitSeq(s, "\n") {
|
|
if strings.Contains(l, needle) {
|
|
return l
|
|
}
|
|
}
|
|
return ""
|
|
}
|