nullkey
f2e8e3f56c
Survey of 10 mainstream CLIs (gh, lark, stripe, vercel, supabase, aws, azure, gcloud, openai/codex, github-copilot-cli) showed env-gated per-command --help blurbs are a Stripe-only pattern; gh uses env detect for telemetry only, and lark relies on installed agent Skills + MCP. Our cmd/mcp/serve already covers the dominant 2025/26 path, so internal/aiclient/ (136 LOC + 38 callsites) is net maintenance burden without precedent. - Drop internal/aiclient/ entirely (annotations + detect + tests) - Remove 38 SetAgentHelp callsites + agentAwareHelpFunc / SetHelpFunc wiring in cmd/root.go - Migrate 4 command-level rules to standard Long help (visible to all, not env-gated): doc upload mode mutex, kb edit at-least-one, kb pin idempotent, search chunks channel mutex - Rewrite AGENTS.md as a developer guide (gh-style 6 H2 / 167 lines): audience preamble + Build / Architecture / Command Structure / Testing / Code Style / Error Handling. Drops sections absent in surveyed projects (Commit & PR Conventions, Who Uses This CLI) - Clean 14 internal doc refs (ADR-N, spec §X, v0.X) in source comments and docs that pointed at docs/superpowers/ — that directory is local-only / uncommitted, so refs are dead for outside readers - Drop forward-looking "once v0.2 ships" from README
84 lines
2.3 KiB
Go
84 lines
2.3 KiB
Go
package compat
|
|
|
|
import (
|
|
"fmt"
|
|
"strconv"
|
|
"strings"
|
|
)
|
|
|
|
// Level is the client-server version compat level.
|
|
type Level int
|
|
|
|
const (
|
|
OK Level = iota // compatible
|
|
SoftWarn // server outdated; some new features may be unavailable
|
|
HardError // incompatible; CLI or server must be upgraded
|
|
)
|
|
|
|
func (l Level) String() string {
|
|
switch l {
|
|
case OK:
|
|
return "ok"
|
|
case SoftWarn:
|
|
return "soft_warn"
|
|
case HardError:
|
|
return "hard_error"
|
|
}
|
|
return "unknown"
|
|
}
|
|
|
|
// Compat compares client/server versions. Cross-minor drift is allowed:
|
|
//
|
|
// same major, client minor <= server minor -> OK
|
|
// same major, client minor > server minor -> SoftWarn (some new features may be unavailable)
|
|
// different major -> HardError
|
|
// unparseable string -> OK (fail-open, do not block)
|
|
// "(unknown)" / "" -> OK (dev build / server field missing)
|
|
func Compat(serverVer, cliVer string) (Level, string) {
|
|
sMaj, sMin, ok := parseSemver(serverVer)
|
|
if !ok {
|
|
return OK, ""
|
|
}
|
|
cMaj, cMin, ok := parseSemver(cliVer)
|
|
if !ok {
|
|
return OK, ""
|
|
}
|
|
if sMaj != cMaj {
|
|
return HardError, fmt.Sprintf("incompatible: client %s vs server %s - upgrade required", cliVer, serverVer)
|
|
}
|
|
if cMin > sMin {
|
|
return SoftWarn, fmt.Sprintf("server is older (server %s, client %s); some new features may be unavailable", serverVer, cliVer)
|
|
}
|
|
return OK, ""
|
|
}
|
|
|
|
// parseSemver extracts (major, minor) from "X.Y.Z" or "X.Y.Z-suffix".
|
|
// Accepts the leading "v" common in `git describe` output and Tencent/WeKnora
|
|
// tag conventions ("v0.1.0"), since both server `/system/info.version` and
|
|
// the CLI's own ldflags-injected build.Version may carry it.
|
|
// Returns ok=false when the string is unrecognizable (empty / "(unknown)" / non-numeric).
|
|
func parseSemver(s string) (major, minor int, ok bool) {
|
|
if s == "" || s == "(unknown)" {
|
|
return 0, 0, false
|
|
}
|
|
// Accept the "v" prefix; both `git describe` output and Tencent/WeKnora tags carry it.
|
|
s = strings.TrimPrefix(s, "v")
|
|
// Strip prerelease/build metadata.
|
|
if i := strings.IndexAny(s, "-+"); i >= 0 {
|
|
s = s[:i]
|
|
}
|
|
parts := strings.SplitN(s, ".", 3)
|
|
if len(parts) < 2 {
|
|
return 0, 0, false
|
|
}
|
|
maj, err := strconv.Atoi(parts[0])
|
|
if err != nil {
|
|
return 0, 0, false
|
|
}
|
|
min, err := strconv.Atoi(parts[1])
|
|
if err != nil {
|
|
return 0, 0, false
|
|
}
|
|
return maj, min, true
|
|
}
|