nullkey
c87e35b34b
Code-reuse polish (post-implementation review pass): - Extract text.OneLine(maxWidth, s) helper combining preview-row normalization (newline/CR/tab → space) with text.Truncate's UTF-8-safe truncation. Replaces agent/view.go truncate1Line (ASCII '...' + byte-slice CJK-unsafe) and chunk/list.go singleLine. - Lift cmdutil.OpenInput(path) for the '-' = stdin / else os.Open pattern shared across agent create/edit and the api command. Replaces agent/create.go's private openInput. - Strip inline doc-spec parentheticals from source comments — those belong in commit messages and project docs, not in source where they rot. Pre-PR audit fixes: - doc upload: reject `--metadata` paired with `--from-url` as input.invalid_argument up-front (the URL-ingest request type has no metadata field server-side, so the pair would otherwise silently drop). Long help and CHANGELOG updated to call out the asymmetry. - doc upload (file path): map sdk.ErrDuplicateFile sentinel to resource.already_exists. The sentinel arrives with no "HTTP error <n>:" prefix because the SDK short-circuits on file-hash before reading the HTTP status, so the previous WrapHTTP fall-through misclassified it as network.error with a misleading "check base URL reachability" hint. The --from-url branch already handled ErrDuplicateURL this way; this closes the asymmetry. Caught by e2e re-upload of an already-ingested file; regression test added. - README exit-10 enumeration adds `agent delete` and `chunk delete` (these were missing alongside the v0.5 destructive verbs they were meant to gate). Docs sync: - cli/README.md: command tree now includes the chunk subtree; adds agent / chunk lines to the 5-minute quickstart; adds a "Contributing / Reporting issues" section pointing at the repo's SECURITY.md and AGENTS.md; drops third-party CLI parallels from the surface description. - cli/AGENTS.md: "Command surface design SOP" gains the flag-vs-escape-hatch step. "CRUD command flag canon" renamed to the hard-required-flags pattern with the contrast (TTY-prompts-fill) defined inline rather than via opaque shorthand. - cli/CHANGELOG.md: search docs case-sensitivity shift promoted to its own #### Breaking changes subsection. MCP doc_list filter count corrected from 5 to 6. Drops the bogus go.mod yaml.v3 entry (yaml.v3 was already a dependency on main; v0.5 added zero go.mod lines). Replaces internal-Go identifiers (fuzzyTime, NoOptDefVal) with user-language and drops the § section-symbol jargon.
115 lines
3.4 KiB
Go
115 lines
3.4 KiB
Go
package cmdutil
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
func TestLoadConfigFile_YAML(t *testing.T) {
|
|
yaml := strings.NewReader(`
|
|
agent_mode: smart-reasoning
|
|
model_id: model-x
|
|
temperature: 0.7
|
|
knowledge_bases:
|
|
- kb_abc
|
|
- kb_def
|
|
`)
|
|
cfg, err := LoadAgentConfig(yaml, "yaml")
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "smart-reasoning", cfg.AgentMode)
|
|
assert.Equal(t, "model-x", cfg.ModelID)
|
|
assert.InDelta(t, 0.7, cfg.Temperature, 0.001)
|
|
assert.Equal(t, []string{"kb_abc", "kb_def"}, cfg.KnowledgeBases)
|
|
}
|
|
|
|
func TestLoadConfigFile_JSON(t *testing.T) {
|
|
js := strings.NewReader(`{"agent_mode":"quick-answer","model_id":"model-y"}`)
|
|
cfg, err := LoadAgentConfig(js, "json")
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "quick-answer", cfg.AgentMode)
|
|
assert.Equal(t, "model-y", cfg.ModelID)
|
|
}
|
|
|
|
func TestLoadConfigFile_UnknownKind(t *testing.T) {
|
|
_, err := LoadAgentConfig(strings.NewReader(""), "xml")
|
|
require.Error(t, err)
|
|
assert.Contains(t, err.Error(), "unknown config format")
|
|
}
|
|
|
|
func TestLoadConfigFile_BadYAML(t *testing.T) {
|
|
_, err := LoadAgentConfig(strings.NewReader("not: : yaml"), "yaml")
|
|
require.Error(t, err)
|
|
}
|
|
|
|
func TestLoadConfigFile_BadJSON(t *testing.T) {
|
|
_, err := LoadAgentConfig(strings.NewReader("{not json"), "json")
|
|
require.Error(t, err)
|
|
}
|
|
|
|
func TestMergeAgentConfig_FlagsOverrideFile(t *testing.T) {
|
|
base := &sdk.AgentConfig{ModelID: "model-y"}
|
|
overrides := AgentConfigFlags{ModelIDSet: true, ModelID: "model-x"}
|
|
merged := MergeAgentConfig(base, overrides)
|
|
assert.Equal(t, "model-x", merged.ModelID)
|
|
}
|
|
|
|
func TestMergeAgentConfig_UnsetFlagsPreserveBase(t *testing.T) {
|
|
base := &sdk.AgentConfig{ModelID: "model-y", Temperature: 0.5}
|
|
overrides := AgentConfigFlags{} // nothing set
|
|
merged := MergeAgentConfig(base, overrides)
|
|
assert.Equal(t, "model-y", merged.ModelID)
|
|
assert.InDelta(t, 0.5, merged.Temperature, 0.001)
|
|
}
|
|
|
|
func TestMergeAgentConfig_EveryFieldOverlay(t *testing.T) {
|
|
base := &sdk.AgentConfig{
|
|
AgentMode: "quick-answer",
|
|
SystemPrompt: "old",
|
|
ModelID: "model-y",
|
|
RerankModelID: "rerank-old",
|
|
Temperature: 0.1,
|
|
KBSelectionMode: "all",
|
|
KnowledgeBases: []string{"kb_old"},
|
|
}
|
|
overrides := AgentConfigFlags{
|
|
AgentMode: "smart-reasoning", AgentModeSet: true,
|
|
SystemPrompt: "new", SystemPromptSet: true,
|
|
ModelID: "model-x", ModelIDSet: true,
|
|
RerankModelID: "rerank-new", RerankModelIDSet: true,
|
|
Temperature: 0.9, TemperatureSet: true,
|
|
KBSelectionMode: "selected", KBSelectionModeSet: true,
|
|
KnowledgeBases: []string{"kb_new"}, KnowledgeBasesSet: true,
|
|
}
|
|
merged := MergeAgentConfig(base, overrides)
|
|
assert.Equal(t, "smart-reasoning", merged.AgentMode)
|
|
assert.Equal(t, "new", merged.SystemPrompt)
|
|
assert.Equal(t, "model-x", merged.ModelID)
|
|
assert.Equal(t, "rerank-new", merged.RerankModelID)
|
|
assert.InDelta(t, 0.9, merged.Temperature, 0.001)
|
|
assert.Equal(t, "selected", merged.KBSelectionMode)
|
|
assert.Equal(t, []string{"kb_new"}, merged.KnowledgeBases)
|
|
}
|
|
|
|
func TestGenerateSkeleton_EmitsAllFields(t *testing.T) {
|
|
var out strings.Builder
|
|
require.NoError(t, GenerateAgentSkeleton(&out))
|
|
body := out.String()
|
|
for _, field := range []string{
|
|
"agent_mode:",
|
|
"model_id:",
|
|
"system_prompt:",
|
|
"knowledge_bases:",
|
|
"fallback_strategy:",
|
|
"context_template:",
|
|
"max_completion_tokens:",
|
|
"embedding_top_k:",
|
|
} {
|
|
assert.Contains(t, body, field, "skeleton missing field %s", field)
|
|
}
|
|
}
|