76a4ffe525
Let tenant admins list and open API-key sessions from the Web console while keeping per-key isolation for everyone else. Pin the session source filter so it no longer jumps when switching buckets, and resolve session origin on read so deep links stay in sync with the active folder after refresh.
216 lines
7.4 KiB
Go
216 lines
7.4 KiB
Go
package service
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/Tencent/WeKnora/internal/application/repository"
|
|
apperrors "github.com/Tencent/WeKnora/internal/errors"
|
|
"github.com/Tencent/WeKnora/internal/types"
|
|
"github.com/stretchr/testify/require"
|
|
"gorm.io/driver/sqlite"
|
|
"gorm.io/gorm"
|
|
)
|
|
|
|
func testSessionScopeContext(tenantID uint64, userID string) context.Context {
|
|
ctx := context.WithValue(context.Background(), types.TenantIDContextKey, tenantID)
|
|
if userID != "" {
|
|
ctx = context.WithValue(ctx, types.UserIDContextKey, userID)
|
|
}
|
|
return ctx
|
|
}
|
|
|
|
func testAPISessionScopeContext(tenantID uint64, externalUserID string) context.Context {
|
|
ctx := context.WithValue(context.Background(), types.TenantIDContextKey, tenantID)
|
|
ctx = context.WithValue(ctx, types.UserIDContextKey, "system-7")
|
|
return types.WithPrincipal(ctx, types.Principal{
|
|
Type: types.PrincipalAPIExternalUser,
|
|
ID: externalUserID,
|
|
})
|
|
}
|
|
|
|
func newTestSessionService(t *testing.T) (*sessionService, *gorm.DB) {
|
|
t.Helper()
|
|
|
|
db, err := gorm.Open(sqlite.Open(":memory:"), &gorm.Config{})
|
|
require.NoError(t, err)
|
|
require.NoError(t, db.AutoMigrate(&types.Session{}))
|
|
|
|
return &sessionService{
|
|
sessionRepo: repository.NewSessionRepository(db),
|
|
}, db
|
|
}
|
|
|
|
func TestGetSessionIsScopedToCurrentUser(t *testing.T) {
|
|
svc, db := newTestSessionService(t)
|
|
aliceSession := &types.Session{
|
|
TenantID: 1,
|
|
UserID: "alice",
|
|
Title: "alice private session",
|
|
}
|
|
require.NoError(t, db.Create(aliceSession).Error)
|
|
bobSession := &types.Session{
|
|
TenantID: 1,
|
|
UserID: "bob",
|
|
Title: "bob private session",
|
|
}
|
|
require.NoError(t, db.Create(bobSession).Error)
|
|
legacySession := &types.Session{
|
|
TenantID: 1,
|
|
Title: "legacy tenant session",
|
|
}
|
|
require.NoError(t, db.Create(legacySession).Error)
|
|
|
|
_, err := svc.GetSession(testSessionScopeContext(1, "bob"), aliceSession.ID)
|
|
require.ErrorIs(t, err, apperrors.ErrSessionNotFound)
|
|
|
|
got, err := svc.GetSession(testSessionScopeContext(1, "bob"), bobSession.ID)
|
|
require.NoError(t, err)
|
|
require.Equal(t, bobSession.ID, got.ID)
|
|
|
|
got, err = svc.GetSession(testSessionScopeContext(1, "bob"), legacySession.ID)
|
|
require.NoError(t, err)
|
|
require.Equal(t, legacySession.ID, got.ID)
|
|
}
|
|
|
|
func TestUpdateSessionIsScopedToCurrentUserAndAllowsNoOp(t *testing.T) {
|
|
svc, db := newTestSessionService(t)
|
|
aliceSession := &types.Session{
|
|
TenantID: 1,
|
|
UserID: "alice",
|
|
Title: "alice private session",
|
|
Description: "original description",
|
|
}
|
|
require.NoError(t, db.Create(aliceSession).Error)
|
|
|
|
err := svc.UpdateSession(testSessionScopeContext(1, "bob"), &types.Session{
|
|
ID: aliceSession.ID,
|
|
TenantID: 1,
|
|
Title: "bob update attempt",
|
|
Description: "should not be saved",
|
|
})
|
|
require.ErrorIs(t, err, apperrors.ErrSessionNotFound)
|
|
|
|
var unchanged types.Session
|
|
require.NoError(t, db.First(&unchanged, "id = ?", aliceSession.ID).Error)
|
|
require.Equal(t, aliceSession.Title, unchanged.Title)
|
|
require.Equal(t, aliceSession.Description, unchanged.Description)
|
|
|
|
err = svc.UpdateSession(testSessionScopeContext(1, "alice"), &types.Session{
|
|
ID: aliceSession.ID,
|
|
TenantID: 1,
|
|
Title: aliceSession.Title,
|
|
Description: aliceSession.Description,
|
|
})
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
func TestGetSessionIsScopedToAPIExternalUser(t *testing.T) {
|
|
svc, db := newTestSessionService(t)
|
|
aliceSession := &types.Session{
|
|
TenantID: 1,
|
|
UserID: "api_external_user:7:alice",
|
|
Title: "alice api session",
|
|
}
|
|
require.NoError(t, db.Create(aliceSession).Error)
|
|
bobSession := &types.Session{
|
|
TenantID: 1,
|
|
UserID: "api_external_user:7:bob",
|
|
Title: "bob api session",
|
|
}
|
|
require.NoError(t, db.Create(bobSession).Error)
|
|
tenantSession := &types.Session{
|
|
TenantID: 1,
|
|
UserID: "system-7",
|
|
Title: "tenant api session",
|
|
}
|
|
require.NoError(t, db.Create(tenantSession).Error)
|
|
|
|
_, err := svc.GetSession(testAPISessionScopeContext(1, "7:alice"), bobSession.ID)
|
|
require.ErrorIs(t, err, apperrors.ErrSessionNotFound)
|
|
|
|
got, err := svc.GetSession(testAPISessionScopeContext(1, "7:alice"), aliceSession.ID)
|
|
require.NoError(t, err)
|
|
require.Equal(t, aliceSession.ID, got.ID)
|
|
|
|
_, err = svc.GetSession(testAPISessionScopeContext(1, "7:alice"), tenantSession.ID)
|
|
require.ErrorIs(t, err, apperrors.ErrSessionNotFound)
|
|
|
|
got, err = svc.GetSession(testSessionScopeContext(1, "system-7"), tenantSession.ID)
|
|
require.NoError(t, err)
|
|
require.Equal(t, tenantSession.ID, got.ID)
|
|
}
|
|
|
|
func TestGetSessionAllowsAdminToOpenAPIKeySessions(t *testing.T) {
|
|
svc, db := newTestSessionService(t)
|
|
apiSession := &types.Session{
|
|
TenantID: 1,
|
|
UserID: types.SessionOwnerAPITenantKeyPrefix + "1:10",
|
|
Title: "api key session",
|
|
}
|
|
require.NoError(t, db.Create(apiSession).Error)
|
|
otherUserSession := &types.Session{
|
|
TenantID: 1,
|
|
UserID: "bob",
|
|
Title: "bob private session",
|
|
}
|
|
require.NoError(t, db.Create(otherUserSession).Error)
|
|
|
|
// A non-admin web user cannot open the API-key session.
|
|
viewerCtx := testSessionScopeContext(1, "alice")
|
|
_, err := svc.GetSession(viewerCtx, apiSession.ID)
|
|
require.ErrorIs(t, err, apperrors.ErrSessionNotFound)
|
|
|
|
// An admin can open the API-key session.
|
|
adminCtx := context.WithValue(testSessionScopeContext(1, "alice"), types.TenantRoleContextKey, types.TenantRoleAdmin)
|
|
got, err := svc.GetSession(adminCtx, apiSession.ID)
|
|
require.NoError(t, err)
|
|
require.Equal(t, apiSession.ID, got.ID)
|
|
|
|
// The admin fallback is limited to API-key sessions; another user's
|
|
// personal session stays hidden.
|
|
_, err = svc.GetSession(adminCtx, otherUserSession.ID)
|
|
require.ErrorIs(t, err, apperrors.ErrSessionNotFound)
|
|
}
|
|
|
|
func TestListSessionsAPISourceRequiresAdminAndReturnsAllKeys(t *testing.T) {
|
|
svc, db := newTestSessionService(t)
|
|
require.NoError(t, db.AutoMigrate(&testListSessionsIMChannelSession{}))
|
|
|
|
key1 := &types.Session{TenantID: 1, UserID: types.SessionOwnerAPITenantKeyPrefix + "1:10", Title: "key1"}
|
|
key2 := &types.Session{TenantID: 1, UserID: types.SessionOwnerAPITenantKeyPrefix + "1:20", Title: "key2"}
|
|
web := &types.Session{TenantID: 1, UserID: "alice", Title: "alice web"}
|
|
require.NoError(t, db.Create(key1).Error)
|
|
require.NoError(t, db.Create(key2).Error)
|
|
require.NoError(t, db.Create(web).Error)
|
|
|
|
// A non-admin (viewer) web user is rejected.
|
|
viewerCtx := testSessionScopeContext(1, "alice")
|
|
_, err := svc.ListSessions(viewerCtx, &types.SessionListQuery{Source: types.SessionSourceAPI})
|
|
require.Error(t, err)
|
|
var appErr *apperrors.AppError
|
|
require.ErrorAs(t, err, &appErr)
|
|
require.Equal(t, apperrors.ErrForbidden, appErr.Code)
|
|
|
|
// An admin sees every API-key session in the tenant, not just their own.
|
|
adminCtx := context.WithValue(testSessionScopeContext(1, "alice"), types.TenantRoleContextKey, types.TenantRoleAdmin)
|
|
result, err := svc.ListSessions(adminCtx, &types.SessionListQuery{Source: types.SessionSourceAPI})
|
|
require.NoError(t, err)
|
|
require.EqualValues(t, 2, result.Total)
|
|
}
|
|
|
|
// testListSessionsIMChannelSession lets QueryPaged's LEFT JOIN resolve against a
|
|
// real table in the in-memory SQLite database.
|
|
type testListSessionsIMChannelSession struct {
|
|
ID uint64 `gorm:"primaryKey;autoIncrement"`
|
|
SessionID string `gorm:"column:session_id"`
|
|
Platform string `gorm:"column:platform"`
|
|
ChatID string `gorm:"column:chat_id"`
|
|
ThreadID string `gorm:"column:thread_id"`
|
|
UserID string `gorm:"column:user_id"`
|
|
AgentID string `gorm:"column:agent_id"`
|
|
IMChannelID string `gorm:"column:im_channel_id"`
|
|
}
|
|
|
|
func (testListSessionsIMChannelSession) TableName() string { return "im_channel_sessions" }
|