nullkey
c87e35b34b
Code-reuse polish (post-implementation review pass): - Extract text.OneLine(maxWidth, s) helper combining preview-row normalization (newline/CR/tab → space) with text.Truncate's UTF-8-safe truncation. Replaces agent/view.go truncate1Line (ASCII '...' + byte-slice CJK-unsafe) and chunk/list.go singleLine. - Lift cmdutil.OpenInput(path) for the '-' = stdin / else os.Open pattern shared across agent create/edit and the api command. Replaces agent/create.go's private openInput. - Strip inline doc-spec parentheticals from source comments — those belong in commit messages and project docs, not in source where they rot. Pre-PR audit fixes: - doc upload: reject `--metadata` paired with `--from-url` as input.invalid_argument up-front (the URL-ingest request type has no metadata field server-side, so the pair would otherwise silently drop). Long help and CHANGELOG updated to call out the asymmetry. - doc upload (file path): map sdk.ErrDuplicateFile sentinel to resource.already_exists. The sentinel arrives with no "HTTP error <n>:" prefix because the SDK short-circuits on file-hash before reading the HTTP status, so the previous WrapHTTP fall-through misclassified it as network.error with a misleading "check base URL reachability" hint. The --from-url branch already handled ErrDuplicateURL this way; this closes the asymmetry. Caught by e2e re-upload of an already-ingested file; regression test added. - README exit-10 enumeration adds `agent delete` and `chunk delete` (these were missing alongside the v0.5 destructive verbs they were meant to gate). Docs sync: - cli/README.md: command tree now includes the chunk subtree; adds agent / chunk lines to the 5-minute quickstart; adds a "Contributing / Reporting issues" section pointing at the repo's SECURITY.md and AGENTS.md; drops third-party CLI parallels from the surface description. - cli/AGENTS.md: "Command surface design SOP" gains the flag-vs-escape-hatch step. "CRUD command flag canon" renamed to the hard-required-flags pattern with the contrast (TTY-prompts-fill) defined inline rather than via opaque shorthand. - cli/CHANGELOG.md: search docs case-sensitivity shift promoted to its own #### Breaking changes subsection. MCP doc_list filter count corrected from 5 to 6. Drops the bogus go.mod yaml.v3 entry (yaml.v3 was already a dependency on main; v0.5 added zero go.mod lines). Replaces internal-Go identifiers (fuzzyTime, NoOptDefVal) with user-language and drops the § section-symbol jargon.
102 lines
3.4 KiB
Go
102 lines
3.4 KiB
Go
package chunkcmd
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
type fakeViewSvc struct {
|
|
resp *sdk.Chunk
|
|
err error
|
|
}
|
|
|
|
func (f *fakeViewSvc) GetChunkByIDOnly(_ context.Context, _ string) (*sdk.Chunk, error) {
|
|
return f.resp, f.err
|
|
}
|
|
|
|
func TestView_Happy_RendersAllFields(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeViewSvc{resp: &sdk.Chunk{
|
|
ID: "c1",
|
|
SeqID: 42,
|
|
ChunkIndex: 0,
|
|
KnowledgeID: "doc_abc",
|
|
KnowledgeBaseID: "kb_abc",
|
|
ChunkType: "text",
|
|
IsEnabled: true,
|
|
Content: "the quick brown fox",
|
|
CreatedAt: "2026-05-15T11:00:00Z",
|
|
UpdatedAt: "2026-05-15T12:00:00Z",
|
|
}}
|
|
require.NoError(t, runView(context.Background(), &ViewOptions{ChunkID: "c1"}, nil, svc))
|
|
body := out.String()
|
|
assert.Contains(t, body, "c1")
|
|
assert.Contains(t, body, "doc_abc")
|
|
assert.Contains(t, body, "kb_abc")
|
|
assert.Contains(t, body, "text")
|
|
assert.Contains(t, body, "the quick brown fox", "content must render in full")
|
|
}
|
|
|
|
func TestView_HumanLabels_DocAndKB(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeViewSvc{resp: &sdk.Chunk{
|
|
ID: "c1", KnowledgeID: "doc_abc", KnowledgeBaseID: "kb_abc",
|
|
}}
|
|
require.NoError(t, runView(context.Background(), &ViewOptions{ChunkID: "c1"}, nil, svc))
|
|
body := out.String()
|
|
// Human KV uses friendlier DOC_ID / KB_ID labels (the SDK's
|
|
// knowledge_id / knowledge_base_id are kept only in --json output).
|
|
assert.Contains(t, body, "doc_id")
|
|
assert.Contains(t, body, "kb_id")
|
|
assert.NotContains(t, body, "knowledge_id")
|
|
assert.NotContains(t, body, "knowledge_base_id")
|
|
}
|
|
|
|
func TestView_OmitsZeroOrEmpty(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeViewSvc{resp: &sdk.Chunk{ID: "c_min", Content: "x"}}
|
|
require.NoError(t, runView(context.Background(), &ViewOptions{ChunkID: "c_min"}, nil, svc))
|
|
body := out.String()
|
|
// status / start_at / end_at all zero → must be omitted from the human KV.
|
|
assert.NotContains(t, body, "status:")
|
|
assert.NotContains(t, body, "start_at:")
|
|
assert.NotContains(t, body, "end_at:")
|
|
// tag_id / image_info empty → omitted.
|
|
assert.NotContains(t, body, "tag_id:")
|
|
assert.NotContains(t, body, "image_info:")
|
|
}
|
|
|
|
func TestView_JSON_BareSDKShape(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeViewSvc{resp: &sdk.Chunk{
|
|
ID: "c_json", KnowledgeID: "doc_abc", KnowledgeBaseID: "kb_abc",
|
|
}}
|
|
require.NoError(t, runView(context.Background(), &ViewOptions{ChunkID: "c_json"}, &cmdutil.JSONOptions{}, svc))
|
|
var got sdk.Chunk
|
|
require.NoError(t, json.Unmarshal(out.Bytes(), &got))
|
|
assert.Equal(t, "c_json", got.ID)
|
|
assert.Equal(t, "doc_abc", got.KnowledgeID)
|
|
// JSON uses SDK snake_case keys (knowledge_id), not human relabel doc_id.
|
|
assert.Contains(t, out.String(), `"knowledge_id":"doc_abc"`)
|
|
assert.Contains(t, out.String(), `"knowledge_base_id":"kb_abc"`)
|
|
assert.NotContains(t, out.String(), `"doc_id"`)
|
|
assert.NotContains(t, out.String(), `"kb_id"`)
|
|
}
|
|
|
|
func TestView_404(t *testing.T) {
|
|
_, _ = iostreams.SetForTest(t)
|
|
svc := &fakeViewSvc{err: errors.New("HTTP error 404: not found")}
|
|
err := runView(context.Background(), &ViewOptions{ChunkID: "missing"}, nil, svc)
|
|
require.Error(t, err)
|
|
assert.Contains(t, err.Error(), "resource.not_found")
|
|
}
|