2ce348d020
D1 — --format default flipped to json regardless of TTY: - v0.6: smart default (text on TTY, json on pipe). - v0.7: always json; TTY only affects indent (compact in pipe). Enum values unchanged (text | json | ndjson). - Typed FormatMode enum replaces untyped string consts. - --format / --jq promoted to persistent root flags so unknown- subcommand paths still reach the typed-envelope guard (per-command registration in v0.6 would have rejected --format on unknown commands as cobra-prose exit 2). - WEKNORA_FORMAT env var added; precedence --format > env > default. Invalid env values silently ignored. D2 — chat / session ask default to NDJSON event-stream: - New cli/internal/output/ndjson_stream.go: InitEvent struct + EmitInit / EmitSDKEvent / WriteNDJSONLine helpers. EmitInit doc encodes the must-be-first-line invariant agents key on. - chat / session ask: --format json AND --format ndjson both emit one JSON event per line (no envelope wrapping). CLI injects exactly one `init` event at stream head carrying session_id + optional kb_id / agent_id / profile. Subsequent events pass through verbatim from the SDK (passthrough discipline per spec §5.1). - --format text keeps the SSE-style live renderer. context → profile full cascade: - Command group: cli/cmd/context/ → cli/cmd/profile/ (git mv; package contextcmd → profilecmd). - Global flag --context → --profile. Factory.ContextOverride → ProfileOverride. WEKNORA_PROFILE env var honored (--profile flag > env > config.CurrentContext). When --profile or WEKNORA_PROFILE references a missing profile, the error is input.invalid_argument with hint "weknora profile list" — not the destructive local.config_corrupt path (which would have told users to delete their config file). - Binding file .weknora/project.yaml field context: → profile: (no backwards-compat alias; re-run weknora link). - profile use JSON fields current_context / previous_context → current_profile / previous_profile. - weknora link JSON field context → profile. - CodeLocalContextNotFound → CodeLocalProfileNotFound (typed code rename). - Envelope top-level profile field populated via globalProfile (set by root PersistentPreRunE from Factory.ActiveProfile). chat / session ask NDJSON init event carries the same profile. - Rationale: "context" collided with LLM context window / RAG context / Go context.Context; mainstream multi-credential CLIs (AWS / Stripe / OpenAI / Anthropic / lark) all use "profile". H2/C1' help calibration: - AgentHelp gains Warnings []string; single SetAgentHelp helper routes on WEKNORA_AGENT_HELP=1 (emits JSON blob including warnings) vs human help (appends "AI agents:" block from same source). Warnings surface as both a structured JSON field and visible help-text addendum without drift. - 9 destructive commands carry warnings: kb / doc / agent / session / chunk delete; profile remove; kb / agent edit; auth logout. - weknora doc wait dedups ids at entry; SIGINT mid-wait returns silently (root signal handler maps to exit 130) instead of being miscategorised as operation.timeout / operation.failed. A4 — docs: - cli/AGENTS.md gains four agent-facing sections: Wire contract for AI agents (stdout / stderr / NDJSON / _notice evolution / SDK contract boundary); Deliberate deviations + mainstream alignments; Pre-1.0 breaking policy; Exit-10 anti-patterns. ERROR_REFERENCE table extended. - cli/README.md adds Agent quick start under Wire contract. - cli/CHANGELOG.md v0.7 section: BREAKING entries with migration notes, Added (WEKNORA_FORMAT / WEKNORA_PROFILE / retry_command / retry_after_seconds / risk / _notice reserved infra / meta.count / meta.has_more / doc fetch / doc create / session ask / doc delete --all / NDJSON init), Changed (docs additions), Deprecated (none — pre-release one-shot breaking). Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3 / §4 / §5 / §6 / §11
109 lines
3.0 KiB
Go
109 lines
3.0 KiB
Go
package linkcmd
|
|
|
|
import (
|
|
"encoding/json"
|
|
"errors"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
"github.com/Tencent/WeKnora/cli/internal/projectlink"
|
|
)
|
|
|
|
// mkLinkFile seeds .weknora/project.yaml in dir so the unlink path has
|
|
// something to remove. Returns the absolute file path.
|
|
func mkLinkFile(t *testing.T, dir string) string {
|
|
t.Helper()
|
|
full := filepath.Join(dir, projectlink.DirName, projectlink.FileName)
|
|
if err := os.MkdirAll(filepath.Dir(full), 0o755); err != nil {
|
|
t.Fatalf("mkdir: %v", err)
|
|
}
|
|
if err := projectlink.Save(full, &projectlink.Project{Profile: "default", KBID: "kb_abc"}); err != nil {
|
|
t.Fatalf("save: %v", err)
|
|
}
|
|
return full
|
|
}
|
|
|
|
func TestUnlink_RemovesLinkInCwd(t *testing.T) {
|
|
_, _ = iostreams.SetForTest(t)
|
|
tmp := t.TempDir()
|
|
linkPath := mkLinkFile(t, tmp)
|
|
t.Chdir(tmp)
|
|
|
|
if err := runUnlink(&UnlinkOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}); err != nil {
|
|
t.Fatalf("runUnlink: %v", err)
|
|
}
|
|
if _, err := os.Stat(linkPath); !os.IsNotExist(err) {
|
|
t.Errorf("link file should be gone, got err=%v", err)
|
|
}
|
|
}
|
|
|
|
func TestUnlink_WalksUpFromSubdir(t *testing.T) {
|
|
_, _ = iostreams.SetForTest(t)
|
|
root := t.TempDir()
|
|
linkPath := mkLinkFile(t, root)
|
|
sub := filepath.Join(root, "deep", "nested")
|
|
if err := os.MkdirAll(sub, 0o755); err != nil {
|
|
t.Fatalf("mkdir sub: %v", err)
|
|
}
|
|
t.Chdir(sub)
|
|
|
|
if err := runUnlink(&UnlinkOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}); err != nil {
|
|
t.Fatalf("runUnlink: %v", err)
|
|
}
|
|
if _, err := os.Stat(linkPath); !os.IsNotExist(err) {
|
|
t.Errorf("parent link file should be gone, got err=%v", err)
|
|
}
|
|
}
|
|
|
|
func TestUnlink_NoLink_Errors(t *testing.T) {
|
|
_, _ = iostreams.SetForTest(t)
|
|
tmp := t.TempDir()
|
|
t.Chdir(tmp)
|
|
|
|
err := runUnlink(&UnlinkOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText})
|
|
if err == nil {
|
|
t.Fatal("expected error when no link present")
|
|
}
|
|
var typed *cmdutil.Error
|
|
if !errors.As(err, &typed) {
|
|
t.Fatalf("expected *cmdutil.Error, got %T", err)
|
|
}
|
|
if typed.Code != cmdutil.CodeInputInvalidArgument {
|
|
t.Errorf("expected CodeInputInvalidArgument, got %s", typed.Code)
|
|
}
|
|
if !strings.Contains(typed.Message, projectlink.DirName) {
|
|
t.Errorf("error message should name the missing path; got %q", typed.Message)
|
|
}
|
|
}
|
|
|
|
func TestUnlink_JSON_BareObject(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
tmp := t.TempDir()
|
|
mkLinkFile(t, tmp)
|
|
t.Chdir(tmp)
|
|
|
|
if err := runUnlink(&UnlinkOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatJSON}); err != nil {
|
|
t.Fatalf("runUnlink: %v", err)
|
|
}
|
|
got := out.String()
|
|
var env struct {
|
|
OK bool `json:"ok"`
|
|
Data map[string]any `json:"data"`
|
|
}
|
|
if err := json.Unmarshal([]byte(got), &env); err != nil {
|
|
t.Fatalf("parse: %v\n%s", err, got)
|
|
}
|
|
if !env.OK {
|
|
t.Errorf("envelope.ok must be true, got %q", got)
|
|
}
|
|
for _, want := range []string{`"project_link_path"`, projectlink.DirName} {
|
|
if !strings.Contains(got, want) {
|
|
t.Errorf("missing %q in output:\n%s", want, got)
|
|
}
|
|
}
|
|
}
|