2f8681b48e
Roadmap items 3-5 (session) and 3-6/7/8 (kb manage).
cli/cmd/session/ (new package; sessioncmd to avoid shadowing stdlib):
- session list: paginated table (ID/TITLE/UPDATED). --page / --page-size
with 1..1000 validation. _meta.has_more from page*size < total.
- session view <id>: prints metadata; non-empty fields only. Server
timestamps arrive as strings; parsed best-effort as RFC3339.
- session delete <id>: high-risk-write; exit-10 confirmation in non-
TTY/--json paths; --dry-run emits envelope.risk + dry_run:true.
cli/cmd/kb (extended):
- kb edit <id> [--name N] [--description D]: at least one flag required;
*string options so unset fields stay unset in the PUT body. SDK
UpdateKnowledgeBaseRequest has no embedding_model field, so the
roadmap's --embedding-model dropped.
- kb pin <id> / kb unpin <id>: direct parity with gh issue pin /
gh issue unpin (verified against gh manual). Idempotent: GetKnowledgeBase
reads IsPinned, TogglePinKnowledgeBase fires only on state change.
SDK KnowledgeBase struct gained the IsPinned field (server already
returned it; SDK just hadn't modeled it — non-breaking additive).
- kb empty <id>: high-risk-write; exit-10 confirmation;
--dry-run. Returns deleted_count from the async clear response.
weknora-specific operation; no mainstream parallel.
Golden envelopes for kb_list and kb_view updated to include the new
is_pinned field — strict-additive change.
Cleanups surfaced by the post-commit reviewer round:
- ConfirmPrompter promoted to cli/internal/testutil/ (4-copy threshold
reached: context/remove, kb/delete, kb/empty, session/delete).
kb/delete_test.go's pre-existing local copy left untouched per the
upstream-respect convention.
- kb pin/unpin idempotent no-op path no longer emits a write-class
envelope. Added _meta.warnings "already {un}pinned — no server
call made" and dropped the risk classification on the no-op branch.
- doc list --page-size was unbounded while session list enforces
1..1000. Same validation added to doc list.
18 + 18 unit tests; e2e exit codes verified.
Roadmap: 3-5, 3-6, 3-7, 3-8.
109 lines
3.4 KiB
Go
109 lines
3.4 KiB
Go
package kb
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
// fakeEditSvc captures the (id, request) pair handed to UpdateKnowledgeBase.
|
|
type fakeEditSvc struct {
|
|
gotID string
|
|
gotReq *sdk.UpdateKnowledgeBaseRequest
|
|
resp *sdk.KnowledgeBase
|
|
err error
|
|
}
|
|
|
|
func (f *fakeEditSvc) UpdateKnowledgeBase(_ context.Context, id string, req *sdk.UpdateKnowledgeBaseRequest) (*sdk.KnowledgeBase, error) {
|
|
f.gotID = id
|
|
f.gotReq = req
|
|
return f.resp, f.err
|
|
}
|
|
|
|
func TestEdit_RequiresAtLeastOneFlag(t *testing.T) {
|
|
_, _ = iostreams.SetForTest(t)
|
|
svc := &fakeEditSvc{}
|
|
err := runEdit(context.Background(), &EditOptions{}, svc, "kb_abc")
|
|
require.Error(t, err)
|
|
var typed *cmdutil.Error
|
|
require.ErrorAs(t, err, &typed)
|
|
assert.Equal(t, cmdutil.CodeInputMissingFlag, typed.Code)
|
|
assert.Contains(t, typed.Hint, "--name")
|
|
assert.Contains(t, typed.Hint, "--description")
|
|
}
|
|
|
|
func TestEdit_OnlyName(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeEditSvc{resp: &sdk.KnowledgeBase{ID: "kb_abc", Name: "new"}}
|
|
opts := &EditOptions{}
|
|
opts.Name = stringPtr("new")
|
|
require.NoError(t, runEdit(context.Background(), opts, svc, "kb_abc"))
|
|
|
|
assert.Equal(t, "kb_abc", svc.gotID)
|
|
require.NotNil(t, svc.gotReq)
|
|
assert.Equal(t, "new", svc.gotReq.Name)
|
|
// Description must be empty string (not "<nil>"), so server doesn't
|
|
// confuse "unset" with "set-to-empty". Actually the SDK ships an empty
|
|
// string either way — we just verify we didn't accidentally serialize a
|
|
// description override.
|
|
assert.Equal(t, "", svc.gotReq.Description)
|
|
assert.Contains(t, out.String(), "kb_abc")
|
|
}
|
|
|
|
func TestEdit_OnlyDescription(t *testing.T) {
|
|
_, _ = iostreams.SetForTest(t)
|
|
svc := &fakeEditSvc{resp: &sdk.KnowledgeBase{ID: "kb_abc"}}
|
|
opts := &EditOptions{}
|
|
opts.Description = stringPtr("new desc")
|
|
require.NoError(t, runEdit(context.Background(), opts, svc, "kb_abc"))
|
|
|
|
require.NotNil(t, svc.gotReq)
|
|
assert.Equal(t, "new desc", svc.gotReq.Description)
|
|
assert.Equal(t, "", svc.gotReq.Name)
|
|
}
|
|
|
|
func TestEdit_BothFlags(t *testing.T) {
|
|
_, _ = iostreams.SetForTest(t)
|
|
svc := &fakeEditSvc{resp: &sdk.KnowledgeBase{ID: "kb_abc"}}
|
|
opts := &EditOptions{}
|
|
opts.Name = stringPtr("renamed")
|
|
opts.Description = stringPtr("new desc")
|
|
require.NoError(t, runEdit(context.Background(), opts, svc, "kb_abc"))
|
|
assert.Equal(t, "renamed", svc.gotReq.Name)
|
|
assert.Equal(t, "new desc", svc.gotReq.Description)
|
|
}
|
|
|
|
func TestEdit_DryRun_JSON(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
opts := &EditOptions{DryRun: true, JSONOut: true}
|
|
opts.Name = stringPtr("preview")
|
|
require.NoError(t, runEdit(context.Background(), opts, nil, "kb_abc"))
|
|
|
|
body := out.String()
|
|
assert.True(t, strings.HasPrefix(body, `{"ok":true`))
|
|
assert.Contains(t, body, `"dry_run":true`)
|
|
assert.Contains(t, body, `"write"`)
|
|
}
|
|
|
|
func TestEdit_NotFound(t *testing.T) {
|
|
_, _ = iostreams.SetForTest(t)
|
|
svc := &fakeEditSvc{err: errors.New("HTTP error 404: not found")}
|
|
opts := &EditOptions{}
|
|
opts.Name = stringPtr("x")
|
|
err := runEdit(context.Background(), opts, svc, "kb_missing")
|
|
require.Error(t, err)
|
|
var typed *cmdutil.Error
|
|
require.ErrorAs(t, err, &typed)
|
|
assert.Equal(t, cmdutil.CodeResourceNotFound, typed.Code)
|
|
}
|
|
|
|
func stringPtr(s string) *string { return &s }
|