2f8681b48e
Roadmap items 3-5 (session) and 3-6/7/8 (kb manage).
cli/cmd/session/ (new package; sessioncmd to avoid shadowing stdlib):
- session list: paginated table (ID/TITLE/UPDATED). --page / --page-size
with 1..1000 validation. _meta.has_more from page*size < total.
- session view <id>: prints metadata; non-empty fields only. Server
timestamps arrive as strings; parsed best-effort as RFC3339.
- session delete <id>: high-risk-write; exit-10 confirmation in non-
TTY/--json paths; --dry-run emits envelope.risk + dry_run:true.
cli/cmd/kb (extended):
- kb edit <id> [--name N] [--description D]: at least one flag required;
*string options so unset fields stay unset in the PUT body. SDK
UpdateKnowledgeBaseRequest has no embedding_model field, so the
roadmap's --embedding-model dropped.
- kb pin <id> / kb unpin <id>: direct parity with gh issue pin /
gh issue unpin (verified against gh manual). Idempotent: GetKnowledgeBase
reads IsPinned, TogglePinKnowledgeBase fires only on state change.
SDK KnowledgeBase struct gained the IsPinned field (server already
returned it; SDK just hadn't modeled it — non-breaking additive).
- kb empty <id>: high-risk-write; exit-10 confirmation;
--dry-run. Returns deleted_count from the async clear response.
weknora-specific operation; no mainstream parallel.
Golden envelopes for kb_list and kb_view updated to include the new
is_pinned field — strict-additive change.
Cleanups surfaced by the post-commit reviewer round:
- ConfirmPrompter promoted to cli/internal/testutil/ (4-copy threshold
reached: context/remove, kb/delete, kb/empty, session/delete).
kb/delete_test.go's pre-existing local copy left untouched per the
upstream-respect convention.
- kb pin/unpin idempotent no-op path no longer emits a write-class
envelope. Added _meta.warnings "already {un}pinned — no server
call made" and dropped the risk classification on the no-op branch.
- doc list --page-size was unbounded while session list enforces
1..1000. Same validation added to doc list.
18 + 18 unit tests; e2e exit codes verified.
Roadmap: 3-5, 3-6, 3-7, 3-8.
100 lines
3.3 KiB
Go
100 lines
3.3 KiB
Go
package kb
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/agent"
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/format"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
// EditOptions captures `weknora kb edit` flags. Name/Description are *string
|
|
// so we can distinguish "unset" from "set to empty". An unset field is
|
|
// omitted from the SDK request — only fields the user passed are sent. The
|
|
// server PUT semantics are "replace everything in the request"; if we
|
|
// always sent both, an `--name` invocation would silently clear the
|
|
// description.
|
|
type EditOptions struct {
|
|
Name *string
|
|
Description *string
|
|
JSONOut bool
|
|
DryRun bool
|
|
}
|
|
|
|
// EditService is the narrow SDK surface this command depends on.
|
|
type EditService interface {
|
|
UpdateKnowledgeBase(ctx context.Context, id string, req *sdk.UpdateKnowledgeBaseRequest) (*sdk.KnowledgeBase, error)
|
|
}
|
|
|
|
// NewCmdEdit builds `weknora kb edit <id>`. Mirrors `gh repo edit`. At
|
|
// least one of --name / --description must be provided.
|
|
func NewCmdEdit(f *cmdutil.Factory) *cobra.Command {
|
|
opts := &EditOptions{}
|
|
var name, desc string
|
|
cmd := &cobra.Command{
|
|
Use: "edit <id>",
|
|
Short: "Edit a knowledge base's name or description",
|
|
Args: cobra.ExactArgs(1),
|
|
RunE: func(c *cobra.Command, args []string) error {
|
|
if c.Flag("name").Changed {
|
|
opts.Name = &name
|
|
}
|
|
if c.Flag("description").Changed {
|
|
opts.Description = &desc
|
|
}
|
|
opts.DryRun = cmdutil.IsDryRun(c)
|
|
if opts.DryRun {
|
|
return runEdit(c.Context(), opts, nil, args[0])
|
|
}
|
|
cli, err := f.Client()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return runEdit(c.Context(), opts, cli, args[0])
|
|
},
|
|
}
|
|
cmd.Flags().StringVar(&name, "name", "", "New name (omit to leave unchanged)")
|
|
cmd.Flags().StringVar(&desc, "description", "", "New description (omit to leave unchanged)")
|
|
cmd.Flags().BoolVar(&opts.JSONOut, "json", false, "Output JSON envelope")
|
|
agent.SetAgentHelp(cmd, "Edits a knowledge base. At least one of --name/--description is required. Fields not passed are preserved server-side. Returns the updated KnowledgeBase.")
|
|
return cmd
|
|
}
|
|
|
|
func runEdit(ctx context.Context, opts *EditOptions, svc EditService, id string) error {
|
|
if opts.Name == nil && opts.Description == nil {
|
|
return &cmdutil.Error{
|
|
Code: cmdutil.CodeInputMissingFlag,
|
|
Message: "kb edit requires at least one of --name or --description",
|
|
Hint: "pass --name <name> and/or --description <desc>",
|
|
}
|
|
}
|
|
|
|
req := &sdk.UpdateKnowledgeBaseRequest{}
|
|
if opts.Name != nil {
|
|
req.Name = *opts.Name
|
|
}
|
|
if opts.Description != nil {
|
|
req.Description = *opts.Description
|
|
}
|
|
|
|
risk := &format.Risk{Level: format.RiskWrite, Action: fmt.Sprintf("edit knowledge base %s", id)}
|
|
if opts.DryRun {
|
|
return cmdutil.EmitDryRun(opts.JSONOut, req, &format.Meta{KBID: id}, risk)
|
|
}
|
|
|
|
updated, err := svc.UpdateKnowledgeBase(ctx, id, req)
|
|
if err != nil {
|
|
return cmdutil.Wrapf(cmdutil.ClassifyHTTPError(err), err, "edit knowledge base %s", id)
|
|
}
|
|
if opts.JSONOut {
|
|
return format.WriteEnvelope(iostreams.IO.Out, format.SuccessWithRisk(updated, &format.Meta{KBID: id}, risk))
|
|
}
|
|
fmt.Fprintf(iostreams.IO.Out, "✓ Updated knowledge base %s\n", id)
|
|
return nil
|
|
}
|