f2e8e3f56c
Survey of 10 mainstream CLIs (gh, lark, stripe, vercel, supabase, aws, azure, gcloud, openai/codex, github-copilot-cli) showed env-gated per-command --help blurbs are a Stripe-only pattern; gh uses env detect for telemetry only, and lark relies on installed agent Skills + MCP. Our cmd/mcp/serve already covers the dominant 2025/26 path, so internal/aiclient/ (136 LOC + 38 callsites) is net maintenance burden without precedent. - Drop internal/aiclient/ entirely (annotations + detect + tests) - Remove 38 SetAgentHelp callsites + agentAwareHelpFunc / SetHelpFunc wiring in cmd/root.go - Migrate 4 command-level rules to standard Long help (visible to all, not env-gated): doc upload mode mutex, kb edit at-least-one, kb pin idempotent, search chunks channel mutex - Rewrite AGENTS.md as a developer guide (gh-style 6 H2 / 167 lines): audience preamble + Build / Architecture / Command Structure / Testing / Code Style / Error Handling. Drops sections absent in surveyed projects (Commit & PR Conventions, Who Uses This CLI) - Clean 14 internal doc refs (ADR-N, spec §X, v0.X) in source comments and docs that pointed at docs/superpowers/ — that directory is local-only / uncommitted, so refs are dead for outside readers - Drop forward-looking "once v0.2 ships" from README
130 lines
4.1 KiB
Go
130 lines
4.1 KiB
Go
// Package secrets stores and retrieves credentials. Production wires
|
|
// KeyringStore (OS keychain, primary) with FileStore (0600 plaintext under
|
|
// $XDG_CONFIG_HOME/weknora/secrets/, used as a fallback when no keyring
|
|
// backend is available).
|
|
//
|
|
// Namespace convention: "weknora:<context>:<key>" where key is "access",
|
|
// "refresh", or "api_key".
|
|
package secrets
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/xdg"
|
|
)
|
|
|
|
// ErrNotFound is returned when the requested secret does not exist.
|
|
var ErrNotFound = errors.New("secret: not found")
|
|
|
|
// Store is the abstraction CLI commands depend on; tests inject in-memory impls.
|
|
//
|
|
// Ref returns a stable URI (e.g. file://<context>/<key> or
|
|
// keychain://weknora/<context>/<key>) describing where a saved secret lives.
|
|
// Backends own their scheme so commands never need to type-assert the
|
|
// concrete implementation.
|
|
type Store interface {
|
|
Get(context, key string) (string, error)
|
|
Set(context, key, value string) error
|
|
Delete(context, key string) error
|
|
Ref(context, key string) string
|
|
}
|
|
|
|
// FileStore writes 0600 plain-text files under $XDG_CONFIG_HOME/weknora/secrets/<context>.
|
|
// It is the headless / CI default and the keychain fallback.
|
|
type FileStore struct {
|
|
root string
|
|
}
|
|
|
|
// NewFileStore returns a FileStore rooted at $XDG_CONFIG_HOME/weknora/secrets
|
|
// (or ~/.config/weknora/secrets if XDG_CONFIG_HOME is unset). Same convention
|
|
// as config.Path - see that file for the rationale (CLI convention).
|
|
func NewFileStore() (*FileStore, error) {
|
|
root, err := defaultRoot()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return &FileStore{root: root}, nil
|
|
}
|
|
|
|
func defaultRoot() (string, error) {
|
|
return xdg.Path("XDG_CONFIG_HOME", ".config", "secrets")
|
|
}
|
|
|
|
func (f *FileStore) path(context, key string) string {
|
|
return filepath.Join(f.root, context, key)
|
|
}
|
|
|
|
func (f *FileStore) Get(context, key string) (string, error) {
|
|
data, err := os.ReadFile(f.path(context, key))
|
|
if errors.Is(err, os.ErrNotExist) {
|
|
return "", ErrNotFound
|
|
}
|
|
if err != nil {
|
|
return "", fmt.Errorf("read secret: %w", err)
|
|
}
|
|
return string(data), nil
|
|
}
|
|
|
|
func (f *FileStore) Set(context, key, value string) error {
|
|
dir := filepath.Join(f.root, context)
|
|
if err := os.MkdirAll(dir, 0o700); err != nil {
|
|
return fmt.Errorf("mkdir secrets dir: %w", err)
|
|
}
|
|
if err := os.WriteFile(f.path(context, key), []byte(value), 0o600); err != nil {
|
|
return fmt.Errorf("write secret: %w", err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (f *FileStore) Delete(context, key string) error {
|
|
err := os.Remove(f.path(context, key))
|
|
if errors.Is(err, os.ErrNotExist) {
|
|
return nil
|
|
}
|
|
return err
|
|
}
|
|
|
|
// Ref returns the file:// URI under which a secret would be stored. Path
|
|
// component is forward-slash-normalized per RFC 8089 (file:///path on Unix,
|
|
// file:///C:/... on Windows) - the wire format must not depend on platform
|
|
// path separator since this string is persisted to config.yaml and may be
|
|
// consumed by tooling on a different OS.
|
|
func (f *FileStore) Ref(context, key string) string {
|
|
p := filepath.ToSlash(f.path(context, key))
|
|
if !strings.HasPrefix(p, "/") {
|
|
// Windows absolute path "C:/..." needs a leading slash to form a
|
|
// proper file:/// URI ("file:///C:/...").
|
|
p = "/" + p
|
|
}
|
|
return "file://" + p
|
|
}
|
|
|
|
// MemStore is an in-memory implementation of Store used by tests across
|
|
// packages. It is intentionally exported (not _test.go-only) so that
|
|
// downstream packages can compose it without copying the same 20 lines.
|
|
type MemStore struct{ m map[string]string }
|
|
|
|
// NewMemStore returns an empty in-memory secrets store.
|
|
func NewMemStore() *MemStore { return &MemStore{m: map[string]string{}} }
|
|
|
|
func (m *MemStore) k(c, key string) string { return c + ":" + key }
|
|
|
|
func (m *MemStore) Get(c, key string) (string, error) {
|
|
v, ok := m.m[m.k(c, key)]
|
|
if !ok {
|
|
return "", ErrNotFound
|
|
}
|
|
return v, nil
|
|
}
|
|
|
|
func (m *MemStore) Set(c, key, value string) error { m.m[m.k(c, key)] = value; return nil }
|
|
|
|
func (m *MemStore) Delete(c, key string) error { delete(m.m, m.k(c, key)); return nil }
|
|
|
|
// Ref returns a mem:// URI; meaningful only inside tests.
|
|
func (m *MemStore) Ref(c, key string) string { return "mem://" + c + "/" + key }
|