4a5449233d
Seven bugs surfaced via two audit rounds — parallel reviewer agents
plus a real-server end-to-end demo. Each fix arrives with a
regression test.
1. doc upload --recursive --json corrupted the envelope stream.
Per-file FAIL/OK plain lines printed unconditionally to stdout,
then a Success envelope, then on partial failure a typed error
that the root handler turned into a SECOND Failure envelope —
three outputs where one was expected. Fix: gate the plain lines
behind !opts.JSONOut, and add cmdutil.Error.Silent so the JSON-
path partial-failure preserves its typed exit code without
triggering PrintErrorEnvelope's default Failure-envelope write.
2. auth refresh / AuthRetryTransport misclassified HTTP failures as
network.error. RefreshAndPersist wrapped every refresher error
with CodeNetworkError, but the SDK emits "HTTP error 401: ..."
for a rejected refresh token — which should surface as
auth.token_expired. Switched to WrapHTTP for proper status-
derived classification. Affects both `auth refresh` and the
transport's refresh closure.
3. doc download accepted ".." as a server-suggested filename. The
rejection list covered "" / "." / filepath.Separator but not
bare ".." — filepath.Base("..") is "..", which slipped through
to os.Create and produced a confusing local.file_io wrap. Added
to the rejection set.
4. search chunks / docs / kb / sessions had no lower bound on
--limit. `-L 0` / `-L -1` was forwarded to the server with
undefined behavior. Added a 1..1000 bound at the RunE boundary
across all four (matching doc list / session list page-size
bounds). Internal callers in tests can still pass Limit==0 for
the "no client-side cap" runChunks path — the bound only applies
at the user-input layer.
5. cli/AGENTS.md ADR-3 verb-canon summary listed only v0.2 verbs as
"gh-canonical" and missed v0.3 additions (edit, pin, unpin,
download — all gh-canonical) plus locally-introduced ones
(empty, refresh, add, remove, link). Rewritten as an explicit
gh-canonical / locally-introduced split.
6. kb pin returned 404. Server registers /knowledge-bases/{id}/pin
as PUT (router.go:292); SDK was using POST. gin's router silently
404s on method-mismatch (treats it as path-not-found, not 405),
so the CLI classified the response as resource.not_found and
masked the real failure mode. Switched the SDK to http.MethodPut.
The asymmetry that hid this past round 1: kb unpin on a freshly-
created KB hits the no-op branch in cmd/kb/pin.go that skips the
SDK call entirely, so unpin "worked" without ever exercising the
broken path. Only the real-server demo, where kb pin actually
fires, surfaced it.
7. kb edit clobbered current Name when only --description was
passed. EditOptions used *string to distinguish "unset" from
"set to empty", but sdk.UpdateKnowledgeBaseRequest declares both
fields as plain string (no omitempty), so the JSON body always
carried `"name": ""`. Server requires Name → 400. Fix: runEdit
does fetch-then-update — GetKnowledgeBase first, build the PUT
body with current values, then overlay user-set fields. Same
TOCTOU window as kb pin / unpin.
Audit-flagged items intentionally NOT changed:
- kb pin / unpin check-then-toggle TOCTOU: documented; the clean
fix would be a server-side setter and belongs in a separate API
change.
- AuthRetryTransport singleflight test gap for one concurrency
scenario; v0.4 polish.
- cli/README.md:50 "once v0.2 ships" and CHANGELOG.md:8
"10 top-level commands": v0.2-PR artifacts, not v0.3-introduced.
- kb edit / kb pin are v0.3-new commands, so neither bug needs a
cli/CHANGELOG.md Fixed entry — the v0.3 release ships them
working as the Added bullets advertise.
202 lines
6.8 KiB
Go
202 lines
6.8 KiB
Go
package cmdutil
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/format"
|
|
)
|
|
|
|
// ExitCode maps an error to the documented CLI exit code (spec §2.4 + ADR-3).
|
|
// - 0 success
|
|
// - 1 generic / unknown typed error — fallback for: resource.already_exists,
|
|
// resource.locked, local.* (config_corrupt / keychain_denied / file_io /
|
|
// context_not_found / kb_id_required / kb_not_found / projectlink_corrupt /
|
|
// user_aborted / upload_file_not_found), mcp.*, server.session_create_failed,
|
|
// sse.stream_aborted, and any code outside the named buckets below
|
|
// - 2 flag / argument problem (cobra parse / unknown subcommand)
|
|
// - 3 auth.*
|
|
// - 4 resource.not_found
|
|
// - 5 input.* (other than confirmation_required)
|
|
// - 6 server.rate_limited
|
|
// - 7 server.* (other than rate_limited/session_create_failed) / network.*
|
|
// - 10 input.confirmation_required — high-risk write needs explicit -y
|
|
// (see cli/AGENTS.md)
|
|
// - 130 SIGINT (handled by Go runtime, not this function)
|
|
func ExitCode(err error) int {
|
|
if err == nil {
|
|
return 0
|
|
}
|
|
var fe *FlagError
|
|
if errors.As(err, &fe) {
|
|
return 2
|
|
}
|
|
if errors.Is(err, SilentError) {
|
|
return 1
|
|
}
|
|
if matchCode(err, CodeInputConfirmationRequired) {
|
|
return 10
|
|
}
|
|
if IsAuthError(err) {
|
|
return 3
|
|
}
|
|
if IsNotFound(err) {
|
|
return 4
|
|
}
|
|
if matchPrefix(err, "input.") {
|
|
return 5
|
|
}
|
|
if matchCode(err, CodeServerRateLimited) {
|
|
return 6
|
|
}
|
|
if matchPrefix(err, "server.") || matchPrefix(err, "network.") {
|
|
return 7
|
|
}
|
|
return 1
|
|
}
|
|
|
|
// PrintError writes err to w in human-readable form. The envelope-aware
|
|
// JSON formatter is in `internal/format`; this helper is the human path used
|
|
// when no command produced its own output.
|
|
//
|
|
// Typed *Error values surface their Hint as a second line so users see the
|
|
// actionable next-step (matches envelope.error.hint visibility in --json).
|
|
// Falls through to defaultHint when caller didn't set one.
|
|
func PrintError(w io.Writer, err error) {
|
|
if err == nil || errors.Is(err, SilentError) {
|
|
return
|
|
}
|
|
fmt.Fprintln(w, err.Error())
|
|
var typed *Error
|
|
if errors.As(err, &typed) {
|
|
hint := typed.Hint
|
|
if hint == "" {
|
|
hint = defaultHint(typed.Code)
|
|
}
|
|
if hint != "" {
|
|
fmt.Fprintf(w, "hint: %s\n", hint)
|
|
}
|
|
}
|
|
}
|
|
|
|
// PrintErrorEnvelope writes err as a JSON envelope on w. Used in agent mode /
|
|
// --json / --format=json output so failures stay machine-parseable. When the
|
|
// error carries an OperationRisk (destructive write paths), it's surfaced as
|
|
// the envelope-level Risk field so agents can decide whether to surface the
|
|
// failure differently to the user.
|
|
func PrintErrorEnvelope(w io.Writer, err error) {
|
|
if err == nil || errors.Is(err, SilentError) {
|
|
return
|
|
}
|
|
var typed *Error
|
|
if errors.As(err, &typed) && typed.Silent {
|
|
return
|
|
}
|
|
env := format.Failure(ToErrorBody(err))
|
|
if r := operationRiskOf(err); r != nil {
|
|
env.Risk = &format.Risk{Level: format.RiskLevel(r.Level), Action: r.Action}
|
|
}
|
|
_ = format.WriteEnvelope(w, env)
|
|
}
|
|
|
|
// operationRiskOf extracts an OperationRisk from a typed *Error chain, or nil.
|
|
func operationRiskOf(err error) *OperationRisk {
|
|
var typed *Error
|
|
if errors.As(err, &typed) {
|
|
return typed.OperationRisk
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// ToErrorBody projects err into the canonical envelope ErrorBody. Exposed so
|
|
// other emit paths (planned: MCP) reuse the same projection rather than
|
|
// reimplementing the typed-error → wire-shape mapping.
|
|
func ToErrorBody(err error) *format.ErrorBody {
|
|
if err == nil {
|
|
return nil
|
|
}
|
|
body := &format.ErrorBody{Message: err.Error()}
|
|
var typed *Error
|
|
if errors.As(err, &typed) {
|
|
body.Code = string(typed.Code)
|
|
body.Message = typed.Message
|
|
body.Hint = typed.Hint
|
|
if body.Hint == "" {
|
|
body.Hint = defaultHint(typed.Code)
|
|
}
|
|
body.Retryable = typed.Retryable
|
|
// Surface the wrapped cause so agents see the actual server / SDK
|
|
// error string, not just the wrap message ("hybrid search"). The
|
|
// human's printed line and the JSON envelope both end with the
|
|
// underlying problem.
|
|
if typed.Cause != nil {
|
|
body.Message = typed.Message + ": " + typed.Cause.Error()
|
|
}
|
|
return body
|
|
}
|
|
var fe *FlagError
|
|
if errors.As(err, &fe) {
|
|
body.Code = string(CodeInputInvalidArgument)
|
|
return body
|
|
}
|
|
// Unclassified error; consumers see the message but no stable code.
|
|
body.Code = string(CodeServerError)
|
|
return body
|
|
}
|
|
|
|
// defaultHint returns a canonical actionable hint for known error codes when
|
|
// the call site didn't set one. Spec §1.4 zero-config matrix mandates
|
|
// `auth.unauthenticated` envelopes carry "run weknora auth login" — this
|
|
// fallback covers the broad surface (auth status / kb list / kb get / search)
|
|
// without per-command hint plumbing.
|
|
//
|
|
// Empty string for codes without a stable canonical hint.
|
|
func defaultHint(code ErrorCode) string {
|
|
switch code {
|
|
case CodeAuthUnauthenticated, CodeAuthBadCredential:
|
|
return "run `weknora auth login`"
|
|
case CodeAuthTokenExpired:
|
|
return "your session expired; run `weknora auth login` to re-authenticate"
|
|
case CodeAuthForbidden:
|
|
return "active context lacks permission for this resource"
|
|
case CodeAuthCrossTenantBlocked, CodeAuthTenantMismatch:
|
|
return "verify tenant context with `weknora auth status`"
|
|
case CodeNetworkError:
|
|
return "check base URL reachability with `weknora doctor`"
|
|
case CodeServerIncompatibleVersion:
|
|
return "run `weknora doctor` to see version skew details"
|
|
case CodeServerRateLimited:
|
|
return "rate-limited; retry after a few seconds"
|
|
case CodeServerTimeout:
|
|
return "request timed out; retry, or run `weknora doctor` to check connectivity"
|
|
case CodeResourceNotFound:
|
|
return "verify the resource ID; list available with `weknora kb list`"
|
|
case CodeInputInvalidArgument, CodeInputMissingFlag:
|
|
return "see `weknora <command> --help` for valid usage"
|
|
case CodeInputConfirmationRequired:
|
|
return "high-risk write — re-run with -y/--yes after the user explicitly approves"
|
|
case CodeLocalKeychainDenied:
|
|
return "verify keyring access; falls back to file storage"
|
|
case CodeLocalConfigCorrupt:
|
|
return "remove ~/.config/weknora/config.yaml and re-run `weknora auth login`"
|
|
case CodeLocalFileIO:
|
|
return "check file permissions under $XDG_CONFIG_HOME/weknora/"
|
|
case CodeKBIDRequired:
|
|
return "run `weknora link` to bind this directory to a knowledge base, or pass --kb"
|
|
case CodeKBNotFound:
|
|
return "list available with `weknora kb list`"
|
|
case CodeProjectLinkCorrupt:
|
|
return "remove .weknora/project.yaml and run `weknora link` again"
|
|
case CodeUserAborted:
|
|
return "no action taken; pass -y/--yes to skip the confirmation prompt"
|
|
case CodeUploadFileNotFound:
|
|
return "verify the path is correct and readable"
|
|
case CodeSSEStreamAborted:
|
|
return "the streaming answer was cut off mid-flight; retry, or pass --no-stream to buffer the full response"
|
|
case CodeSessionCreateFailed:
|
|
return "could not create a chat session; pass --session-id to reuse an existing session"
|
|
}
|
|
return ""
|
|
}
|