nullkey
34bb0b5096
Batch-write surface and pagination consistency:
* weknora doc delete <doc-id> [<doc-id>...] — positional multi-id, default
keep-going on failure. Single -y confirms entire batch.
* weknora session delete <session-id> [<session-id>...] — same shape.
* weknora chunk delete <chunk-id> [<chunk-id>...] --doc <doc-id> — multi-id
with shared --doc parent.
* Multi-id partial-failure rolls up as operation.failed (exit 1), not
server.error (exit 7) — failures are operation outcomes, not transient
transport issues, and the retry-with-backoff hint for server.* would
mislead callers.
* weknora api <path> --paginate — auto-walks offset pagination and merges
pages into a single {data, total} JSON response.
* Paginate truncation fix across 6 list/follower call sites.
* All doc / search / chunk / session / kb list commands migrated to
FormatOptions API.
Multi-id RunE only emits the {ok, failed} envelope when the operation
actually ran — pre-flight failures (e.g. confirmation_required) leave
stdout empty per the wire contract.
doc upload's missing-positional-or-flag check is wrapped as FlagError so
the exit code (2) matches the convention used by other commands that
require a positional argument directly.
119 lines
4.4 KiB
Go
119 lines
4.4 KiB
Go
package search
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
type fakeKBSearchSvc struct {
|
|
items []sdk.KnowledgeBase
|
|
err error
|
|
}
|
|
|
|
func (f *fakeKBSearchSvc) ListKnowledgeBases(_ context.Context) ([]sdk.KnowledgeBase, error) {
|
|
return f.items, f.err
|
|
}
|
|
|
|
func TestKBSearch_Substring(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeKBSearchSvc{items: []sdk.KnowledgeBase{
|
|
{ID: "kb1", Name: "Marketing Q3", KnowledgeCount: 10},
|
|
{ID: "kb2", Name: "Engineering Docs", KnowledgeCount: 50},
|
|
{ID: "kb3", Name: "Marketing Q4 Plan", KnowledgeCount: 5},
|
|
}}
|
|
require.NoError(t, runKBSearch(context.Background(), &KBSearchOptions{Query: "marketing", Limit: 20}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, svc))
|
|
got := out.String()
|
|
assert.Contains(t, got, "kb1")
|
|
assert.Contains(t, got, "kb3")
|
|
assert.NotContains(t, got, "Engineering")
|
|
}
|
|
|
|
func TestKBSearch_CaseInsensitive(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeKBSearchSvc{items: []sdk.KnowledgeBase{
|
|
{ID: "kb1", Name: "ENGINEERING"},
|
|
}}
|
|
require.NoError(t, runKBSearch(context.Background(), &KBSearchOptions{Query: "engineering", Limit: 20}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, svc))
|
|
assert.Contains(t, out.String(), "kb1")
|
|
}
|
|
|
|
func TestKBSearch_MatchesDescription(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeKBSearchSvc{items: []sdk.KnowledgeBase{
|
|
{ID: "kb1", Name: "Engineering", Description: "all marketing docs are here"},
|
|
}}
|
|
require.NoError(t, runKBSearch(context.Background(), &KBSearchOptions{Query: "marketing", Limit: 20}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, svc))
|
|
assert.Contains(t, out.String(), "kb1")
|
|
}
|
|
|
|
func TestKBSearch_SortByNameLength(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeKBSearchSvc{items: []sdk.KnowledgeBase{
|
|
{ID: "kb_long", Name: "very long name marketing"},
|
|
{ID: "kb_short", Name: "marketing"},
|
|
{ID: "kb_mid", Name: "marketing 2024"},
|
|
}}
|
|
require.NoError(t, runKBSearch(context.Background(), &KBSearchOptions{Query: "marketing", Limit: 20}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, svc))
|
|
got := out.String()
|
|
// Order: shortest name first.
|
|
iShort := strings.Index(got, "kb_short")
|
|
iMid := strings.Index(got, "kb_mid")
|
|
iLong := strings.Index(got, "kb_long")
|
|
assert.Less(t, iShort, iMid)
|
|
assert.Less(t, iMid, iLong)
|
|
}
|
|
|
|
func TestKBSearch_LimitHardCap(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeKBSearchSvc{items: []sdk.KnowledgeBase{
|
|
{ID: "a", Name: "match-a"}, {ID: "b", Name: "match-b"},
|
|
{ID: "c", Name: "match-c"}, {ID: "d", Name: "match-d"},
|
|
}}
|
|
require.NoError(t, runKBSearch(context.Background(), &KBSearchOptions{Query: "match", Limit: 2}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, svc))
|
|
got := out.String()
|
|
count := 0
|
|
for _, id := range []string{"a", "b", "c", "d"} {
|
|
if strings.Contains(got, "match-"+id) {
|
|
count++
|
|
}
|
|
}
|
|
assert.Equal(t, 2, count)
|
|
}
|
|
|
|
func TestKBSearch_NoMatches(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeKBSearchSvc{items: []sdk.KnowledgeBase{{Name: "foo"}}}
|
|
require.NoError(t, runKBSearch(context.Background(), &KBSearchOptions{Query: "bar", Limit: 20}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, svc))
|
|
assert.Contains(t, out.String(), "(no matches)")
|
|
}
|
|
|
|
func TestKBSearch_JSON(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeKBSearchSvc{items: []sdk.KnowledgeBase{{ID: "kb1", Name: "marketing"}}}
|
|
require.NoError(t, runKBSearch(context.Background(), &KBSearchOptions{Query: "marketing", Limit: 20}, &cmdutil.FormatOptions{Mode: cmdutil.FormatJSON}, svc))
|
|
|
|
got := out.String()
|
|
assert.True(t, strings.HasPrefix(strings.TrimSpace(got), "["), "expected bare JSON array, got: %q", got)
|
|
assert.Contains(t, got, `"id":"kb1"`)
|
|
assert.NotContains(t, got, `"ok":`)
|
|
}
|
|
|
|
func TestKBSearch_NetworkError(t *testing.T) {
|
|
_, _ = iostreams.SetForTest(t)
|
|
svc := &fakeKBSearchSvc{err: errors.New("HTTP error 401: unauthenticated")}
|
|
err := runKBSearch(context.Background(), &KBSearchOptions{Query: "x", Limit: 20}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, svc)
|
|
require.Error(t, err)
|
|
var typed *cmdutil.Error
|
|
require.ErrorAs(t, err, &typed)
|
|
assert.Equal(t, cmdutil.CodeAuthUnauthenticated, typed.Code)
|
|
}
|