2f8681b48e
Roadmap items 3-5 (session) and 3-6/7/8 (kb manage).
cli/cmd/session/ (new package; sessioncmd to avoid shadowing stdlib):
- session list: paginated table (ID/TITLE/UPDATED). --page / --page-size
with 1..1000 validation. _meta.has_more from page*size < total.
- session view <id>: prints metadata; non-empty fields only. Server
timestamps arrive as strings; parsed best-effort as RFC3339.
- session delete <id>: high-risk-write; exit-10 confirmation in non-
TTY/--json paths; --dry-run emits envelope.risk + dry_run:true.
cli/cmd/kb (extended):
- kb edit <id> [--name N] [--description D]: at least one flag required;
*string options so unset fields stay unset in the PUT body. SDK
UpdateKnowledgeBaseRequest has no embedding_model field, so the
roadmap's --embedding-model dropped.
- kb pin <id> / kb unpin <id>: direct parity with gh issue pin /
gh issue unpin (verified against gh manual). Idempotent: GetKnowledgeBase
reads IsPinned, TogglePinKnowledgeBase fires only on state change.
SDK KnowledgeBase struct gained the IsPinned field (server already
returned it; SDK just hadn't modeled it — non-breaking additive).
- kb empty <id>: high-risk-write; exit-10 confirmation;
--dry-run. Returns deleted_count from the async clear response.
weknora-specific operation; no mainstream parallel.
Golden envelopes for kb_list and kb_view updated to include the new
is_pinned field — strict-additive change.
Cleanups surfaced by the post-commit reviewer round:
- ConfirmPrompter promoted to cli/internal/testutil/ (4-copy threshold
reached: context/remove, kb/delete, kb/empty, session/delete).
kb/delete_test.go's pre-existing local copy left untouched per the
upstream-respect convention.
- kb pin/unpin idempotent no-op path no longer emits a write-class
envelope. Added _meta.warnings "already {un}pinned — no server
call made" and dropped the risk classification on the no-op branch.
- doc list --page-size was unbounded while session list enforces
1..1000. Same validation added to doc list.
18 + 18 unit tests; e2e exit codes verified.
Roadmap: 3-5, 3-6, 3-7, 3-8.
99 lines
3.5 KiB
Go
99 lines
3.5 KiB
Go
package kb
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/agent"
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/format"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
"github.com/Tencent/WeKnora/cli/internal/prompt"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
// EmptyOptions captures `weknora kb empty` flag state.
|
|
type EmptyOptions struct {
|
|
Yes bool
|
|
JSONOut bool
|
|
DryRun bool
|
|
}
|
|
|
|
// EmptyService is the narrow SDK surface this command depends on.
|
|
type EmptyService interface {
|
|
ClearKnowledgeBaseContents(ctx context.Context, id string) (*sdk.ClearKnowledgeBaseContentsResponse, error)
|
|
}
|
|
|
|
// emptyResult is the typed payload emitted under data on success.
|
|
type emptyResult struct {
|
|
ID string `json:"id"`
|
|
DeletedCount int `json:"deleted_count"`
|
|
}
|
|
|
|
// NewCmdEmpty builds `weknora kb empty <id>`. Wipes every
|
|
// document inside the knowledge base; the KB itself is preserved. The
|
|
// server runs the delete asynchronously and reports the count of documents
|
|
// that were enqueued for removal.
|
|
func NewCmdEmpty(f *cmdutil.Factory) *cobra.Command {
|
|
opts := &EmptyOptions{}
|
|
cmd := &cobra.Command{
|
|
Use: "empty <id>",
|
|
Short: "Delete every document in a knowledge base (preserves the KB)",
|
|
Long: `Removes all documents and chunks from a knowledge base while keeping the
|
|
KB record (its name, description, and config) intact. The delete is async;
|
|
the server reports the count of items enqueued for removal.
|
|
|
|
Prompts for confirmation by default; pass -y/--yes to skip in agent / CI /
|
|
piped contexts. Without -y the CLI exits 10 (lark-cli skill protocol).`,
|
|
Example: ` weknora kb empty kb_abc # interactive confirm
|
|
weknora kb empty kb_abc -y --json # agent-friendly`,
|
|
Args: cobra.ExactArgs(1),
|
|
RunE: func(c *cobra.Command, args []string) error {
|
|
opts.Yes, _ = c.Flags().GetBool("yes")
|
|
opts.DryRun = cmdutil.IsDryRun(c)
|
|
if opts.DryRun {
|
|
return runEmpty(c.Context(), opts, nil, f.Prompter(), args[0])
|
|
}
|
|
cli, err := f.Client()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return runEmpty(c.Context(), opts, cli, f.Prompter(), args[0])
|
|
},
|
|
}
|
|
cmd.Flags().BoolVar(&opts.JSONOut, "json", false, "Output JSON envelope")
|
|
agent.SetAgentHelp(cmd, "Destructively empties a knowledge base (deletes all documents, preserves the KB record + config). ALWAYS pass -y/--yes in agent mode (non-TTY ⇒ confirm fails). Returns data: {id, deleted_count}. Async — items may still be processing server-side after the call returns.")
|
|
return cmd
|
|
}
|
|
|
|
func runEmpty(ctx context.Context, opts *EmptyOptions, svc EmptyService, p prompt.Prompter, id string) error {
|
|
risk := &format.Risk{Level: format.RiskHighRiskWrite, Action: fmt.Sprintf("empty knowledge base %s", id)}
|
|
|
|
if opts.DryRun {
|
|
return cmdutil.EmitDryRun(opts.JSONOut, emptyResult{ID: id}, &format.Meta{KBID: id}, risk)
|
|
}
|
|
|
|
if err := cmdutil.ConfirmDestructive(p, opts.Yes, opts.JSONOut, "all contents of knowledge base", id); err != nil {
|
|
return err
|
|
}
|
|
|
|
resp, err := svc.ClearKnowledgeBaseContents(ctx, id)
|
|
if err != nil {
|
|
return cmdutil.Wrapf(cmdutil.ClassifyHTTPError(err), err, "empty knowledge base %s", id)
|
|
}
|
|
deleted := 0
|
|
if resp != nil {
|
|
deleted = resp.DeletedCount
|
|
}
|
|
|
|
if opts.JSONOut {
|
|
return format.WriteEnvelope(iostreams.IO.Out, format.SuccessWithRisk(
|
|
emptyResult{ID: id, DeletedCount: deleted}, &format.Meta{KBID: id}, risk,
|
|
))
|
|
}
|
|
fmt.Fprintf(iostreams.IO.Out, "✓ Emptied knowledge base %s (%d document(s) cleared)\n", id, deleted)
|
|
return nil
|
|
}
|