2ce348d020
D1 — --format default flipped to json regardless of TTY: - v0.6: smart default (text on TTY, json on pipe). - v0.7: always json; TTY only affects indent (compact in pipe). Enum values unchanged (text | json | ndjson). - Typed FormatMode enum replaces untyped string consts. - --format / --jq promoted to persistent root flags so unknown- subcommand paths still reach the typed-envelope guard (per-command registration in v0.6 would have rejected --format on unknown commands as cobra-prose exit 2). - WEKNORA_FORMAT env var added; precedence --format > env > default. Invalid env values silently ignored. D2 — chat / session ask default to NDJSON event-stream: - New cli/internal/output/ndjson_stream.go: InitEvent struct + EmitInit / EmitSDKEvent / WriteNDJSONLine helpers. EmitInit doc encodes the must-be-first-line invariant agents key on. - chat / session ask: --format json AND --format ndjson both emit one JSON event per line (no envelope wrapping). CLI injects exactly one `init` event at stream head carrying session_id + optional kb_id / agent_id / profile. Subsequent events pass through verbatim from the SDK (passthrough discipline per spec §5.1). - --format text keeps the SSE-style live renderer. context → profile full cascade: - Command group: cli/cmd/context/ → cli/cmd/profile/ (git mv; package contextcmd → profilecmd). - Global flag --context → --profile. Factory.ContextOverride → ProfileOverride. WEKNORA_PROFILE env var honored (--profile flag > env > config.CurrentContext). When --profile or WEKNORA_PROFILE references a missing profile, the error is input.invalid_argument with hint "weknora profile list" — not the destructive local.config_corrupt path (which would have told users to delete their config file). - Binding file .weknora/project.yaml field context: → profile: (no backwards-compat alias; re-run weknora link). - profile use JSON fields current_context / previous_context → current_profile / previous_profile. - weknora link JSON field context → profile. - CodeLocalContextNotFound → CodeLocalProfileNotFound (typed code rename). - Envelope top-level profile field populated via globalProfile (set by root PersistentPreRunE from Factory.ActiveProfile). chat / session ask NDJSON init event carries the same profile. - Rationale: "context" collided with LLM context window / RAG context / Go context.Context; mainstream multi-credential CLIs (AWS / Stripe / OpenAI / Anthropic / lark) all use "profile". H2/C1' help calibration: - AgentHelp gains Warnings []string; single SetAgentHelp helper routes on WEKNORA_AGENT_HELP=1 (emits JSON blob including warnings) vs human help (appends "AI agents:" block from same source). Warnings surface as both a structured JSON field and visible help-text addendum without drift. - 9 destructive commands carry warnings: kb / doc / agent / session / chunk delete; profile remove; kb / agent edit; auth logout. - weknora doc wait dedups ids at entry; SIGINT mid-wait returns silently (root signal handler maps to exit 130) instead of being miscategorised as operation.timeout / operation.failed. A4 — docs: - cli/AGENTS.md gains four agent-facing sections: Wire contract for AI agents (stdout / stderr / NDJSON / _notice evolution / SDK contract boundary); Deliberate deviations + mainstream alignments; Pre-1.0 breaking policy; Exit-10 anti-patterns. ERROR_REFERENCE table extended. - cli/README.md adds Agent quick start under Wire contract. - cli/CHANGELOG.md v0.7 section: BREAKING entries with migration notes, Added (WEKNORA_FORMAT / WEKNORA_PROFILE / retry_command / retry_after_seconds / risk / _notice reserved infra / meta.count / meta.has_more / doc fetch / doc create / session ask / doc delete --all / NDJSON init), Changed (docs additions), Deprecated (none — pre-release one-shot breaking). Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3 / §4 / §5 / §6 / §11
206 lines
6.7 KiB
Go
206 lines
6.7 KiB
Go
package profilecmd
|
|
|
|
import (
|
|
"errors"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/config"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
"github.com/Tencent/WeKnora/cli/internal/secrets"
|
|
"github.com/Tencent/WeKnora/cli/internal/testutil"
|
|
)
|
|
|
|
// seedStore returns a MemStore pre-loaded with sentinel values for every
|
|
// secret slot a profile might reference. Tests assert deletion by checking
|
|
// `secrets.ErrNotFound` post-runRemove.
|
|
func seedStore(t *testing.T, name string, slots ...string) *secrets.MemStore {
|
|
t.Helper()
|
|
s := secrets.NewMemStore()
|
|
for _, slot := range slots {
|
|
if err := s.Set(name, slot, "sentinel-"+name+"-"+slot); err != nil {
|
|
t.Fatalf("seed %s/%s: %v", name, slot, err)
|
|
}
|
|
}
|
|
return s
|
|
}
|
|
|
|
func assertDeleted(t *testing.T, s *secrets.MemStore, name, slot string) {
|
|
t.Helper()
|
|
if _, err := s.Get(name, slot); !errors.Is(err, secrets.ErrNotFound) {
|
|
t.Errorf("expected %s/%s removed, got err=%v", name, slot, err)
|
|
}
|
|
}
|
|
|
|
func TestRemove_NonCurrent_NoPromptNeeded(t *testing.T) {
|
|
t.Setenv("XDG_CONFIG_HOME", t.TempDir())
|
|
out, _ := iostreams.SetForTest(t)
|
|
|
|
cfg := &config.Config{
|
|
CurrentContext: "production",
|
|
Contexts: map[string]config.Context{
|
|
"production": {Host: "https://prod.example.com", TokenRef: "mem://production/access"},
|
|
"staging": {Host: "https://staging.example.com", APIKeyRef: "mem://staging/api_key"},
|
|
},
|
|
}
|
|
if err := config.Save(cfg); err != nil {
|
|
t.Fatalf("Save: %v", err)
|
|
}
|
|
|
|
store := seedStore(t, "staging", "api_key")
|
|
p := &testutil.ConfirmPrompter{}
|
|
if err := runRemove(&RemoveOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, "staging", store, p); err != nil {
|
|
t.Fatalf("runRemove: %v", err)
|
|
}
|
|
if p.Asked {
|
|
t.Errorf("non-current remove must not prompt")
|
|
}
|
|
|
|
got, _ := config.Load()
|
|
if _, exists := got.Contexts["staging"]; exists {
|
|
t.Errorf("staging should have been removed; Contexts=%v", got.Contexts)
|
|
}
|
|
if got.CurrentContext != "production" {
|
|
t.Errorf("CurrentContext must be unchanged, got %q", got.CurrentContext)
|
|
}
|
|
assertDeleted(t, store, "staging", "api_key")
|
|
if !strings.Contains(out.String(), "staging") {
|
|
t.Errorf("output should mention removed profile, got %q", out.String())
|
|
}
|
|
}
|
|
|
|
func TestRemove_NotFound_WithDidYouMean(t *testing.T) {
|
|
t.Setenv("XDG_CONFIG_HOME", t.TempDir())
|
|
_, _ = iostreams.SetForTest(t)
|
|
|
|
cfg := &config.Config{Contexts: map[string]config.Context{
|
|
"production": {Host: "https://prod"},
|
|
"staging": {Host: "https://staging"},
|
|
}}
|
|
if err := config.Save(cfg); err != nil {
|
|
t.Fatalf("Save: %v", err)
|
|
}
|
|
|
|
err := runRemove(&RemoveOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, "prodution", secrets.NewMemStore(), &testutil.ConfirmPrompter{})
|
|
if err == nil {
|
|
t.Fatal("expected not-found error")
|
|
}
|
|
cm, ok := err.(*cmdutil.Error)
|
|
if !ok {
|
|
t.Fatalf("expected *cmdutil.Error, got %T", err)
|
|
}
|
|
if cm.Code != cmdutil.CodeLocalProfileNotFound {
|
|
t.Errorf("code=%q, want %q", cm.Code, cmdutil.CodeLocalProfileNotFound)
|
|
}
|
|
if !strings.Contains(cm.Hint, "production") {
|
|
t.Errorf("hint should suggest 'production', got %q", cm.Hint)
|
|
}
|
|
}
|
|
|
|
func TestRemove_Current_NonTTY_NoYes_RequiresConfirmation(t *testing.T) {
|
|
t.Setenv("XDG_CONFIG_HOME", t.TempDir())
|
|
_, _ = iostreams.SetForTest(t)
|
|
|
|
cfg := &config.Config{
|
|
CurrentContext: "production",
|
|
Contexts: map[string]config.Context{
|
|
"production": {Host: "https://prod", TokenRef: "mem://production/access"},
|
|
"staging": {Host: "https://staging"},
|
|
},
|
|
}
|
|
if err := config.Save(cfg); err != nil {
|
|
t.Fatalf("Save: %v", err)
|
|
}
|
|
|
|
store := seedStore(t, "production", "access")
|
|
err := runRemove(&RemoveOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, "production", store, &testutil.ConfirmPrompter{})
|
|
if err == nil {
|
|
t.Fatal("expected confirmation-required error")
|
|
}
|
|
cm, ok := err.(*cmdutil.Error)
|
|
if !ok {
|
|
t.Fatalf("expected *cmdutil.Error, got %T", err)
|
|
}
|
|
if cm.Code != cmdutil.CodeInputConfirmationRequired {
|
|
t.Errorf("code=%q, want %q", cm.Code, cmdutil.CodeInputConfirmationRequired)
|
|
}
|
|
if cmdutil.ExitCode(err) != 10 {
|
|
t.Errorf("expected exit-10, got %d", cmdutil.ExitCode(err))
|
|
}
|
|
// Must not have mutated config or keyring.
|
|
if got, _ := config.Load(); got.CurrentContext != "production" {
|
|
t.Errorf("config mutated despite confirmation gate: CurrentContext=%q", got.CurrentContext)
|
|
}
|
|
if v, err := store.Get("production", "access"); err != nil || v == "" {
|
|
t.Errorf("keyring touched before confirmation, get=%q err=%v", v, err)
|
|
}
|
|
}
|
|
|
|
func TestRemove_Current_WithYes_ClearsCurrent(t *testing.T) {
|
|
t.Setenv("XDG_CONFIG_HOME", t.TempDir())
|
|
out, _ := iostreams.SetForTest(t)
|
|
|
|
cfg := &config.Config{
|
|
CurrentContext: "production",
|
|
Contexts: map[string]config.Context{
|
|
"production": {Host: "https://prod", TokenRef: "mem://production/access"},
|
|
"staging": {Host: "https://staging"},
|
|
},
|
|
}
|
|
if err := config.Save(cfg); err != nil {
|
|
t.Fatalf("Save: %v", err)
|
|
}
|
|
|
|
store := seedStore(t, "production", "access")
|
|
if err := runRemove(&RemoveOptions{Yes: true}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, "production", store, &testutil.ConfirmPrompter{}); err != nil {
|
|
t.Fatalf("runRemove: %v", err)
|
|
}
|
|
got, _ := config.Load()
|
|
if _, exists := got.Contexts["production"]; exists {
|
|
t.Errorf("production should be removed")
|
|
}
|
|
if got.CurrentContext != "" {
|
|
t.Errorf("removing current must clear CurrentContext, got %q", got.CurrentContext)
|
|
}
|
|
assertDeleted(t, store, "production", "access")
|
|
if !strings.Contains(out.String(), "current profile cleared") {
|
|
t.Errorf("output should warn about cleared current, got %q", out.String())
|
|
}
|
|
}
|
|
|
|
func TestRemove_Current_TTY_PromptNo(t *testing.T) {
|
|
t.Setenv("XDG_CONFIG_HOME", t.TempDir())
|
|
_, errBuf := iostreams.SetForTestWithTTY(t)
|
|
|
|
cfg := &config.Config{
|
|
CurrentContext: "production",
|
|
Contexts: map[string]config.Context{"production": {Host: "https://prod"}},
|
|
}
|
|
if err := config.Save(cfg); err != nil {
|
|
t.Fatalf("Save: %v", err)
|
|
}
|
|
|
|
p := &testutil.ConfirmPrompter{Answer: false}
|
|
err := runRemove(&RemoveOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, "production", secrets.NewMemStore(), p)
|
|
if err == nil {
|
|
t.Fatal("expected user-aborted error")
|
|
}
|
|
cm, ok := err.(*cmdutil.Error)
|
|
if !ok {
|
|
t.Fatalf("expected *cmdutil.Error, got %T", err)
|
|
}
|
|
if cm.Code != cmdutil.CodeUserAborted {
|
|
t.Errorf("code=%q, want %q", cm.Code, cmdutil.CodeUserAborted)
|
|
}
|
|
if !p.Asked {
|
|
t.Errorf("prompt should have been asked on TTY")
|
|
}
|
|
if !strings.Contains(errBuf.String(), "Aborted") {
|
|
t.Errorf("stderr should contain Aborted, got %q", errBuf.String())
|
|
}
|
|
if got, _ := config.Load(); got.CurrentContext != "production" {
|
|
t.Errorf("aborted remove must not mutate config")
|
|
}
|
|
}
|