2ce348d020
D1 — --format default flipped to json regardless of TTY: - v0.6: smart default (text on TTY, json on pipe). - v0.7: always json; TTY only affects indent (compact in pipe). Enum values unchanged (text | json | ndjson). - Typed FormatMode enum replaces untyped string consts. - --format / --jq promoted to persistent root flags so unknown- subcommand paths still reach the typed-envelope guard (per-command registration in v0.6 would have rejected --format on unknown commands as cobra-prose exit 2). - WEKNORA_FORMAT env var added; precedence --format > env > default. Invalid env values silently ignored. D2 — chat / session ask default to NDJSON event-stream: - New cli/internal/output/ndjson_stream.go: InitEvent struct + EmitInit / EmitSDKEvent / WriteNDJSONLine helpers. EmitInit doc encodes the must-be-first-line invariant agents key on. - chat / session ask: --format json AND --format ndjson both emit one JSON event per line (no envelope wrapping). CLI injects exactly one `init` event at stream head carrying session_id + optional kb_id / agent_id / profile. Subsequent events pass through verbatim from the SDK (passthrough discipline per spec §5.1). - --format text keeps the SSE-style live renderer. context → profile full cascade: - Command group: cli/cmd/context/ → cli/cmd/profile/ (git mv; package contextcmd → profilecmd). - Global flag --context → --profile. Factory.ContextOverride → ProfileOverride. WEKNORA_PROFILE env var honored (--profile flag > env > config.CurrentContext). When --profile or WEKNORA_PROFILE references a missing profile, the error is input.invalid_argument with hint "weknora profile list" — not the destructive local.config_corrupt path (which would have told users to delete their config file). - Binding file .weknora/project.yaml field context: → profile: (no backwards-compat alias; re-run weknora link). - profile use JSON fields current_context / previous_context → current_profile / previous_profile. - weknora link JSON field context → profile. - CodeLocalContextNotFound → CodeLocalProfileNotFound (typed code rename). - Envelope top-level profile field populated via globalProfile (set by root PersistentPreRunE from Factory.ActiveProfile). chat / session ask NDJSON init event carries the same profile. - Rationale: "context" collided with LLM context window / RAG context / Go context.Context; mainstream multi-credential CLIs (AWS / Stripe / OpenAI / Anthropic / lark) all use "profile". H2/C1' help calibration: - AgentHelp gains Warnings []string; single SetAgentHelp helper routes on WEKNORA_AGENT_HELP=1 (emits JSON blob including warnings) vs human help (appends "AI agents:" block from same source). Warnings surface as both a structured JSON field and visible help-text addendum without drift. - 9 destructive commands carry warnings: kb / doc / agent / session / chunk delete; profile remove; kb / agent edit; auth logout. - weknora doc wait dedups ids at entry; SIGINT mid-wait returns silently (root signal handler maps to exit 130) instead of being miscategorised as operation.timeout / operation.failed. A4 — docs: - cli/AGENTS.md gains four agent-facing sections: Wire contract for AI agents (stdout / stderr / NDJSON / _notice evolution / SDK contract boundary); Deliberate deviations + mainstream alignments; Pre-1.0 breaking policy; Exit-10 anti-patterns. ERROR_REFERENCE table extended. - cli/README.md adds Agent quick start under Wire contract. - cli/CHANGELOG.md v0.7 section: BREAKING entries with migration notes, Added (WEKNORA_FORMAT / WEKNORA_PROFILE / retry_command / retry_after_seconds / risk / _notice reserved infra / meta.count / meta.has_more / doc fetch / doc create / session ask / doc delete --all / NDJSON init), Changed (docs additions), Deprecated (none — pre-release one-shot breaking). Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3 / §4 / §5 / §6 / §11
149 lines
4.4 KiB
Go
149 lines
4.4 KiB
Go
package linkcmd
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/config"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
"github.com/Tencent/WeKnora/cli/internal/projectlink"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
func chdir(t *testing.T, dir string) {
|
|
t.Helper()
|
|
prev, err := os.Getwd()
|
|
require.NoError(t, err)
|
|
require.NoError(t, os.Chdir(dir))
|
|
t.Cleanup(func() { _ = os.Chdir(prev) })
|
|
}
|
|
|
|
func fakeKBServer(t *testing.T, kbs []sdk.KnowledgeBase) *httptest.Server {
|
|
t.Helper()
|
|
mux := http.NewServeMux()
|
|
mux.HandleFunc("/api/v1/knowledge-bases", func(w http.ResponseWriter, r *http.Request) {
|
|
w.Header().Set("Content-Type", "application/json")
|
|
_ = json.NewEncoder(w).Encode(sdk.KnowledgeBaseListResponse{Success: true, Data: kbs})
|
|
})
|
|
srv := httptest.NewServer(mux)
|
|
t.Cleanup(srv.Close)
|
|
return srv
|
|
}
|
|
|
|
func newFactory(currentCtx string, client *sdk.Client) *cmdutil.Factory {
|
|
cfg := &config.Config{
|
|
CurrentContext: currentCtx,
|
|
Contexts: map[string]config.Context{
|
|
currentCtx: {Host: "https://example"},
|
|
},
|
|
}
|
|
return &cmdutil.Factory{
|
|
Config: func() (*config.Config, error) { return cfg, nil },
|
|
Client: func() (*sdk.Client, error) {
|
|
if client == nil {
|
|
return nil, errors.New("client not configured")
|
|
}
|
|
return client, nil
|
|
},
|
|
}
|
|
}
|
|
|
|
func TestLink_ByID(t *testing.T) {
|
|
dir := t.TempDir()
|
|
chdir(t, dir)
|
|
out, _ := iostreams.SetForTest(t)
|
|
|
|
f := newFactory("default", nil)
|
|
opts := &Options{KB: "aaaaaaaa-aaaa-4aaa-8aaa-aaaaaaaaaaaa"}
|
|
require.NoError(t, runLink(context.Background(), opts, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, f))
|
|
|
|
linkPath := filepath.Join(dir, ".weknora", "project.yaml")
|
|
p, err := projectlink.Load(linkPath)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "aaaaaaaa-aaaa-4aaa-8aaa-aaaaaaaaaaaa", p.KBID)
|
|
assert.Equal(t, "default", p.Profile)
|
|
assert.Contains(t, out.String(), "✓")
|
|
}
|
|
|
|
func TestLink_ByName(t *testing.T) {
|
|
dir := t.TempDir()
|
|
chdir(t, dir)
|
|
_, _ = iostreams.SetForTest(t)
|
|
|
|
srv := fakeKBServer(t, []sdk.KnowledgeBase{
|
|
{ID: "kb_a", Name: "foo"},
|
|
{ID: "kb_b", Name: "bar"},
|
|
})
|
|
cli := sdk.NewClient(srv.URL)
|
|
f := newFactory("default", cli)
|
|
opts := &Options{KB: "foo"}
|
|
require.NoError(t, runLink(context.Background(), opts, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, f))
|
|
|
|
p, err := projectlink.Load(filepath.Join(dir, ".weknora", "project.yaml"))
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "kb_a", p.KBID)
|
|
}
|
|
|
|
func TestLink_KBNotFound(t *testing.T) {
|
|
dir := t.TempDir()
|
|
chdir(t, dir)
|
|
_, _ = iostreams.SetForTest(t)
|
|
|
|
srv := fakeKBServer(t, []sdk.KnowledgeBase{{ID: "kb_a", Name: "foo"}})
|
|
cli := sdk.NewClient(srv.URL)
|
|
f := newFactory("default", cli)
|
|
opts := &Options{KB: "missing"}
|
|
err := runLink(context.Background(), opts, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, f)
|
|
require.Error(t, err)
|
|
var typed *cmdutil.Error
|
|
require.ErrorAs(t, err, &typed)
|
|
assert.Equal(t, cmdutil.CodeKBNotFound, typed.Code)
|
|
}
|
|
|
|
func TestLink_OverwritesExisting(t *testing.T) {
|
|
dir := t.TempDir()
|
|
chdir(t, dir)
|
|
_, _ = iostreams.SetForTest(t)
|
|
|
|
// Pre-existing link.
|
|
linkPath := filepath.Join(dir, ".weknora", "project.yaml")
|
|
require.NoError(t, projectlink.Save(linkPath, &projectlink.Project{
|
|
Profile: "default", KBID: "11111111-1111-4111-8111-111111111111",
|
|
}))
|
|
|
|
f := newFactory("default", nil)
|
|
opts := &Options{KB: "22222222-2222-4222-8222-222222222222"}
|
|
require.NoError(t, runLink(context.Background(), opts, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, f))
|
|
|
|
p, err := projectlink.Load(linkPath)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "22222222-2222-4222-8222-222222222222", p.KBID, "link should overwrite silently")
|
|
}
|
|
|
|
// TestLink_NonInteractive_NoKB exercises the non-TTY-without-flag error path.
|
|
// SetForTest gives us a non-TTY iostreams, so omitting --kb must error rather
|
|
// than hang on a prompt.
|
|
func TestLink_NonInteractive_NoKB(t *testing.T) {
|
|
dir := t.TempDir()
|
|
chdir(t, dir)
|
|
_, _ = iostreams.SetForTest(t)
|
|
|
|
f := newFactory("default", nil)
|
|
opts := &Options{} // no KB
|
|
err := runLink(context.Background(), opts, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, f)
|
|
require.Error(t, err)
|
|
var typed *cmdutil.Error
|
|
require.ErrorAs(t, err, &typed)
|
|
assert.Equal(t, cmdutil.CodeKBIDRequired, typed.Code)
|
|
}
|