2ce348d020
D1 — --format default flipped to json regardless of TTY: - v0.6: smart default (text on TTY, json on pipe). - v0.7: always json; TTY only affects indent (compact in pipe). Enum values unchanged (text | json | ndjson). - Typed FormatMode enum replaces untyped string consts. - --format / --jq promoted to persistent root flags so unknown- subcommand paths still reach the typed-envelope guard (per-command registration in v0.6 would have rejected --format on unknown commands as cobra-prose exit 2). - WEKNORA_FORMAT env var added; precedence --format > env > default. Invalid env values silently ignored. D2 — chat / session ask default to NDJSON event-stream: - New cli/internal/output/ndjson_stream.go: InitEvent struct + EmitInit / EmitSDKEvent / WriteNDJSONLine helpers. EmitInit doc encodes the must-be-first-line invariant agents key on. - chat / session ask: --format json AND --format ndjson both emit one JSON event per line (no envelope wrapping). CLI injects exactly one `init` event at stream head carrying session_id + optional kb_id / agent_id / profile. Subsequent events pass through verbatim from the SDK (passthrough discipline per spec §5.1). - --format text keeps the SSE-style live renderer. context → profile full cascade: - Command group: cli/cmd/context/ → cli/cmd/profile/ (git mv; package contextcmd → profilecmd). - Global flag --context → --profile. Factory.ContextOverride → ProfileOverride. WEKNORA_PROFILE env var honored (--profile flag > env > config.CurrentContext). When --profile or WEKNORA_PROFILE references a missing profile, the error is input.invalid_argument with hint "weknora profile list" — not the destructive local.config_corrupt path (which would have told users to delete their config file). - Binding file .weknora/project.yaml field context: → profile: (no backwards-compat alias; re-run weknora link). - profile use JSON fields current_context / previous_context → current_profile / previous_profile. - weknora link JSON field context → profile. - CodeLocalContextNotFound → CodeLocalProfileNotFound (typed code rename). - Envelope top-level profile field populated via globalProfile (set by root PersistentPreRunE from Factory.ActiveProfile). chat / session ask NDJSON init event carries the same profile. - Rationale: "context" collided with LLM context window / RAG context / Go context.Context; mainstream multi-credential CLIs (AWS / Stripe / OpenAI / Anthropic / lark) all use "profile". H2/C1' help calibration: - AgentHelp gains Warnings []string; single SetAgentHelp helper routes on WEKNORA_AGENT_HELP=1 (emits JSON blob including warnings) vs human help (appends "AI agents:" block from same source). Warnings surface as both a structured JSON field and visible help-text addendum without drift. - 9 destructive commands carry warnings: kb / doc / agent / session / chunk delete; profile remove; kb / agent edit; auth logout. - weknora doc wait dedups ids at entry; SIGINT mid-wait returns silently (root signal handler maps to exit 130) instead of being miscategorised as operation.timeout / operation.failed. A4 — docs: - cli/AGENTS.md gains four agent-facing sections: Wire contract for AI agents (stdout / stderr / NDJSON / _notice evolution / SDK contract boundary); Deliberate deviations + mainstream alignments; Pre-1.0 breaking policy; Exit-10 anti-patterns. ERROR_REFERENCE table extended. - cli/README.md adds Agent quick start under Wire contract. - cli/CHANGELOG.md v0.7 section: BREAKING entries with migration notes, Added (WEKNORA_FORMAT / WEKNORA_PROFILE / retry_command / retry_after_seconds / risk / _notice reserved infra / meta.count / meta.has_more / doc fetch / doc create / session ask / doc delete --all / NDJSON init), Changed (docs additions), Deprecated (none — pre-release one-shot breaking). Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3 / §4 / §5 / §6 / §11
223 lines
8.7 KiB
Go
223 lines
8.7 KiB
Go
package auth
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/config"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
"github.com/Tencent/WeKnora/cli/internal/prompt"
|
|
"github.com/Tencent/WeKnora/cli/internal/secrets"
|
|
"github.com/Tencent/WeKnora/cli/internal/testutil"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
// fakeRefreshService scripts a RefreshToken response.
|
|
type fakeRefreshService struct {
|
|
resp *sdk.RefreshTokenResponse
|
|
err error
|
|
gotTok string
|
|
}
|
|
|
|
func (f *fakeRefreshService) RefreshToken(_ context.Context, refreshToken string) (*sdk.RefreshTokenResponse, error) {
|
|
f.gotTok = refreshToken
|
|
return f.resp, f.err
|
|
}
|
|
|
|
// stubSvc returns a closure conforming to the refresherFor signature; it
|
|
// ignores host since the fake doesn't talk to the network.
|
|
func stubSvc(s cmdutil.Refresher) func(string) cmdutil.Refresher {
|
|
return func(string) cmdutil.Refresher { return s }
|
|
}
|
|
|
|
func newRefreshFactory(t *testing.T, cfg *config.Config, store *secrets.MemStore) *cmdutil.Factory {
|
|
t.Helper()
|
|
testutil.XDGTempDir(t)
|
|
require.NoError(t, config.Save(cfg))
|
|
return &cmdutil.Factory{
|
|
Config: func() (*config.Config, error) { return config.Load() },
|
|
Client: func() (*sdk.Client, error) { panic("client") },
|
|
Prompter: func() prompt.Prompter { return prompt.AgentPrompter{} },
|
|
Secrets: func() (secrets.Store, error) { return store, nil },
|
|
}
|
|
}
|
|
|
|
func TestRefresh_Happy(t *testing.T) {
|
|
iostreams.SetForTest(t)
|
|
store := secrets.NewMemStore()
|
|
require.NoError(t, store.Set("prod", "access", "old-access"))
|
|
require.NoError(t, store.Set("prod", "refresh", "old-refresh"))
|
|
|
|
cfg := &config.Config{
|
|
CurrentContext: "prod",
|
|
Contexts: map[string]config.Context{
|
|
"prod": {
|
|
Host: "https://kb.example.com",
|
|
TokenRef: "mem://prod/access",
|
|
RefreshRef: "mem://prod/refresh",
|
|
User: "alice@example.com",
|
|
},
|
|
},
|
|
}
|
|
f := newRefreshFactory(t, cfg, store)
|
|
svc := &fakeRefreshService{resp: &sdk.RefreshTokenResponse{
|
|
Success: true,
|
|
AccessToken: "new-access",
|
|
RefreshToken: "new-refresh",
|
|
}}
|
|
require.NoError(t, runRefresh(context.Background(), &RefreshOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, f, stubSvc(svc)))
|
|
|
|
assert.Equal(t, "old-refresh", svc.gotTok, "must pass stored refresh token to SDK")
|
|
gotAccess, _ := store.Get("prod", "access")
|
|
gotRefresh, _ := store.Get("prod", "refresh")
|
|
assert.Equal(t, "new-access", gotAccess)
|
|
assert.Equal(t, "new-refresh", gotRefresh)
|
|
}
|
|
|
|
func TestRefresh_NamedContext(t *testing.T) {
|
|
iostreams.SetForTest(t)
|
|
store := secrets.NewMemStore()
|
|
require.NoError(t, store.Set("staging", "refresh", "stg-refresh"))
|
|
|
|
cfg := &config.Config{
|
|
CurrentContext: "prod",
|
|
Contexts: map[string]config.Context{
|
|
"prod": {Host: "https://prod", TokenRef: "mem://prod/access", RefreshRef: "mem://prod/refresh"},
|
|
"staging": {Host: "https://stg", TokenRef: "mem://staging/access", RefreshRef: "mem://staging/refresh"},
|
|
},
|
|
}
|
|
f := newRefreshFactory(t, cfg, store)
|
|
svc := &fakeRefreshService{resp: &sdk.RefreshTokenResponse{
|
|
Success: true, AccessToken: "new-stg-access", RefreshToken: "new-stg-refresh",
|
|
}}
|
|
require.NoError(t, runRefresh(context.Background(), &RefreshOptions{Name: "staging"}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, f, stubSvc(svc)))
|
|
|
|
assert.Equal(t, "stg-refresh", svc.gotTok, "--name=staging must refresh the staging context, not current")
|
|
// current is untouched
|
|
if v, _ := store.Get("prod", "access"); v != "" {
|
|
t.Errorf("prod must not have been touched, got %q", v)
|
|
}
|
|
}
|
|
|
|
func TestRefresh_NoCurrentContext(t *testing.T) {
|
|
iostreams.SetForTest(t)
|
|
f := newRefreshFactory(t, &config.Config{}, secrets.NewMemStore())
|
|
err := runRefresh(context.Background(), &RefreshOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, f, stubSvc(&fakeRefreshService{}))
|
|
require.Error(t, err)
|
|
var typed *cmdutil.Error
|
|
require.ErrorAs(t, err, &typed)
|
|
assert.Equal(t, cmdutil.CodeAuthUnauthenticated, typed.Code)
|
|
}
|
|
|
|
func TestRefresh_APIKeyContext(t *testing.T) {
|
|
iostreams.SetForTest(t)
|
|
store := secrets.NewMemStore()
|
|
require.NoError(t, store.Set("ci", "api_key", "sk-123"))
|
|
cfg := &config.Config{
|
|
CurrentContext: "ci",
|
|
Contexts: map[string]config.Context{"ci": {Host: "https://kb", APIKeyRef: "mem://ci/api_key"}},
|
|
}
|
|
f := newRefreshFactory(t, cfg, store)
|
|
err := runRefresh(context.Background(), &RefreshOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, f, stubSvc(&fakeRefreshService{}))
|
|
require.Error(t, err)
|
|
var typed *cmdutil.Error
|
|
require.ErrorAs(t, err, &typed)
|
|
assert.Equal(t, cmdutil.CodeInputInvalidArgument, typed.Code)
|
|
assert.Contains(t, typed.Hint, "api-key", "hint should explain api-key contexts cannot be refreshed")
|
|
}
|
|
|
|
func TestRefresh_NoRefreshTokenStored(t *testing.T) {
|
|
iostreams.SetForTest(t)
|
|
cfg := &config.Config{
|
|
CurrentContext: "prod",
|
|
Contexts: map[string]config.Context{
|
|
"prod": {Host: "https://kb", TokenRef: "mem://prod/access", RefreshRef: "mem://prod/refresh"},
|
|
},
|
|
}
|
|
// MemStore is empty - RefreshRef points to a slot that doesn't exist.
|
|
f := newRefreshFactory(t, cfg, secrets.NewMemStore())
|
|
err := runRefresh(context.Background(), &RefreshOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, f, stubSvc(&fakeRefreshService{}))
|
|
require.Error(t, err)
|
|
var typed *cmdutil.Error
|
|
require.ErrorAs(t, err, &typed)
|
|
assert.Equal(t, cmdutil.CodeAuthTokenExpired, typed.Code)
|
|
assert.Contains(t, typed.Hint, "auth login")
|
|
}
|
|
|
|
func TestRefresh_ServerRefused(t *testing.T) {
|
|
iostreams.SetForTest(t)
|
|
store := secrets.NewMemStore()
|
|
require.NoError(t, store.Set("prod", "refresh", "stale-refresh"))
|
|
cfg := &config.Config{
|
|
CurrentContext: "prod",
|
|
Contexts: map[string]config.Context{"prod": {Host: "https://kb", TokenRef: "mem://prod/access", RefreshRef: "mem://prod/refresh"}},
|
|
}
|
|
f := newRefreshFactory(t, cfg, store)
|
|
svc := &fakeRefreshService{resp: &sdk.RefreshTokenResponse{Success: false, Message: "refresh token expired"}}
|
|
err := runRefresh(context.Background(), &RefreshOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, f, stubSvc(svc))
|
|
require.Error(t, err)
|
|
var typed *cmdutil.Error
|
|
require.ErrorAs(t, err, &typed)
|
|
assert.Equal(t, cmdutil.CodeAuthTokenExpired, typed.Code)
|
|
assert.Contains(t, typed.Hint, "auth login")
|
|
// stored access must NOT have been overwritten with empty
|
|
if v, _ := store.Get("prod", "access"); v == "" {
|
|
// Was never set in this test, that's fine - main thing is no panic.
|
|
_ = v
|
|
}
|
|
}
|
|
|
|
func TestRefresh_TransportError(t *testing.T) {
|
|
iostreams.SetForTest(t)
|
|
store := secrets.NewMemStore()
|
|
require.NoError(t, store.Set("prod", "refresh", "ok-refresh"))
|
|
cfg := &config.Config{
|
|
CurrentContext: "prod",
|
|
Contexts: map[string]config.Context{"prod": {Host: "https://kb", TokenRef: "mem://prod/access", RefreshRef: "mem://prod/refresh"}},
|
|
}
|
|
f := newRefreshFactory(t, cfg, store)
|
|
svc := &fakeRefreshService{err: errors.New("connection reset")}
|
|
err := runRefresh(context.Background(), &RefreshOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, f, stubSvc(svc))
|
|
require.Error(t, err)
|
|
var typed *cmdutil.Error
|
|
require.ErrorAs(t, err, &typed)
|
|
// network/transport classified as network.error (mirrors auth login's
|
|
// CodeAuthBadCredential mapping pattern; here we keep network errors
|
|
// distinct since auth/refresh treats them as retryable).
|
|
assert.Equal(t, cmdutil.CodeNetworkError, typed.Code)
|
|
}
|
|
|
|
func TestRefresh_JSONOutput(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
store := secrets.NewMemStore()
|
|
require.NoError(t, store.Set("prod", "refresh", "ok-refresh"))
|
|
cfg := &config.Config{
|
|
CurrentContext: "prod",
|
|
Contexts: map[string]config.Context{"prod": {Host: "https://kb", TokenRef: "mem://prod/access", RefreshRef: "mem://prod/refresh"}},
|
|
}
|
|
f := newRefreshFactory(t, cfg, store)
|
|
svc := &fakeRefreshService{resp: &sdk.RefreshTokenResponse{Success: true, AccessToken: "a", RefreshToken: "r"}}
|
|
require.NoError(t, runRefresh(context.Background(), &RefreshOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatJSON}, f, stubSvc(svc)))
|
|
|
|
body := out.String()
|
|
// payload must not leak the actual token values.
|
|
assert.NotContains(t, body, "ok-refresh", "output must not leak refresh token")
|
|
assert.NotContains(t, body, "\"a\"", "output must not leak the new access token")
|
|
assert.NotContains(t, body, "\"r\"", "output must not leak the new refresh token")
|
|
// must mention the context name so agents can confirm what was refreshed
|
|
assert.True(t, strings.Contains(body, "prod"), "output should reference the refreshed context")
|
|
// v0.7 envelope: ok:true is expected
|
|
var env struct {
|
|
OK bool `json:"ok"`
|
|
}
|
|
require.NoError(t, json.Unmarshal([]byte(body), &env))
|
|
assert.True(t, env.OK, "envelope.ok must be true")
|
|
}
|