2ce348d020
D1 — --format default flipped to json regardless of TTY: - v0.6: smart default (text on TTY, json on pipe). - v0.7: always json; TTY only affects indent (compact in pipe). Enum values unchanged (text | json | ndjson). - Typed FormatMode enum replaces untyped string consts. - --format / --jq promoted to persistent root flags so unknown- subcommand paths still reach the typed-envelope guard (per-command registration in v0.6 would have rejected --format on unknown commands as cobra-prose exit 2). - WEKNORA_FORMAT env var added; precedence --format > env > default. Invalid env values silently ignored. D2 — chat / session ask default to NDJSON event-stream: - New cli/internal/output/ndjson_stream.go: InitEvent struct + EmitInit / EmitSDKEvent / WriteNDJSONLine helpers. EmitInit doc encodes the must-be-first-line invariant agents key on. - chat / session ask: --format json AND --format ndjson both emit one JSON event per line (no envelope wrapping). CLI injects exactly one `init` event at stream head carrying session_id + optional kb_id / agent_id / profile. Subsequent events pass through verbatim from the SDK (passthrough discipline per spec §5.1). - --format text keeps the SSE-style live renderer. context → profile full cascade: - Command group: cli/cmd/context/ → cli/cmd/profile/ (git mv; package contextcmd → profilecmd). - Global flag --context → --profile. Factory.ContextOverride → ProfileOverride. WEKNORA_PROFILE env var honored (--profile flag > env > config.CurrentContext). When --profile or WEKNORA_PROFILE references a missing profile, the error is input.invalid_argument with hint "weknora profile list" — not the destructive local.config_corrupt path (which would have told users to delete their config file). - Binding file .weknora/project.yaml field context: → profile: (no backwards-compat alias; re-run weknora link). - profile use JSON fields current_context / previous_context → current_profile / previous_profile. - weknora link JSON field context → profile. - CodeLocalContextNotFound → CodeLocalProfileNotFound (typed code rename). - Envelope top-level profile field populated via globalProfile (set by root PersistentPreRunE from Factory.ActiveProfile). chat / session ask NDJSON init event carries the same profile. - Rationale: "context" collided with LLM context window / RAG context / Go context.Context; mainstream multi-credential CLIs (AWS / Stripe / OpenAI / Anthropic / lark) all use "profile". H2/C1' help calibration: - AgentHelp gains Warnings []string; single SetAgentHelp helper routes on WEKNORA_AGENT_HELP=1 (emits JSON blob including warnings) vs human help (appends "AI agents:" block from same source). Warnings surface as both a structured JSON field and visible help-text addendum without drift. - 9 destructive commands carry warnings: kb / doc / agent / session / chunk delete; profile remove; kb / agent edit; auth logout. - weknora doc wait dedups ids at entry; SIGINT mid-wait returns silently (root signal handler maps to exit 130) instead of being miscategorised as operation.timeout / operation.failed. A4 — docs: - cli/AGENTS.md gains four agent-facing sections: Wire contract for AI agents (stdout / stderr / NDJSON / _notice evolution / SDK contract boundary); Deliberate deviations + mainstream alignments; Pre-1.0 breaking policy; Exit-10 anti-patterns. ERROR_REFERENCE table extended. - cli/README.md adds Agent quick start under Wire contract. - cli/CHANGELOG.md v0.7 section: BREAKING entries with migration notes, Added (WEKNORA_FORMAT / WEKNORA_PROFILE / retry_command / retry_after_seconds / risk / _notice reserved infra / meta.count / meta.has_more / doc fetch / doc create / session ask / doc delete --all / NDJSON init), Changed (docs additions), Deprecated (none — pre-release one-shot breaking). Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3 / §4 / §5 / §6 / §11
153 lines
5.4 KiB
Go
153 lines
5.4 KiB
Go
package auth
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/config"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
"github.com/Tencent/WeKnora/cli/internal/prompt"
|
|
"github.com/Tencent/WeKnora/cli/internal/secrets"
|
|
)
|
|
|
|
// newLogoutFactory builds a Factory whose Config closure mutates the supplied
|
|
// cfg in place - runLogout writes back via config.Save which touches disk, so
|
|
// tests use t.Setenv("XDG_CONFIG_HOME", t.TempDir()) at the call site to
|
|
// isolate the on-disk file.
|
|
func newLogoutFactory(t *testing.T, cfg *config.Config, store secrets.Store) *cmdutil.Factory {
|
|
t.Helper()
|
|
return &cmdutil.Factory{
|
|
Config: func() (*config.Config, error) { return cfg, nil },
|
|
Secrets: func() (secrets.Store, error) { return store, nil },
|
|
Prompter: func() prompt.Prompter { return &prompt.AgentPrompter{} },
|
|
}
|
|
}
|
|
|
|
func isolateConfig(t *testing.T) {
|
|
t.Helper()
|
|
t.Setenv("XDG_CONFIG_HOME", t.TempDir())
|
|
}
|
|
|
|
func TestLogout_CurrentContext(t *testing.T) {
|
|
isolateConfig(t)
|
|
_, _ = iostreams.SetForTest(t)
|
|
store := secrets.NewMemStore()
|
|
require.NoError(t, store.Set("prod", "access", "jwt-prod"))
|
|
require.NoError(t, store.Set("prod", "refresh", "rfr-prod"))
|
|
require.NoError(t, store.Set("staging", "api_key", "sk-staging"))
|
|
|
|
cfg := &config.Config{
|
|
CurrentContext: "prod",
|
|
Contexts: map[string]config.Context{
|
|
"prod": {Host: "https://prod", TokenRef: store.Ref("prod", "access"), RefreshRef: store.Ref("prod", "refresh")},
|
|
"staging": {Host: "https://staging", APIKeyRef: store.Ref("staging", "api_key")},
|
|
},
|
|
}
|
|
require.NoError(t, runLogout(&LogoutOptions{Yes: true}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, newLogoutFactory(t, cfg, store)))
|
|
|
|
assert.Empty(t, cfg.CurrentContext, "current_context should clear when removed")
|
|
assert.NotContains(t, cfg.Contexts, "prod")
|
|
assert.Contains(t, cfg.Contexts, "staging", "non-target context untouched")
|
|
|
|
// Secrets gone for the removed context, kept for the survivor.
|
|
if _, err := store.Get("prod", "access"); err == nil {
|
|
t.Error("prod access secret should be deleted")
|
|
}
|
|
if v, _ := store.Get("staging", "api_key"); v != "sk-staging" {
|
|
t.Errorf("staging secret unexpectedly cleared: %q", v)
|
|
}
|
|
}
|
|
|
|
func TestLogout_NamedContext(t *testing.T) {
|
|
isolateConfig(t)
|
|
_, _ = iostreams.SetForTest(t)
|
|
store := secrets.NewMemStore()
|
|
require.NoError(t, store.Set("staging", "api_key", "sk-staging"))
|
|
|
|
cfg := &config.Config{
|
|
CurrentContext: "prod",
|
|
Contexts: map[string]config.Context{
|
|
"prod": {Host: "https://prod", TokenRef: "tok"},
|
|
"staging": {Host: "https://staging", APIKeyRef: store.Ref("staging", "api_key")},
|
|
},
|
|
}
|
|
require.NoError(t, runLogout(&LogoutOptions{Name: "staging", Yes: true}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, newLogoutFactory(t, cfg, store)))
|
|
|
|
assert.Equal(t, "prod", cfg.CurrentContext, "current_context untouched when removing other")
|
|
assert.NotContains(t, cfg.Contexts, "staging")
|
|
assert.Contains(t, cfg.Contexts, "prod")
|
|
}
|
|
|
|
func TestLogout_All(t *testing.T) {
|
|
isolateConfig(t)
|
|
_, _ = iostreams.SetForTest(t)
|
|
store := secrets.NewMemStore()
|
|
cfg := &config.Config{
|
|
CurrentContext: "prod",
|
|
Contexts: map[string]config.Context{
|
|
"prod": {Host: "https://prod"},
|
|
"staging": {Host: "https://staging"},
|
|
},
|
|
}
|
|
require.NoError(t, runLogout(&LogoutOptions{All: true, Yes: true}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, newLogoutFactory(t, cfg, store)))
|
|
|
|
assert.Empty(t, cfg.Contexts)
|
|
assert.Empty(t, cfg.CurrentContext)
|
|
}
|
|
|
|
func TestLogout_NoContexts(t *testing.T) {
|
|
isolateConfig(t)
|
|
_, _ = iostreams.SetForTest(t)
|
|
cfg := &config.Config{}
|
|
err := runLogout(&LogoutOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, newLogoutFactory(t, cfg, secrets.NewMemStore()))
|
|
require.Error(t, err)
|
|
var typed *cmdutil.Error
|
|
require.ErrorAs(t, err, &typed)
|
|
assert.Equal(t, cmdutil.CodeAuthUnauthenticated, typed.Code)
|
|
}
|
|
|
|
func TestLogout_UnknownName(t *testing.T) {
|
|
isolateConfig(t)
|
|
_, _ = iostreams.SetForTest(t)
|
|
cfg := &config.Config{
|
|
CurrentContext: "prod",
|
|
Contexts: map[string]config.Context{"prod": {Host: "https://prod"}},
|
|
}
|
|
err := runLogout(&LogoutOptions{Name: "ghost"}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, newLogoutFactory(t, cfg, secrets.NewMemStore()))
|
|
require.Error(t, err)
|
|
var typed *cmdutil.Error
|
|
require.ErrorAs(t, err, &typed)
|
|
assert.Equal(t, cmdutil.CodeLocalProfileNotFound, typed.Code)
|
|
}
|
|
|
|
func TestLogout_NoCurrentNoFlag(t *testing.T) {
|
|
isolateConfig(t)
|
|
_, _ = iostreams.SetForTest(t)
|
|
cfg := &config.Config{
|
|
Contexts: map[string]config.Context{"prod": {Host: "https://prod"}},
|
|
}
|
|
err := runLogout(&LogoutOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, newLogoutFactory(t, cfg, secrets.NewMemStore()))
|
|
require.Error(t, err)
|
|
var typed *cmdutil.Error
|
|
require.ErrorAs(t, err, &typed)
|
|
assert.Equal(t, cmdutil.CodeInputMissingFlag, typed.Code)
|
|
}
|
|
|
|
// TestLogout_Cobra exercises the cobra layer for the mutually-exclusive
|
|
// --name + --all flag pair.
|
|
func TestLogout_Cobra_FlagsMutuallyExclusive(t *testing.T) {
|
|
isolateConfig(t)
|
|
_, _ = iostreams.SetForTest(t)
|
|
cfg := &config.Config{Contexts: map[string]config.Context{"a": {}}}
|
|
cmd := NewCmdLogout(newLogoutFactory(t, cfg, secrets.NewMemStore()))
|
|
cmd.SetContext(context.Background())
|
|
cmd.SetArgs([]string{"--name", "a", "--all"})
|
|
cmd.SilenceErrors = true
|
|
cmd.SilenceUsage = true
|
|
require.Error(t, cmd.Execute())
|
|
}
|