2ce348d020
D1 — --format default flipped to json regardless of TTY: - v0.6: smart default (text on TTY, json on pipe). - v0.7: always json; TTY only affects indent (compact in pipe). Enum values unchanged (text | json | ndjson). - Typed FormatMode enum replaces untyped string consts. - --format / --jq promoted to persistent root flags so unknown- subcommand paths still reach the typed-envelope guard (per-command registration in v0.6 would have rejected --format on unknown commands as cobra-prose exit 2). - WEKNORA_FORMAT env var added; precedence --format > env > default. Invalid env values silently ignored. D2 — chat / session ask default to NDJSON event-stream: - New cli/internal/output/ndjson_stream.go: InitEvent struct + EmitInit / EmitSDKEvent / WriteNDJSONLine helpers. EmitInit doc encodes the must-be-first-line invariant agents key on. - chat / session ask: --format json AND --format ndjson both emit one JSON event per line (no envelope wrapping). CLI injects exactly one `init` event at stream head carrying session_id + optional kb_id / agent_id / profile. Subsequent events pass through verbatim from the SDK (passthrough discipline per spec §5.1). - --format text keeps the SSE-style live renderer. context → profile full cascade: - Command group: cli/cmd/context/ → cli/cmd/profile/ (git mv; package contextcmd → profilecmd). - Global flag --context → --profile. Factory.ContextOverride → ProfileOverride. WEKNORA_PROFILE env var honored (--profile flag > env > config.CurrentContext). When --profile or WEKNORA_PROFILE references a missing profile, the error is input.invalid_argument with hint "weknora profile list" — not the destructive local.config_corrupt path (which would have told users to delete their config file). - Binding file .weknora/project.yaml field context: → profile: (no backwards-compat alias; re-run weknora link). - profile use JSON fields current_context / previous_context → current_profile / previous_profile. - weknora link JSON field context → profile. - CodeLocalContextNotFound → CodeLocalProfileNotFound (typed code rename). - Envelope top-level profile field populated via globalProfile (set by root PersistentPreRunE from Factory.ActiveProfile). chat / session ask NDJSON init event carries the same profile. - Rationale: "context" collided with LLM context window / RAG context / Go context.Context; mainstream multi-credential CLIs (AWS / Stripe / OpenAI / Anthropic / lark) all use "profile". H2/C1' help calibration: - AgentHelp gains Warnings []string; single SetAgentHelp helper routes on WEKNORA_AGENT_HELP=1 (emits JSON blob including warnings) vs human help (appends "AI agents:" block from same source). Warnings surface as both a structured JSON field and visible help-text addendum without drift. - 9 destructive commands carry warnings: kb / doc / agent / session / chunk delete; profile remove; kb / agent edit; auth logout. - weknora doc wait dedups ids at entry; SIGINT mid-wait returns silently (root signal handler maps to exit 130) instead of being miscategorised as operation.timeout / operation.failed. A4 — docs: - cli/AGENTS.md gains four agent-facing sections: Wire contract for AI agents (stdout / stderr / NDJSON / _notice evolution / SDK contract boundary); Deliberate deviations + mainstream alignments; Pre-1.0 breaking policy; Exit-10 anti-patterns. ERROR_REFERENCE table extended. - cli/README.md adds Agent quick start under Wire contract. - cli/CHANGELOG.md v0.7 section: BREAKING entries with migration notes, Added (WEKNORA_FORMAT / WEKNORA_PROFILE / retry_command / retry_after_seconds / risk / _notice reserved infra / meta.count / meta.has_more / doc fetch / doc create / session ask / doc delete --all / NDJSON init), Changed (docs additions), Deprecated (none — pre-release one-shot breaking). Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3 / §4 / §5 / §6 / §11
171 lines
6.2 KiB
Go
171 lines
6.2 KiB
Go
package auth
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/config"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
"github.com/Tencent/WeKnora/cli/internal/prompt"
|
|
"github.com/Tencent/WeKnora/cli/internal/secrets"
|
|
"github.com/Tencent/WeKnora/cli/internal/testutil"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
// fakeLoginService captures the email/password it received.
|
|
type fakeLoginService struct {
|
|
resp *sdk.LoginResponse
|
|
err error
|
|
got struct{ email, password string }
|
|
}
|
|
|
|
func (f *fakeLoginService) Login(_ context.Context, req sdk.LoginRequest) (*sdk.LoginResponse, error) {
|
|
f.got.email = req.Email
|
|
f.got.password = req.Password
|
|
return f.resp, f.err
|
|
}
|
|
|
|
// scriptedPrompter satisfies prompt.Prompter with predetermined values.
|
|
type scriptedPrompter struct{ email, password string }
|
|
|
|
func (s scriptedPrompter) Input(string, string) (string, error) { return s.email, nil }
|
|
func (s scriptedPrompter) Password(string) (string, error) { return s.password, nil }
|
|
func (s scriptedPrompter) Confirm(string, bool) (bool, error) { return true, nil }
|
|
|
|
func newTestFactoryWithConfig(t *testing.T, p prompt.Prompter) (*cmdutil.Factory, *secrets.MemStore) {
|
|
t.Helper()
|
|
testutil.XDGTempDir(t)
|
|
store := secrets.NewMemStore()
|
|
return &cmdutil.Factory{
|
|
Config: func() (*config.Config, error) { return config.Load() },
|
|
Client: func() (*sdk.Client, error) { panic("client") },
|
|
Prompter: func() prompt.Prompter { return p },
|
|
Secrets: func() (secrets.Store, error) { return store, nil },
|
|
}, store
|
|
}
|
|
|
|
func TestRunLogin_PasswordMode(t *testing.T) {
|
|
iostreams.SetForTest(t)
|
|
f, store := newTestFactoryWithConfig(t, scriptedPrompter{email: "a@b.c", password: "secret"})
|
|
svc := &fakeLoginService{resp: &sdk.LoginResponse{
|
|
Success: true,
|
|
Token: "jwt-access",
|
|
User: &sdk.AuthUser{ID: "u1", Email: "a@b.c", TenantID: 7},
|
|
}}
|
|
opts := &LoginOptions{
|
|
Host: "https://kb.example.com",
|
|
Context: "prod",
|
|
}
|
|
require.NoError(t, runLogin(context.Background(), opts, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, f, svc))
|
|
|
|
assert.Equal(t, "a@b.c", svc.got.email)
|
|
assert.Equal(t, "secret", svc.got.password)
|
|
|
|
got, _ := store.Get("prod", "access")
|
|
assert.Equal(t, "jwt-access", got)
|
|
}
|
|
|
|
func TestRunLogin_WithToken(t *testing.T) {
|
|
iostreams.SetForTest(t)
|
|
f, store := newTestFactoryWithConfig(t, prompt.AgentPrompter{})
|
|
restore := stubAPIKeyValidator(func(_ context.Context, _, _ string) (*sdk.AuthUser, error) {
|
|
return &sdk.AuthUser{ID: "u1", Email: "ci@example.com", TenantID: 7}, nil
|
|
})
|
|
defer restore()
|
|
opts := &LoginOptions{
|
|
Host: "https://kb.example.com",
|
|
Context: "ci",
|
|
WithToken: true,
|
|
StdinReader: strings.NewReader(" sk-1234 \n"),
|
|
}
|
|
require.NoError(t, runLogin(context.Background(), opts, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, f, nil))
|
|
got, _ := store.Get("ci", "api_key")
|
|
assert.Equal(t, "sk-1234", got)
|
|
cfg, _ := f.Config()
|
|
assert.Equal(t, "ci@example.com", cfg.Contexts["ci"].User, "validator-returned user should be persisted")
|
|
assert.Equal(t, uint64(7), cfg.Contexts["ci"].TenantID)
|
|
}
|
|
|
|
func TestRunLogin_WithToken_ServerRejects(t *testing.T) {
|
|
iostreams.SetForTest(t)
|
|
f, _ := newTestFactoryWithConfig(t, prompt.AgentPrompter{})
|
|
restore := stubAPIKeyValidator(func(_ context.Context, _, _ string) (*sdk.AuthUser, error) {
|
|
// Use the SDK-format HTTP error message so ClassifyHTTPError detects
|
|
// this as an HTTP 401, not a transport/network failure.
|
|
return nil, errors.New("HTTP error 401: invalid api key")
|
|
})
|
|
defer restore()
|
|
opts := &LoginOptions{
|
|
Host: "https://kb.example.com",
|
|
Context: "ci",
|
|
WithToken: true,
|
|
StdinReader: strings.NewReader("sk-bad"),
|
|
}
|
|
err := runLogin(context.Background(), opts, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, f, nil)
|
|
require.Error(t, err)
|
|
var typed *cmdutil.Error
|
|
require.ErrorAs(t, err, &typed)
|
|
assert.Equal(t, cmdutil.CodeAuthBadCredential, typed.Code,
|
|
"server-side rejection must surface as auth.bad_credential, not persist the key")
|
|
}
|
|
|
|
// stubAPIKeyValidator swaps defaultAPIKeyValidator for the test and returns
|
|
// a restore func to defer.
|
|
func stubAPIKeyValidator(fn apiKeyValidator) func() {
|
|
saved := defaultAPIKeyValidator
|
|
defaultAPIKeyValidator = fn
|
|
return func() { defaultAPIKeyValidator = saved }
|
|
}
|
|
|
|
func TestRunLogin_WithToken_Empty(t *testing.T) {
|
|
iostreams.SetForTest(t)
|
|
f, _ := newTestFactoryWithConfig(t, prompt.AgentPrompter{})
|
|
// Validator must NOT be called when stdin is empty - verify by setting
|
|
// a panic-on-call sentinel.
|
|
restore := stubAPIKeyValidator(func(_ context.Context, _, _ string) (*sdk.AuthUser, error) {
|
|
t.Fatal("validator should not be called on empty stdin")
|
|
return nil, nil
|
|
})
|
|
defer restore()
|
|
opts := &LoginOptions{
|
|
Host: "https://kb.example.com",
|
|
Context: "ci",
|
|
WithToken: true,
|
|
StdinReader: strings.NewReader(""),
|
|
}
|
|
err := runLogin(context.Background(), opts, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, f, nil)
|
|
require.Error(t, err)
|
|
assert.Contains(t, err.Error(), "input.missing_flag")
|
|
}
|
|
|
|
func TestRunLogin_BadHost(t *testing.T) {
|
|
iostreams.SetForTest(t)
|
|
f, _ := newTestFactoryWithConfig(t, prompt.AgentPrompter{})
|
|
err := runLogin(context.Background(), &LoginOptions{Host: "ftp://nope"}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, f, nil)
|
|
require.Error(t, err)
|
|
assert.Contains(t, err.Error(), "input.invalid_argument")
|
|
}
|
|
|
|
func TestRunLogin_LoginRefused(t *testing.T) {
|
|
iostreams.SetForTest(t)
|
|
f, _ := newTestFactoryWithConfig(t, scriptedPrompter{email: "a@b.c", password: "x"})
|
|
svc := &fakeLoginService{resp: &sdk.LoginResponse{Success: false, Message: "bad password"}}
|
|
err := runLogin(context.Background(), &LoginOptions{Host: "https://x", Context: "p"}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, f, svc)
|
|
require.Error(t, err)
|
|
assert.Contains(t, err.Error(), "auth.bad_credential")
|
|
}
|
|
|
|
func TestValidateHost(t *testing.T) {
|
|
require.NoError(t, validateHost("https://kb.example.com"))
|
|
require.NoError(t, validateHost("http://localhost:8080"))
|
|
require.Error(t, validateHost(""))
|
|
require.Error(t, validateHost("ftp://x"))
|
|
require.Error(t, validateHost("not a url"))
|
|
}
|