2ce348d020
D1 — --format default flipped to json regardless of TTY: - v0.6: smart default (text on TTY, json on pipe). - v0.7: always json; TTY only affects indent (compact in pipe). Enum values unchanged (text | json | ndjson). - Typed FormatMode enum replaces untyped string consts. - --format / --jq promoted to persistent root flags so unknown- subcommand paths still reach the typed-envelope guard (per-command registration in v0.6 would have rejected --format on unknown commands as cobra-prose exit 2). - WEKNORA_FORMAT env var added; precedence --format > env > default. Invalid env values silently ignored. D2 — chat / session ask default to NDJSON event-stream: - New cli/internal/output/ndjson_stream.go: InitEvent struct + EmitInit / EmitSDKEvent / WriteNDJSONLine helpers. EmitInit doc encodes the must-be-first-line invariant agents key on. - chat / session ask: --format json AND --format ndjson both emit one JSON event per line (no envelope wrapping). CLI injects exactly one `init` event at stream head carrying session_id + optional kb_id / agent_id / profile. Subsequent events pass through verbatim from the SDK (passthrough discipline per spec §5.1). - --format text keeps the SSE-style live renderer. context → profile full cascade: - Command group: cli/cmd/context/ → cli/cmd/profile/ (git mv; package contextcmd → profilecmd). - Global flag --context → --profile. Factory.ContextOverride → ProfileOverride. WEKNORA_PROFILE env var honored (--profile flag > env > config.CurrentContext). When --profile or WEKNORA_PROFILE references a missing profile, the error is input.invalid_argument with hint "weknora profile list" — not the destructive local.config_corrupt path (which would have told users to delete their config file). - Binding file .weknora/project.yaml field context: → profile: (no backwards-compat alias; re-run weknora link). - profile use JSON fields current_context / previous_context → current_profile / previous_profile. - weknora link JSON field context → profile. - CodeLocalContextNotFound → CodeLocalProfileNotFound (typed code rename). - Envelope top-level profile field populated via globalProfile (set by root PersistentPreRunE from Factory.ActiveProfile). chat / session ask NDJSON init event carries the same profile. - Rationale: "context" collided with LLM context window / RAG context / Go context.Context; mainstream multi-credential CLIs (AWS / Stripe / OpenAI / Anthropic / lark) all use "profile". H2/C1' help calibration: - AgentHelp gains Warnings []string; single SetAgentHelp helper routes on WEKNORA_AGENT_HELP=1 (emits JSON blob including warnings) vs human help (appends "AI agents:" block from same source). Warnings surface as both a structured JSON field and visible help-text addendum without drift. - 9 destructive commands carry warnings: kb / doc / agent / session / chunk delete; profile remove; kb / agent edit; auth logout. - weknora doc wait dedups ids at entry; SIGINT mid-wait returns silently (root signal handler maps to exit 130) instead of being miscategorised as operation.timeout / operation.failed. A4 — docs: - cli/AGENTS.md gains four agent-facing sections: Wire contract for AI agents (stdout / stderr / NDJSON / _notice evolution / SDK contract boundary); Deliberate deviations + mainstream alignments; Pre-1.0 breaking policy; Exit-10 anti-patterns. ERROR_REFERENCE table extended. - cli/README.md adds Agent quick start under Wire contract. - cli/CHANGELOG.md v0.7 section: BREAKING entries with migration notes, Added (WEKNORA_FORMAT / WEKNORA_PROFILE / retry_command / retry_after_seconds / risk / _notice reserved infra / meta.count / meta.has_more / doc fetch / doc create / session ask / doc delete --all / NDJSON init), Changed (docs additions), Deprecated (none — pre-release one-shot breaking). Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3 / §4 / §5 / §6 / §11
124 lines
3.9 KiB
Go
124 lines
3.9 KiB
Go
package auth
|
|
|
|
import (
|
|
"context"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/spf13/cobra"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/config"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
"github.com/Tencent/WeKnora/cli/internal/prompt"
|
|
"github.com/Tencent/WeKnora/cli/internal/secrets"
|
|
"github.com/Tencent/WeKnora/cli/internal/testutil"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
func TestNewCmdAuth_TreeShape(t *testing.T) {
|
|
cmd := NewCmdAuth(&cmdutil.Factory{})
|
|
assert.Equal(t, "auth", cmd.Use)
|
|
subs := map[string]*cobra.Command{}
|
|
for _, c := range cmd.Commands() {
|
|
subs[c.Use] = c
|
|
}
|
|
assert.Contains(t, subs, "login")
|
|
assert.Contains(t, subs, "status")
|
|
}
|
|
|
|
func TestNewCmdLogin_FlagsRegistered(t *testing.T) {
|
|
cmd := NewCmdLogin(&cmdutil.Factory{}, nil)
|
|
// --format is a persistent root flag (v0.7); only per-command flags here.
|
|
for _, name := range []string{"host", "name", "with-token"} {
|
|
assert.NotNilf(t, cmd.Flags().Lookup(name), "flag %s missing", name)
|
|
}
|
|
// --profile is the global persistent override; local registration would
|
|
// silently shadow it.
|
|
assert.Nil(t, cmd.Flags().Lookup("profile"), "auth login must not declare a local --profile flag (use --name)")
|
|
}
|
|
|
|
func TestNewCmdLogin_InvokesRunF(t *testing.T) {
|
|
iostreams.SetForTest(t)
|
|
called := false
|
|
store := secrets.NewMemStore()
|
|
f := &cmdutil.Factory{
|
|
Secrets: func() (secrets.Store, error) { return store, nil },
|
|
}
|
|
cmd := NewCmdLogin(f, func(_ context.Context, opts *LoginOptions, _ *cmdutil.FormatOptions, _ *cmdutil.Factory, _ LoginService) error {
|
|
called = true
|
|
assert.Equal(t, "https://kb.example.com", opts.Host)
|
|
assert.True(t, opts.WithToken)
|
|
return nil
|
|
})
|
|
cmd.SetArgs([]string{"--host", "https://kb.example.com", "--with-token"})
|
|
require.NoError(t, cmd.Execute())
|
|
assert.True(t, called)
|
|
}
|
|
|
|
func TestLoginServiceFor(t *testing.T) {
|
|
assert.Nil(t, loginServiceFor(""))
|
|
assert.NotNil(t, loginServiceFor("https://x"))
|
|
}
|
|
|
|
func TestPersistAPIKey_WritesContext(t *testing.T) {
|
|
iostreams.SetForTest(t)
|
|
testutil.XDGTempDir(t)
|
|
store := secrets.NewMemStore()
|
|
f := &cmdutil.Factory{
|
|
Config: func() (*config.Config, error) { return config.Load() },
|
|
Prompter: func() prompt.Prompter { return prompt.AgentPrompter{} },
|
|
Secrets: func() (secrets.Store, error) { return store, nil },
|
|
}
|
|
opts := &LoginOptions{
|
|
Host: "https://kb.example.com",
|
|
Context: "ci",
|
|
APIKey: "sk-zzz",
|
|
}
|
|
require.NoError(t, persistAPIKey(opts, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, f, nil))
|
|
v, _ := store.Get("ci", "api_key")
|
|
assert.Equal(t, "sk-zzz", v)
|
|
cfg, _ := f.Config()
|
|
assert.Equal(t, "ci", cfg.CurrentContext)
|
|
assert.Equal(t, "https://kb.example.com", cfg.Contexts["ci"].Host)
|
|
// APIKeyRef should be the mem:// URI from the store's Ref method.
|
|
assert.Equal(t, "mem://ci/api_key", cfg.Contexts["ci"].APIKeyRef)
|
|
}
|
|
|
|
func TestPersistJWT_StoresBothTokens(t *testing.T) {
|
|
iostreams.SetForTest(t)
|
|
testutil.XDGTempDir(t)
|
|
store := secrets.NewMemStore()
|
|
f := &cmdutil.Factory{
|
|
Config: func() (*config.Config, error) { return config.Load() },
|
|
Prompter: func() prompt.Prompter { return prompt.AgentPrompter{} },
|
|
Secrets: func() (secrets.Store, error) { return store, nil },
|
|
}
|
|
opts := &LoginOptions{
|
|
Host: "https://x",
|
|
Context: "p",
|
|
}
|
|
resp := &sdk.LoginResponse{
|
|
Token: "jwt-acc",
|
|
RefreshToken: "jwt-ref",
|
|
User: &sdk.AuthUser{Email: "a@b.c", TenantID: 7},
|
|
}
|
|
require.NoError(t, persistJWT(opts, &cmdutil.FormatOptions{Mode: cmdutil.FormatJSON}, f, resp))
|
|
a, _ := store.Get("p", "access")
|
|
r, _ := store.Get("p", "refresh")
|
|
assert.Equal(t, "jwt-acc", a)
|
|
assert.Equal(t, "jwt-ref", r)
|
|
}
|
|
|
|
func TestReadStdinTrimmed(t *testing.T) {
|
|
out, err := readStdinTrimmed(strings.NewReader(" hello \n"))
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "hello", out)
|
|
|
|
out, err = readStdinTrimmed(nil)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "", out)
|
|
}
|