2ce348d020
D1 — --format default flipped to json regardless of TTY: - v0.6: smart default (text on TTY, json on pipe). - v0.7: always json; TTY only affects indent (compact in pipe). Enum values unchanged (text | json | ndjson). - Typed FormatMode enum replaces untyped string consts. - --format / --jq promoted to persistent root flags so unknown- subcommand paths still reach the typed-envelope guard (per-command registration in v0.6 would have rejected --format on unknown commands as cobra-prose exit 2). - WEKNORA_FORMAT env var added; precedence --format > env > default. Invalid env values silently ignored. D2 — chat / session ask default to NDJSON event-stream: - New cli/internal/output/ndjson_stream.go: InitEvent struct + EmitInit / EmitSDKEvent / WriteNDJSONLine helpers. EmitInit doc encodes the must-be-first-line invariant agents key on. - chat / session ask: --format json AND --format ndjson both emit one JSON event per line (no envelope wrapping). CLI injects exactly one `init` event at stream head carrying session_id + optional kb_id / agent_id / profile. Subsequent events pass through verbatim from the SDK (passthrough discipline per spec §5.1). - --format text keeps the SSE-style live renderer. context → profile full cascade: - Command group: cli/cmd/context/ → cli/cmd/profile/ (git mv; package contextcmd → profilecmd). - Global flag --context → --profile. Factory.ContextOverride → ProfileOverride. WEKNORA_PROFILE env var honored (--profile flag > env > config.CurrentContext). When --profile or WEKNORA_PROFILE references a missing profile, the error is input.invalid_argument with hint "weknora profile list" — not the destructive local.config_corrupt path (which would have told users to delete their config file). - Binding file .weknora/project.yaml field context: → profile: (no backwards-compat alias; re-run weknora link). - profile use JSON fields current_context / previous_context → current_profile / previous_profile. - weknora link JSON field context → profile. - CodeLocalContextNotFound → CodeLocalProfileNotFound (typed code rename). - Envelope top-level profile field populated via globalProfile (set by root PersistentPreRunE from Factory.ActiveProfile). chat / session ask NDJSON init event carries the same profile. - Rationale: "context" collided with LLM context window / RAG context / Go context.Context; mainstream multi-credential CLIs (AWS / Stripe / OpenAI / Anthropic / lark) all use "profile". H2/C1' help calibration: - AgentHelp gains Warnings []string; single SetAgentHelp helper routes on WEKNORA_AGENT_HELP=1 (emits JSON blob including warnings) vs human help (appends "AI agents:" block from same source). Warnings surface as both a structured JSON field and visible help-text addendum without drift. - 9 destructive commands carry warnings: kb / doc / agent / session / chunk delete; profile remove; kb / agent edit; auth logout. - weknora doc wait dedups ids at entry; SIGINT mid-wait returns silently (root signal handler maps to exit 130) instead of being miscategorised as operation.timeout / operation.failed. A4 — docs: - cli/AGENTS.md gains four agent-facing sections: Wire contract for AI agents (stdout / stderr / NDJSON / _notice evolution / SDK contract boundary); Deliberate deviations + mainstream alignments; Pre-1.0 breaking policy; Exit-10 anti-patterns. ERROR_REFERENCE table extended. - cli/README.md adds Agent quick start under Wire contract. - cli/CHANGELOG.md v0.7 section: BREAKING entries with migration notes, Added (WEKNORA_FORMAT / WEKNORA_PROFILE / retry_command / retry_after_seconds / risk / _notice reserved infra / meta.count / meta.has_more / doc fetch / doc create / session ask / doc delete --all / NDJSON init), Changed (docs additions), Deprecated (none — pre-release one-shot breaking). Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3 / §4 / §5 / §6 / §11
129 lines
4.1 KiB
Go
129 lines
4.1 KiB
Go
package agentcmd
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"io"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
// AgentCheckResult is the deep-verification response for `agent check <id>`.
|
|
// Superset of AgentStatusResult: status fields + KBScopeAllReachable from
|
|
// probing each KB in agent.Config.KnowledgeBases. Verb split with
|
|
// `agent status`: status reads existing state cheaply, check actively
|
|
// verifies dependencies.
|
|
type AgentCheckResult struct {
|
|
ID string `json:"id"`
|
|
Reachable bool `json:"reachable"`
|
|
ModelID string `json:"model_id,omitempty"`
|
|
KBScopeAllReachable *bool `json:"kb_scope_all_reachable,omitempty"` // pointer so we can distinguish "not applicable" (e.g. agent unreachable) from "false"
|
|
}
|
|
|
|
// AgentCheckService is the narrow SDK surface needed for agent check.
|
|
type AgentCheckService interface {
|
|
GetAgent(ctx context.Context, id string) (*sdk.Agent, error)
|
|
GetKnowledgeBase(ctx context.Context, id string) (*sdk.KnowledgeBase, error)
|
|
}
|
|
|
|
var agentCheckFields = []string{"id", "reachable", "model_id", "kb_scope_all_reachable"}
|
|
|
|
// NewCmdCheck builds `weknora agent check <id>`.
|
|
func NewCmdCheck(f *cmdutil.Factory) *cobra.Command {
|
|
cmd := &cobra.Command{
|
|
Use: "check <agent-id>",
|
|
Short: "Verify a custom agent end-to-end (status + kb_scope reachability)",
|
|
Long: `Active verification of a custom agent.
|
|
|
|
Performs 1 + N HTTP calls:
|
|
1 GET /agents/{id} — reachable + model_id
|
|
N GET /kb/{kb_id} for each id in agent.config.knowledge_bases
|
|
— sets kb_scope_all_reachable = true iff every probe succeeds
|
|
|
|
Use 'weknora agent status <id>' for a fast read-only health snapshot
|
|
(1 HTTP call, no KB probing). Use 'agent check' when you need to verify
|
|
the agent's downstream dependencies are all reachable.`,
|
|
Example: ` weknora agent check ag_abc
|
|
weknora agent check ag_abc --format json`,
|
|
Args: cobra.ExactArgs(1),
|
|
RunE: func(c *cobra.Command, args []string) error {
|
|
fopts, err := cmdutil.CheckFormatFlag(c)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
fopts.ResolveDefault(iostreams.IO.IsStdoutTTY())
|
|
cli, err := f.Client()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
res, err := runAgentCheck(c.Context(), cli, args[0])
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return emitAgentCheck(res, fopts, iostreams.IO.Out)
|
|
},
|
|
}
|
|
cmdutil.AddFormatFlag(cmd, agentCheckFields...)
|
|
return cmd
|
|
}
|
|
|
|
// runAgentCheck is the testable core. Never errors for "agent not
|
|
// reachable" — Reachable=false carries that signal.
|
|
func runAgentCheck(ctx context.Context, svc AgentCheckService, id string) (*AgentCheckResult, error) {
|
|
a, err := svc.GetAgent(ctx, id)
|
|
if err != nil {
|
|
return &AgentCheckResult{ID: id, Reachable: false}, nil
|
|
}
|
|
res := &AgentCheckResult{ID: a.ID, Reachable: true}
|
|
if a.Config != nil {
|
|
res.ModelID = a.Config.ModelID
|
|
}
|
|
// Probe each KB in scope. Vacuously true when scope is empty or
|
|
// config is nil.
|
|
allOK := true
|
|
if a.Config != nil {
|
|
for _, kbID := range a.Config.KnowledgeBases {
|
|
if _, err := svc.GetKnowledgeBase(ctx, kbID); err != nil {
|
|
allOK = false
|
|
break
|
|
}
|
|
}
|
|
}
|
|
res.KBScopeAllReachable = &allOK
|
|
return res, nil
|
|
}
|
|
|
|
// emitAgentCheck renders res. Same dispatch as emitAgentStatus.
|
|
func emitAgentCheck(res *AgentCheckResult, fopts *cmdutil.FormatOptions, w io.Writer) error {
|
|
switch fopts.Mode {
|
|
case cmdutil.FormatJSON, cmdutil.FormatNDJSON:
|
|
return fopts.Emit(w, res, nil)
|
|
case cmdutil.FormatText, "":
|
|
return writeAgentCheckText(w, res)
|
|
default:
|
|
return fmt.Errorf("unsupported --format %q for agent check", fopts.Mode)
|
|
}
|
|
}
|
|
|
|
func writeAgentCheckText(w io.Writer, res *AgentCheckResult) error {
|
|
fmt.Fprintf(w, "ID: %s\n", res.ID)
|
|
fmt.Fprintf(w, "Reachable: %v\n", res.Reachable)
|
|
if !res.Reachable {
|
|
return nil
|
|
}
|
|
if res.ModelID != "" {
|
|
fmt.Fprintf(w, "Model: %s\n", res.ModelID)
|
|
}
|
|
if res.KBScopeAllReachable != nil {
|
|
fmt.Fprintf(w, "KB scope OK: %v\n", *res.KBScopeAllReachable)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// compile-time check: SDK client satisfies AgentCheckService.
|
|
var _ AgentCheckService = (*sdk.Client)(nil)
|