nullkey
f2e8e3f56c
Survey of 10 mainstream CLIs (gh, lark, stripe, vercel, supabase, aws, azure, gcloud, openai/codex, github-copilot-cli) showed env-gated per-command --help blurbs are a Stripe-only pattern; gh uses env detect for telemetry only, and lark relies on installed agent Skills + MCP. Our cmd/mcp/serve already covers the dominant 2025/26 path, so internal/aiclient/ (136 LOC + 38 callsites) is net maintenance burden without precedent. - Drop internal/aiclient/ entirely (annotations + detect + tests) - Remove 38 SetAgentHelp callsites + agentAwareHelpFunc / SetHelpFunc wiring in cmd/root.go - Migrate 4 command-level rules to standard Long help (visible to all, not env-gated): doc upload mode mutex, kb edit at-least-one, kb pin idempotent, search chunks channel mutex - Rewrite AGENTS.md as a developer guide (gh-style 6 H2 / 167 lines): audience preamble + Build / Architecture / Command Structure / Testing / Code Style / Error Handling. Drops sections absent in surveyed projects (Commit & PR Conventions, Who Uses This CLI) - Clean 14 internal doc refs (ADR-N, spec §X, v0.X) in source comments and docs that pointed at docs/superpowers/ — that directory is local-only / uncommitted, so refs are dead for outside readers - Drop forward-looking "once v0.2 ships" from README
55 lines
2.0 KiB
Go
55 lines
2.0 KiB
Go
package cmdutil
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"regexp"
|
|
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
// uuidPattern matches the canonical 8-4-4-4-12 UUID form. WeKnora's KB ids
|
|
// are uuid.New().String() output stored as varchar(36); names are arbitrary
|
|
// user-supplied strings, so format-detection is unambiguous.
|
|
var uuidPattern = regexp.MustCompile(`^[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}$`)
|
|
|
|
// IsKBID reports whether s looks like a KB id. Used by Factory.ResolveKB and
|
|
// any caller that accepts a single id-or-name selector value (id vs name
|
|
// auto-detection).
|
|
func IsKBID(s string) bool { return uuidPattern.MatchString(s) }
|
|
|
|
// KBLister is the narrow SDK surface ResolveKBNameToID depends on. The
|
|
// production *sdk.Client satisfies it; tests inject fakes without standing
|
|
// up an HTTP server.
|
|
type KBLister interface {
|
|
ListKnowledgeBases(ctx context.Context) ([]sdk.KnowledgeBase, error)
|
|
}
|
|
|
|
// ResolveKBFlag interprets a raw --kb value (id or name) and returns the
|
|
// canonical id. Pass-through when raw already looks like an id; otherwise
|
|
// list and match by name. Shared by every command that takes a --kb flag
|
|
// directly (search chunks/docs, doc download, link …) so the id-or-name
|
|
// policy never drifts.
|
|
func ResolveKBFlag(ctx context.Context, lister KBLister, raw string) (string, error) {
|
|
if IsKBID(raw) {
|
|
return raw, nil
|
|
}
|
|
return ResolveKBNameToID(ctx, lister, raw)
|
|
}
|
|
|
|
// ResolveKBNameToID looks up a knowledge base by name and returns its ID.
|
|
// Used by `link` and `Factory.ResolveKB` - a single lookup so the match
|
|
// policy (currently exact case-sensitive) lives in one place.
|
|
func ResolveKBNameToID(ctx context.Context, lister KBLister, name string) (string, error) {
|
|
kbs, err := lister.ListKnowledgeBases(ctx)
|
|
if err != nil {
|
|
return "", WrapHTTP(err, "list knowledge bases")
|
|
}
|
|
for _, kb := range kbs {
|
|
if kb.Name == name {
|
|
return kb.ID, nil
|
|
}
|
|
}
|
|
return "", NewError(CodeKBNotFound, fmt.Sprintf("knowledge base not found: %s", name))
|
|
}
|