2ce348d020
D1 — --format default flipped to json regardless of TTY: - v0.6: smart default (text on TTY, json on pipe). - v0.7: always json; TTY only affects indent (compact in pipe). Enum values unchanged (text | json | ndjson). - Typed FormatMode enum replaces untyped string consts. - --format / --jq promoted to persistent root flags so unknown- subcommand paths still reach the typed-envelope guard (per-command registration in v0.6 would have rejected --format on unknown commands as cobra-prose exit 2). - WEKNORA_FORMAT env var added; precedence --format > env > default. Invalid env values silently ignored. D2 — chat / session ask default to NDJSON event-stream: - New cli/internal/output/ndjson_stream.go: InitEvent struct + EmitInit / EmitSDKEvent / WriteNDJSONLine helpers. EmitInit doc encodes the must-be-first-line invariant agents key on. - chat / session ask: --format json AND --format ndjson both emit one JSON event per line (no envelope wrapping). CLI injects exactly one `init` event at stream head carrying session_id + optional kb_id / agent_id / profile. Subsequent events pass through verbatim from the SDK (passthrough discipline per spec §5.1). - --format text keeps the SSE-style live renderer. context → profile full cascade: - Command group: cli/cmd/context/ → cli/cmd/profile/ (git mv; package contextcmd → profilecmd). - Global flag --context → --profile. Factory.ContextOverride → ProfileOverride. WEKNORA_PROFILE env var honored (--profile flag > env > config.CurrentContext). When --profile or WEKNORA_PROFILE references a missing profile, the error is input.invalid_argument with hint "weknora profile list" — not the destructive local.config_corrupt path (which would have told users to delete their config file). - Binding file .weknora/project.yaml field context: → profile: (no backwards-compat alias; re-run weknora link). - profile use JSON fields current_context / previous_context → current_profile / previous_profile. - weknora link JSON field context → profile. - CodeLocalContextNotFound → CodeLocalProfileNotFound (typed code rename). - Envelope top-level profile field populated via globalProfile (set by root PersistentPreRunE from Factory.ActiveProfile). chat / session ask NDJSON init event carries the same profile. - Rationale: "context" collided with LLM context window / RAG context / Go context.Context; mainstream multi-credential CLIs (AWS / Stripe / OpenAI / Anthropic / lark) all use "profile". H2/C1' help calibration: - AgentHelp gains Warnings []string; single SetAgentHelp helper routes on WEKNORA_AGENT_HELP=1 (emits JSON blob including warnings) vs human help (appends "AI agents:" block from same source). Warnings surface as both a structured JSON field and visible help-text addendum without drift. - 9 destructive commands carry warnings: kb / doc / agent / session / chunk delete; profile remove; kb / agent edit; auth logout. - weknora doc wait dedups ids at entry; SIGINT mid-wait returns silently (root signal handler maps to exit 130) instead of being miscategorised as operation.timeout / operation.failed. A4 — docs: - cli/AGENTS.md gains four agent-facing sections: Wire contract for AI agents (stdout / stderr / NDJSON / _notice evolution / SDK contract boundary); Deliberate deviations + mainstream alignments; Pre-1.0 breaking policy; Exit-10 anti-patterns. ERROR_REFERENCE table extended. - cli/README.md adds Agent quick start under Wire contract. - cli/CHANGELOG.md v0.7 section: BREAKING entries with migration notes, Added (WEKNORA_FORMAT / WEKNORA_PROFILE / retry_command / retry_after_seconds / risk / _notice reserved infra / meta.count / meta.has_more / doc fetch / doc create / session ask / doc delete --all / NDJSON init), Changed (docs additions), Deprecated (none — pre-release one-shot breaking). Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3 / §4 / §5 / §6 / §11
106 lines
3.7 KiB
Go
106 lines
3.7 KiB
Go
package chunkcmd
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
type fakeViewSvc struct {
|
|
resp *sdk.Chunk
|
|
err error
|
|
}
|
|
|
|
func (f *fakeViewSvc) GetChunkByIDOnly(_ context.Context, _ string) (*sdk.Chunk, error) {
|
|
return f.resp, f.err
|
|
}
|
|
|
|
func TestView_Happy_RendersAllFields(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeViewSvc{resp: &sdk.Chunk{
|
|
ID: "c1",
|
|
SeqID: 42,
|
|
ChunkIndex: 0,
|
|
KnowledgeID: "doc_abc",
|
|
KnowledgeBaseID: "kb_abc",
|
|
ChunkType: "text",
|
|
IsEnabled: true,
|
|
Content: "the quick brown fox",
|
|
CreatedAt: "2026-05-15T11:00:00Z",
|
|
UpdatedAt: "2026-05-15T12:00:00Z",
|
|
}}
|
|
require.NoError(t, runView(context.Background(), &ViewOptions{ChunkID: "c1"}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, svc))
|
|
body := out.String()
|
|
assert.Contains(t, body, "c1")
|
|
assert.Contains(t, body, "doc_abc")
|
|
assert.Contains(t, body, "kb_abc")
|
|
assert.Contains(t, body, "text")
|
|
assert.Contains(t, body, "the quick brown fox", "content must render in full")
|
|
}
|
|
|
|
func TestView_HumanLabels_DocAndKB(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeViewSvc{resp: &sdk.Chunk{
|
|
ID: "c1", KnowledgeID: "doc_abc", KnowledgeBaseID: "kb_abc",
|
|
}}
|
|
require.NoError(t, runView(context.Background(), &ViewOptions{ChunkID: "c1"}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, svc))
|
|
body := out.String()
|
|
// Text KV uses friendlier DOC_ID / KB_ID labels (the SDK's
|
|
// knowledge_id / knowledge_base_id are kept only in --format json output).
|
|
assert.Contains(t, body, "doc_id")
|
|
assert.Contains(t, body, "kb_id")
|
|
assert.NotContains(t, body, "knowledge_id")
|
|
assert.NotContains(t, body, "knowledge_base_id")
|
|
}
|
|
|
|
func TestView_OmitsZeroOrEmpty(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeViewSvc{resp: &sdk.Chunk{ID: "c_min", Content: "x"}}
|
|
require.NoError(t, runView(context.Background(), &ViewOptions{ChunkID: "c_min"}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, svc))
|
|
body := out.String()
|
|
// status / start_at / end_at all zero → must be omitted from the human KV.
|
|
assert.NotContains(t, body, "status:")
|
|
assert.NotContains(t, body, "start_at:")
|
|
assert.NotContains(t, body, "end_at:")
|
|
// tag_id / image_info empty → omitted.
|
|
assert.NotContains(t, body, "tag_id:")
|
|
assert.NotContains(t, body, "image_info:")
|
|
}
|
|
|
|
func TestView_JSON_BareSDKShape(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeViewSvc{resp: &sdk.Chunk{
|
|
ID: "c_json", KnowledgeID: "doc_abc", KnowledgeBaseID: "kb_abc",
|
|
}}
|
|
require.NoError(t, runView(context.Background(), &ViewOptions{ChunkID: "c_json"}, &cmdutil.FormatOptions{Mode: cmdutil.FormatJSON}, svc))
|
|
var env struct {
|
|
OK bool `json:"ok"`
|
|
Data sdk.Chunk `json:"data"`
|
|
}
|
|
require.NoError(t, json.Unmarshal(out.Bytes(), &env))
|
|
got := env.Data
|
|
assert.Equal(t, "c_json", got.ID)
|
|
assert.Equal(t, "doc_abc", got.KnowledgeID)
|
|
// JSON uses SDK snake_case keys (knowledge_id), not text relabel doc_id.
|
|
assert.Contains(t, out.String(), `"knowledge_id":"doc_abc"`)
|
|
assert.Contains(t, out.String(), `"knowledge_base_id":"kb_abc"`)
|
|
assert.NotContains(t, out.String(), `"doc_id"`)
|
|
assert.NotContains(t, out.String(), `"kb_id"`)
|
|
}
|
|
|
|
func TestView_404(t *testing.T) {
|
|
_, _ = iostreams.SetForTest(t)
|
|
svc := &fakeViewSvc{err: errors.New("HTTP error 404: not found")}
|
|
err := runView(context.Background(), &ViewOptions{ChunkID: "missing"}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, svc)
|
|
require.Error(t, err)
|
|
assert.Contains(t, err.Error(), "resource.not_found")
|
|
}
|