1b20b06f5e
Output ergonomics:
- `--json` accepts a comma-separated field list (gh-parity); selects
named keys from the per-command payload. Bare `--json` keeps the
full shape.
- `--jq <expr>` evaluates a gojq expression over the JSON; pairs with
`--json field-list` so projection runs before jq.
- `--version` is a global cobra flag in addition to the `version`
subcommand; both render the same line.
- Per-command `--help` now renders the available JSON field list under
"JSON fields available via `--json id,name,...`" (field-discovery
parity with gh / kubectl `-o jsonpath`).
New commands:
- `auth token` — print the active context's credential to stdout for
shell command substitution (`WEKNORA_TOKEN=$(weknora auth token)`).
Default: raw secret, no trailing newline. `--json` emits
`{token, mode, context}`.
- `doc upload --from-url <URL>` — ingest a remote URL via the SDK
`CreateKnowledgeFromURL`. `--name` forwarded as `FileName` so the
server's known-extension heuristic upgrades crawl-mode to
file-download-mode where appropriate.
Includes the simplify post-review polish pass (field-filter unit
tests, --json/--jq compose check, agent_help copy fixes).
117 lines
3.9 KiB
Go
117 lines
3.9 KiB
Go
package kb
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
// fakePinSvc satisfies PinService: GetKnowledgeBase + TogglePinKnowledgeBase.
|
|
type fakePinSvc struct {
|
|
current sdk.KnowledgeBase
|
|
getErr error
|
|
toggleErr error
|
|
toggleCalled bool
|
|
}
|
|
|
|
func (f *fakePinSvc) GetKnowledgeBase(_ context.Context, id string) (*sdk.KnowledgeBase, error) {
|
|
if f.getErr != nil {
|
|
return nil, f.getErr
|
|
}
|
|
c := f.current
|
|
c.ID = id
|
|
return &c, nil
|
|
}
|
|
|
|
func (f *fakePinSvc) TogglePinKnowledgeBase(_ context.Context, id string) (*sdk.KnowledgeBase, error) {
|
|
f.toggleCalled = true
|
|
if f.toggleErr != nil {
|
|
return nil, f.toggleErr
|
|
}
|
|
c := f.current
|
|
c.ID = id
|
|
c.IsPinned = !c.IsPinned
|
|
return &c, nil
|
|
}
|
|
|
|
func TestPin_UnpinnedToPinned_CallsToggle(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakePinSvc{current: sdk.KnowledgeBase{IsPinned: false}}
|
|
require.NoError(t, runPin(context.Background(), &PinOptions{}, nil, svc, "kb_abc", true))
|
|
assert.True(t, svc.toggleCalled, "must call toggle when current state differs")
|
|
assert.Contains(t, out.String(), "kb_abc")
|
|
}
|
|
|
|
func TestPin_AlreadyPinned_NoOp(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakePinSvc{current: sdk.KnowledgeBase{IsPinned: true}}
|
|
require.NoError(t, runPin(context.Background(), &PinOptions{}, nil, svc, "kb_abc", true))
|
|
assert.False(t, svc.toggleCalled, "already pinned ⇒ must not call toggle")
|
|
assert.Contains(t, out.String(), "already pinned")
|
|
}
|
|
|
|
func TestUnpin_PinnedToUnpinned_CallsToggle(t *testing.T) {
|
|
_, _ = iostreams.SetForTest(t)
|
|
svc := &fakePinSvc{current: sdk.KnowledgeBase{IsPinned: true}}
|
|
require.NoError(t, runPin(context.Background(), &PinOptions{}, nil, svc, "kb_abc", false))
|
|
assert.True(t, svc.toggleCalled)
|
|
}
|
|
|
|
func TestUnpin_AlreadyUnpinned_NoOp(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakePinSvc{current: sdk.KnowledgeBase{IsPinned: false}}
|
|
require.NoError(t, runPin(context.Background(), &PinOptions{}, nil, svc, "kb_abc", false))
|
|
assert.False(t, svc.toggleCalled, "already unpinned ⇒ must not call toggle")
|
|
assert.Contains(t, out.String(), "already unpinned")
|
|
}
|
|
|
|
func TestPin_NotFound(t *testing.T) {
|
|
_, _ = iostreams.SetForTest(t)
|
|
svc := &fakePinSvc{getErr: errors.New("HTTP error 404: not found")}
|
|
err := runPin(context.Background(), &PinOptions{}, nil, svc, "kb_missing", true)
|
|
require.Error(t, err)
|
|
var typed *cmdutil.Error
|
|
require.ErrorAs(t, err, &typed)
|
|
assert.Equal(t, cmdutil.CodeResourceNotFound, typed.Code)
|
|
assert.False(t, svc.toggleCalled)
|
|
}
|
|
|
|
func TestPin_ToggleError(t *testing.T) {
|
|
_, _ = iostreams.SetForTest(t)
|
|
svc := &fakePinSvc{
|
|
current: sdk.KnowledgeBase{IsPinned: false},
|
|
toggleErr: errors.New("HTTP error 500: internal"),
|
|
}
|
|
err := runPin(context.Background(), &PinOptions{}, nil, svc, "kb_abc", true)
|
|
require.Error(t, err)
|
|
var typed *cmdutil.Error
|
|
require.ErrorAs(t, err, &typed)
|
|
assert.Equal(t, cmdutil.CodeServerError, typed.Code)
|
|
}
|
|
|
|
func TestPin_DryRun_StateDiffers(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakePinSvc{current: sdk.KnowledgeBase{IsPinned: false}}
|
|
require.NoError(t, runPin(context.Background(), &PinOptions{DryRun: true}, &cmdutil.JSONOptions{}, svc, "kb_abc", true))
|
|
assert.False(t, svc.toggleCalled, "dry-run must not call toggle")
|
|
body := out.String()
|
|
assert.Contains(t, body, `"dry_run":true`)
|
|
assert.Contains(t, body, `"write"`)
|
|
}
|
|
|
|
func TestPin_JSON(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakePinSvc{current: sdk.KnowledgeBase{IsPinned: false}}
|
|
require.NoError(t, runPin(context.Background(), &PinOptions{}, &cmdutil.JSONOptions{}, svc, "kb_abc", true))
|
|
body := out.String()
|
|
assert.Contains(t, body, `"is_pinned":true`)
|
|
assert.Contains(t, body, `"id":"kb_abc"`)
|
|
}
|