1b20b06f5e
Output ergonomics:
- `--json` accepts a comma-separated field list (gh-parity); selects
named keys from the per-command payload. Bare `--json` keeps the
full shape.
- `--jq <expr>` evaluates a gojq expression over the JSON; pairs with
`--json field-list` so projection runs before jq.
- `--version` is a global cobra flag in addition to the `version`
subcommand; both render the same line.
- Per-command `--help` now renders the available JSON field list under
"JSON fields available via `--json id,name,...`" (field-discovery
parity with gh / kubectl `-o jsonpath`).
New commands:
- `auth token` — print the active context's credential to stdout for
shell command substitution (`WEKNORA_TOKEN=$(weknora auth token)`).
Default: raw secret, no trailing newline. `--json` emits
`{token, mode, context}`.
- `doc upload --from-url <URL>` — ingest a remote URL via the SDK
`CreateKnowledgeFromURL`. `--name` forwarded as `FileName` so the
server's known-extension heuristic upgrades crawl-mode to
file-download-mode where appropriate.
Includes the simplify post-review polish pass (field-filter unit
tests, --json/--jq compose check, agent_help copy fixes).
121 lines
4.0 KiB
Go
121 lines
4.0 KiB
Go
package kb
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/agent"
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/format"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
// kbPinFields enumerates the fields surfaced for `--json` discovery on
|
|
// `kb pin` / `kb unpin`. The toggle result is the KnowledgeBase; the user-
|
|
// relevant fields here are the id and the new pin state.
|
|
var kbPinFields = []string{"id", "is_pinned"}
|
|
|
|
type PinOptions struct {
|
|
DryRun bool
|
|
}
|
|
|
|
// PinService is the narrow SDK surface this command depends on. The CLI
|
|
// reads current state before toggling so `pin`/`unpin` are idempotent —
|
|
// the server endpoint is only a non-idempotent toggle.
|
|
type PinService interface {
|
|
GetKnowledgeBase(ctx context.Context, id string) (*sdk.KnowledgeBase, error)
|
|
TogglePinKnowledgeBase(ctx context.Context, id string) (*sdk.KnowledgeBase, error)
|
|
}
|
|
|
|
// NewCmdPin builds `weknora kb pin <id>`.
|
|
func NewCmdPin(f *cmdutil.Factory) *cobra.Command {
|
|
return newPinCmd(f, "pin", true, "Pin a knowledge base to the top of the list")
|
|
}
|
|
|
|
// NewCmdUnpin builds `weknora kb unpin <id>`.
|
|
func NewCmdUnpin(f *cmdutil.Factory) *cobra.Command {
|
|
return newPinCmd(f, "unpin", false, "Unpin a knowledge base")
|
|
}
|
|
|
|
func newPinCmd(f *cmdutil.Factory, use string, want bool, short string) *cobra.Command {
|
|
opts := &PinOptions{}
|
|
cmd := &cobra.Command{
|
|
Use: use + " <id>",
|
|
Short: short,
|
|
Args: cobra.ExactArgs(1),
|
|
RunE: func(c *cobra.Command, args []string) error {
|
|
jopts, err := cmdutil.CheckJSONFlags(c)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
opts.DryRun = cmdutil.IsDryRun(c)
|
|
if opts.DryRun {
|
|
return runPin(c.Context(), opts, jopts, nil, args[0], want)
|
|
}
|
|
cli, err := f.Client()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return runPin(c.Context(), opts, jopts, cli, args[0], want)
|
|
},
|
|
}
|
|
cmdutil.AddJSONFlags(cmd, kbPinFields)
|
|
agent.SetAgentHelp(cmd, fmt.Sprintf("Idempotent %s: reads current pin state, toggles only if different. No-op when already in the requested state.", use))
|
|
return cmd
|
|
}
|
|
|
|
func runPin(ctx context.Context, opts *PinOptions, jopts *cmdutil.JSONOptions, svc PinService, id string, want bool) error {
|
|
verb := "pin"
|
|
if !want {
|
|
verb = "unpin"
|
|
}
|
|
risk := &format.Risk{Level: format.RiskWrite, Action: fmt.Sprintf("%s knowledge base %s", verb, id)}
|
|
|
|
if opts.DryRun {
|
|
// Dry-run can't introspect state without a network call by design (see
|
|
// kb/delete.go for the same convention). Report what *would* run if
|
|
// state diverged; agents can disambiguate via a subsequent `kb view`.
|
|
return cmdutil.EmitDryRun(jopts.Enabled(), struct {
|
|
ID string `json:"id"`
|
|
Want bool `json:"want_pinned"`
|
|
}{id, want}, &format.Meta{KBID: id}, risk)
|
|
}
|
|
|
|
current, err := svc.GetKnowledgeBase(ctx, id)
|
|
if err != nil {
|
|
return cmdutil.WrapHTTP(err, "get knowledge base %s", id)
|
|
}
|
|
if current.IsPinned == want {
|
|
state := "pinned"
|
|
if !want {
|
|
state = "unpinned"
|
|
}
|
|
// No-op path: tell agents what happened. The risk-write classification
|
|
// was the *requested* operation, not what occurred — surface it via a
|
|
// _meta.warning so audit logs don't count a write that wasn't made.
|
|
if jopts.Enabled() {
|
|
meta := &format.Meta{KBID: id, Warnings: []string{fmt.Sprintf("already %s — no server call made", state)}}
|
|
return format.WriteEnvelopeFiltered(iostreams.IO.Out, format.Success(current, meta), jopts.Fields, jopts.JQ)
|
|
}
|
|
fmt.Fprintf(iostreams.IO.Out, "✓ %s is already %s\n", id, state)
|
|
return nil
|
|
}
|
|
|
|
updated, err := svc.TogglePinKnowledgeBase(ctx, id)
|
|
if err != nil {
|
|
return cmdutil.WrapHTTP(err, "%s knowledge base %s", verb, id)
|
|
}
|
|
if jopts.Enabled() {
|
|
return format.WriteEnvelopeFiltered(iostreams.IO.Out, format.SuccessWithRisk(updated, &format.Meta{KBID: id}, risk), jopts.Fields, jopts.JQ)
|
|
}
|
|
state := "pinned"
|
|
if !updated.IsPinned {
|
|
state = "unpinned"
|
|
}
|
|
fmt.Fprintf(iostreams.IO.Out, "✓ %s %s\n", id, state)
|
|
return nil
|
|
}
|