2ce348d020
D1 — --format default flipped to json regardless of TTY: - v0.6: smart default (text on TTY, json on pipe). - v0.7: always json; TTY only affects indent (compact in pipe). Enum values unchanged (text | json | ndjson). - Typed FormatMode enum replaces untyped string consts. - --format / --jq promoted to persistent root flags so unknown- subcommand paths still reach the typed-envelope guard (per-command registration in v0.6 would have rejected --format on unknown commands as cobra-prose exit 2). - WEKNORA_FORMAT env var added; precedence --format > env > default. Invalid env values silently ignored. D2 — chat / session ask default to NDJSON event-stream: - New cli/internal/output/ndjson_stream.go: InitEvent struct + EmitInit / EmitSDKEvent / WriteNDJSONLine helpers. EmitInit doc encodes the must-be-first-line invariant agents key on. - chat / session ask: --format json AND --format ndjson both emit one JSON event per line (no envelope wrapping). CLI injects exactly one `init` event at stream head carrying session_id + optional kb_id / agent_id / profile. Subsequent events pass through verbatim from the SDK (passthrough discipline per spec §5.1). - --format text keeps the SSE-style live renderer. context → profile full cascade: - Command group: cli/cmd/context/ → cli/cmd/profile/ (git mv; package contextcmd → profilecmd). - Global flag --context → --profile. Factory.ContextOverride → ProfileOverride. WEKNORA_PROFILE env var honored (--profile flag > env > config.CurrentContext). When --profile or WEKNORA_PROFILE references a missing profile, the error is input.invalid_argument with hint "weknora profile list" — not the destructive local.config_corrupt path (which would have told users to delete their config file). - Binding file .weknora/project.yaml field context: → profile: (no backwards-compat alias; re-run weknora link). - profile use JSON fields current_context / previous_context → current_profile / previous_profile. - weknora link JSON field context → profile. - CodeLocalContextNotFound → CodeLocalProfileNotFound (typed code rename). - Envelope top-level profile field populated via globalProfile (set by root PersistentPreRunE from Factory.ActiveProfile). chat / session ask NDJSON init event carries the same profile. - Rationale: "context" collided with LLM context window / RAG context / Go context.Context; mainstream multi-credential CLIs (AWS / Stripe / OpenAI / Anthropic / lark) all use "profile". H2/C1' help calibration: - AgentHelp gains Warnings []string; single SetAgentHelp helper routes on WEKNORA_AGENT_HELP=1 (emits JSON blob including warnings) vs human help (appends "AI agents:" block from same source). Warnings surface as both a structured JSON field and visible help-text addendum without drift. - 9 destructive commands carry warnings: kb / doc / agent / session / chunk delete; profile remove; kb / agent edit; auth logout. - weknora doc wait dedups ids at entry; SIGINT mid-wait returns silently (root signal handler maps to exit 130) instead of being miscategorised as operation.timeout / operation.failed. A4 — docs: - cli/AGENTS.md gains four agent-facing sections: Wire contract for AI agents (stdout / stderr / NDJSON / _notice evolution / SDK contract boundary); Deliberate deviations + mainstream alignments; Pre-1.0 breaking policy; Exit-10 anti-patterns. ERROR_REFERENCE table extended. - cli/README.md adds Agent quick start under Wire contract. - cli/CHANGELOG.md v0.7 section: BREAKING entries with migration notes, Added (WEKNORA_FORMAT / WEKNORA_PROFILE / retry_command / retry_after_seconds / risk / _notice reserved infra / meta.count / meta.has_more / doc fetch / doc create / session ask / doc delete --all / NDJSON init), Changed (docs additions), Deprecated (none — pre-release one-shot breaking). Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3 / §4 / §5 / §6 / §11
176 lines
6.1 KiB
Go
176 lines
6.1 KiB
Go
package kb
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
type fakeGetSvc struct {
|
|
kb *sdk.KnowledgeBase
|
|
err error
|
|
}
|
|
|
|
func (f *fakeGetSvc) GetKnowledgeBase(ctx context.Context, id string) (*sdk.KnowledgeBase, error) {
|
|
return f.kb, f.err
|
|
}
|
|
|
|
func TestGet_OK_Text(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeGetSvc{kb: &sdk.KnowledgeBase{
|
|
ID: "kb1", Name: "Marketing", KnowledgeCount: 12, ChunkCount: 245,
|
|
}}
|
|
if err := runView(context.Background(), &ViewOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, svc, "kb1"); err != nil {
|
|
t.Fatalf("runGet: %v", err)
|
|
}
|
|
got := out.String()
|
|
for _, want := range []string{"ID:", "kb1", "NAME:", "Marketing", "DOCS:", "12 docs", "CHUNKS:", "245 chunks"} {
|
|
if !strings.Contains(got, want) {
|
|
t.Errorf("missing %q in:\n%s", want, got)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestGet_OK_JSON(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeGetSvc{kb: &sdk.KnowledgeBase{ID: "kb1", Name: "Marketing"}}
|
|
if err := runView(context.Background(), &ViewOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatJSON}, svc, "kb1"); err != nil {
|
|
t.Fatalf("runGet: %v", err)
|
|
}
|
|
got := out.String()
|
|
var env struct {
|
|
OK bool `json:"ok"`
|
|
Data sdk.KnowledgeBase `json:"data"`
|
|
}
|
|
if err := json.Unmarshal([]byte(got), &env); err != nil {
|
|
t.Fatalf("parse: %v\n%s", err, got)
|
|
}
|
|
if !env.OK {
|
|
t.Errorf("envelope.ok must be true, got %q", got)
|
|
}
|
|
if env.Data.ID != "kb1" {
|
|
t.Errorf("expected id=kb1 in envelope.data, got %q", env.Data.ID)
|
|
}
|
|
}
|
|
|
|
func TestGet_NotFound(t *testing.T) {
|
|
_, _ = iostreams.SetForTest(t)
|
|
svc := &fakeGetSvc{err: errors.New("HTTP error 404: not found")}
|
|
err := runView(context.Background(), &ViewOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, svc, "missing")
|
|
if err == nil {
|
|
t.Fatal("expected error")
|
|
}
|
|
if !cmdutil.IsNotFound(err) {
|
|
t.Errorf("expected resource.not_found, got %v", err)
|
|
}
|
|
}
|
|
|
|
// --- expanded text render: badges + extra KV lines ---
|
|
|
|
func TestView_Pinned_RendersPinnedLine(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeGetSvc{kb: &sdk.KnowledgeBase{ID: "kb1", Name: "Pinned", IsPinned: true}}
|
|
if err := runView(context.Background(), &ViewOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, svc, "kb1"); err != nil {
|
|
t.Fatalf("runView: %v", err)
|
|
}
|
|
if !strings.Contains(out.String(), "PINNED:") {
|
|
t.Errorf("expected PINNED line for IsPinned=true:\n%s", out.String())
|
|
}
|
|
}
|
|
|
|
func TestView_NotPinned_OmitsPinnedLine(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeGetSvc{kb: &sdk.KnowledgeBase{ID: "kb1", Name: "Plain", IsPinned: false}}
|
|
if err := runView(context.Background(), &ViewOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, svc, "kb1"); err != nil {
|
|
t.Fatalf("runView: %v", err)
|
|
}
|
|
for _, l := range strings.Split(out.String(), "\n") {
|
|
if strings.HasPrefix(l, "PINNED:") {
|
|
t.Errorf("PINNED line should be omitted when IsPinned=false: %q", l)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestView_Temporary_RendersTempLine(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeGetSvc{kb: &sdk.KnowledgeBase{ID: "kb_t", Name: "Tmp", IsTemporary: true}}
|
|
if err := runView(context.Background(), &ViewOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, svc, "kb_t"); err != nil {
|
|
t.Fatalf("runView: %v", err)
|
|
}
|
|
if !strings.Contains(out.String(), "TEMPORARY:") {
|
|
t.Errorf("expected TEMPORARY line:\n%s", out.String())
|
|
}
|
|
}
|
|
|
|
func TestView_SummaryModel(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeGetSvc{kb: &sdk.KnowledgeBase{ID: "kb1", Name: "X", SummaryModelID: "summary-model-x"}}
|
|
if err := runView(context.Background(), &ViewOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, svc, "kb1"); err != nil {
|
|
t.Fatalf("runView: %v", err)
|
|
}
|
|
got := out.String()
|
|
if !strings.Contains(got, "SUMMARY MODEL:") || !strings.Contains(got, "summary-model-x") {
|
|
t.Errorf("expected SUMMARY MODEL line:\n%s", got)
|
|
}
|
|
}
|
|
|
|
func TestView_TypeAndSource(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeGetSvc{kb: &sdk.KnowledgeBase{ID: "kb1", Name: "X", Type: "general", Description: "d"}}
|
|
if err := runView(context.Background(), &ViewOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, svc, "kb1"); err != nil {
|
|
t.Fatalf("runView: %v", err)
|
|
}
|
|
got := out.String()
|
|
if !strings.Contains(got, "TYPE:") || !strings.Contains(got, "general") {
|
|
t.Errorf("expected TYPE line for non-empty Type:\n%s", got)
|
|
}
|
|
}
|
|
|
|
func TestView_Processing(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeGetSvc{kb: &sdk.KnowledgeBase{ID: "kb_p", Name: "Busy", IsProcessing: true, ProcessingCount: 3}}
|
|
if err := runView(context.Background(), &ViewOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, svc, "kb_p"); err != nil {
|
|
t.Fatalf("runView: %v", err)
|
|
}
|
|
got := out.String()
|
|
if !strings.Contains(got, "PROCESSING:") || !strings.Contains(got, "3") {
|
|
t.Errorf("expected PROCESSING line with count:\n%s", got)
|
|
}
|
|
}
|
|
|
|
func TestView_NotProcessing_OmitsProcessingLine(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeGetSvc{kb: &sdk.KnowledgeBase{ID: "kb_idle", Name: "Idle", IsProcessing: false}}
|
|
if err := runView(context.Background(), &ViewOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, svc, "kb_idle"); err != nil {
|
|
t.Fatalf("runView: %v", err)
|
|
}
|
|
for _, l := range strings.Split(out.String(), "\n") {
|
|
if strings.HasPrefix(l, "PROCESSING:") {
|
|
t.Errorf("PROCESSING line should be omitted: %q", l)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestView_CreatedAt_AlwaysRendered(t *testing.T) {
|
|
out, _ := iostreams.SetForTest(t)
|
|
svc := &fakeGetSvc{kb: &sdk.KnowledgeBase{
|
|
ID: "kb1", Name: "X",
|
|
CreatedAt: time.Date(2026, 1, 1, 0, 0, 0, 0, time.UTC),
|
|
UpdatedAt: time.Date(2026, 1, 2, 0, 0, 0, 0, time.UTC),
|
|
}}
|
|
if err := runView(context.Background(), &ViewOptions{}, &cmdutil.FormatOptions{Mode: cmdutil.FormatText}, svc, "kb1"); err != nil {
|
|
t.Fatalf("runView: %v", err)
|
|
}
|
|
got := out.String()
|
|
if !strings.Contains(got, "CREATED:") || !strings.Contains(got, "2026-01-01") {
|
|
t.Errorf("expected CREATED line:\n%s", got)
|
|
}
|
|
}
|