2ce348d020
D1 — --format default flipped to json regardless of TTY: - v0.6: smart default (text on TTY, json on pipe). - v0.7: always json; TTY only affects indent (compact in pipe). Enum values unchanged (text | json | ndjson). - Typed FormatMode enum replaces untyped string consts. - --format / --jq promoted to persistent root flags so unknown- subcommand paths still reach the typed-envelope guard (per-command registration in v0.6 would have rejected --format on unknown commands as cobra-prose exit 2). - WEKNORA_FORMAT env var added; precedence --format > env > default. Invalid env values silently ignored. D2 — chat / session ask default to NDJSON event-stream: - New cli/internal/output/ndjson_stream.go: InitEvent struct + EmitInit / EmitSDKEvent / WriteNDJSONLine helpers. EmitInit doc encodes the must-be-first-line invariant agents key on. - chat / session ask: --format json AND --format ndjson both emit one JSON event per line (no envelope wrapping). CLI injects exactly one `init` event at stream head carrying session_id + optional kb_id / agent_id / profile. Subsequent events pass through verbatim from the SDK (passthrough discipline per spec §5.1). - --format text keeps the SSE-style live renderer. context → profile full cascade: - Command group: cli/cmd/context/ → cli/cmd/profile/ (git mv; package contextcmd → profilecmd). - Global flag --context → --profile. Factory.ContextOverride → ProfileOverride. WEKNORA_PROFILE env var honored (--profile flag > env > config.CurrentContext). When --profile or WEKNORA_PROFILE references a missing profile, the error is input.invalid_argument with hint "weknora profile list" — not the destructive local.config_corrupt path (which would have told users to delete their config file). - Binding file .weknora/project.yaml field context: → profile: (no backwards-compat alias; re-run weknora link). - profile use JSON fields current_context / previous_context → current_profile / previous_profile. - weknora link JSON field context → profile. - CodeLocalContextNotFound → CodeLocalProfileNotFound (typed code rename). - Envelope top-level profile field populated via globalProfile (set by root PersistentPreRunE from Factory.ActiveProfile). chat / session ask NDJSON init event carries the same profile. - Rationale: "context" collided with LLM context window / RAG context / Go context.Context; mainstream multi-credential CLIs (AWS / Stripe / OpenAI / Anthropic / lark) all use "profile". H2/C1' help calibration: - AgentHelp gains Warnings []string; single SetAgentHelp helper routes on WEKNORA_AGENT_HELP=1 (emits JSON blob including warnings) vs human help (appends "AI agents:" block from same source). Warnings surface as both a structured JSON field and visible help-text addendum without drift. - 9 destructive commands carry warnings: kb / doc / agent / session / chunk delete; profile remove; kb / agent edit; auth logout. - weknora doc wait dedups ids at entry; SIGINT mid-wait returns silently (root signal handler maps to exit 130) instead of being miscategorised as operation.timeout / operation.failed. A4 — docs: - cli/AGENTS.md gains four agent-facing sections: Wire contract for AI agents (stdout / stderr / NDJSON / _notice evolution / SDK contract boundary); Deliberate deviations + mainstream alignments; Pre-1.0 breaking policy; Exit-10 anti-patterns. ERROR_REFERENCE table extended. - cli/README.md adds Agent quick start under Wire contract. - cli/CHANGELOG.md v0.7 section: BREAKING entries with migration notes, Added (WEKNORA_FORMAT / WEKNORA_PROFILE / retry_command / retry_after_seconds / risk / _notice reserved infra / meta.count / meta.has_more / doc fetch / doc create / session ask / doc delete --all / NDJSON init), Changed (docs additions), Deprecated (none — pre-release one-shot breaking). Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3 / §4 / §5 / §6 / §11
133 lines
3.6 KiB
Go
133 lines
3.6 KiB
Go
package kb
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
type fakeCheckSvc struct {
|
|
kb *sdk.KnowledgeBase
|
|
getErr error
|
|
failedDocs []sdk.Knowledge // returned by ListKnowledgeWithFilter when ParseStatus=failed
|
|
listErr error
|
|
}
|
|
|
|
func (f *fakeCheckSvc) GetKnowledgeBase(_ context.Context, id string) (*sdk.KnowledgeBase, error) {
|
|
if f.getErr != nil {
|
|
return nil, f.getErr
|
|
}
|
|
return f.kb, nil
|
|
}
|
|
|
|
func (f *fakeCheckSvc) ListKnowledgeWithFilter(_ context.Context, _ string, page, pageSize int, _ sdk.KnowledgeListFilter) ([]sdk.Knowledge, int64, error) {
|
|
if f.listErr != nil {
|
|
return nil, 0, f.listErr
|
|
}
|
|
// Single-page fake: return all docs at once (page 1), empty thereafter.
|
|
if page == 1 {
|
|
return f.failedDocs, int64(len(f.failedDocs)), nil
|
|
}
|
|
return nil, int64(len(f.failedDocs)), nil
|
|
}
|
|
|
|
func TestRunCheck_AggregatesFailed(t *testing.T) {
|
|
svc := &fakeCheckSvc{
|
|
kb: &sdk.KnowledgeBase{ID: "kb_x", KnowledgeCount: 5, ChunkCount: 20},
|
|
failedDocs: []sdk.Knowledge{
|
|
{ID: "d1", ParseStatus: "failed"},
|
|
{ID: "d2", ParseStatus: "failed"},
|
|
},
|
|
}
|
|
res, err := runCheck(context.Background(), svc, "kb_x")
|
|
if err != nil {
|
|
t.Fatalf("runCheck: %v", err)
|
|
}
|
|
if res.FailedCount != 2 {
|
|
t.Errorf("FailedCount=%d, want 2", res.FailedCount)
|
|
}
|
|
if !res.Reachable {
|
|
t.Error("Reachable=false, want true")
|
|
}
|
|
if res.KnowledgeCount != 5 || res.ChunkCount != 20 {
|
|
t.Errorf("got %+v", res)
|
|
}
|
|
}
|
|
|
|
func TestRunCheck_Unreachable(t *testing.T) {
|
|
svc := &fakeCheckSvc{getErr: fmt.Errorf("404 not found")}
|
|
res, err := runCheck(context.Background(), svc, "kb_x")
|
|
if err != nil {
|
|
t.Fatalf("runCheck should not return err on unreachable; got %v", err)
|
|
}
|
|
if res.Reachable {
|
|
t.Error("Reachable=true, want false")
|
|
}
|
|
if res.ID != "kb_x" {
|
|
t.Errorf("ID=%q, want kb_x (echoed even when unreachable)", res.ID)
|
|
}
|
|
}
|
|
|
|
func TestRunCheck_NoFailedDocs(t *testing.T) {
|
|
svc := &fakeCheckSvc{
|
|
kb: &sdk.KnowledgeBase{ID: "kb_y", KnowledgeCount: 10},
|
|
failedDocs: nil,
|
|
}
|
|
res, err := runCheck(context.Background(), svc, "kb_y")
|
|
if err != nil {
|
|
t.Fatalf("runCheck: %v", err)
|
|
}
|
|
if res.FailedCount != 0 {
|
|
t.Errorf("FailedCount=%d, want 0", res.FailedCount)
|
|
}
|
|
}
|
|
|
|
func TestEmitCheck_JSON(t *testing.T) {
|
|
var buf bytes.Buffer
|
|
res := &CheckResult{ID: "kb_x", Reachable: true, KnowledgeCount: 5, FailedCount: 3}
|
|
fopts := &cmdutil.FormatOptions{Mode: cmdutil.FormatJSON}
|
|
if err := emitCheck(res, fopts, &buf); err != nil {
|
|
t.Fatalf("emitCheck: %v", err)
|
|
}
|
|
var env struct {
|
|
OK bool `json:"ok"`
|
|
Data CheckResult `json:"data"`
|
|
}
|
|
if err := json.Unmarshal(buf.Bytes(), &env); err != nil {
|
|
t.Fatalf("not JSON: %v\n%s", err, buf.String())
|
|
}
|
|
got := env.Data
|
|
if got.ID != "kb_x" || got.KnowledgeCount != 5 || got.FailedCount != 3 {
|
|
t.Errorf("got %+v", got)
|
|
}
|
|
}
|
|
|
|
func TestEmitCheck_Text(t *testing.T) {
|
|
var buf bytes.Buffer
|
|
res := &CheckResult{
|
|
ID: "kb_x", Reachable: true,
|
|
KnowledgeCount: 5, ChunkCount: 20,
|
|
IsProcessing: true, ProcessingCount: 1,
|
|
FailedCount: 2,
|
|
}
|
|
fopts := &cmdutil.FormatOptions{Mode: cmdutil.FormatText}
|
|
if err := emitCheck(res, fopts, &buf); err != nil {
|
|
t.Fatalf("emitCheck: %v", err)
|
|
}
|
|
for _, want := range []string{"kb_x", "5", "20", "true", "2"} {
|
|
if !strings.Contains(buf.String(), want) {
|
|
t.Errorf("output missing %q:\n%s", want, buf.String())
|
|
}
|
|
}
|
|
// "Failed:" line must always appear for check
|
|
if !strings.Contains(buf.String(), "Failed:") {
|
|
t.Errorf("output missing 'Failed:' line:\n%s", buf.String())
|
|
}
|
|
}
|