Files
nullkey 16f11380ee feat(cli): keyring backend + TTY prompter (PR-3)
Adds the OS keyring secret backend and the huh-based TTY Prompter so
PR-4 (auth login) can persist credentials and read interactive input.
The Factory's Client closure SDK wiring + Secrets closure landed in
PR-1's foundation tree to keep PR-1 self-contained.

internal/secrets/keyring.go:
- KeyringStore: zalando/go-keyring backed; namespace "weknora:<context>".
  KeyringStore.Ref -> keychain://weknora/<context>/<key>
- NewBestEffortStore probes the OS keyring with a sentinel get and falls
  back to FileStore on unsupported platforms (WSL without DBus, etc.)

internal/prompt/tty.go:
- TTYPrompter: huh.NewForm / huh.NewInput / huh.NewConfirm wrapper
  satisfying Prompter. Used when iostreams.IO reports both stdout and
  stderr are TTYs.

Dependencies (zalando/go-keyring, charmbracelet/huh) are declared in
PR-1's go.mod since the foundation tree referenced them via the Store
interface and TTY-detection helpers.
2026-05-07 23:19:46 +08:00

68 lines
1.8 KiB
Go

package secrets
import (
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/zalando/go-keyring"
)
// Use the in-memory keyring backend for deterministic tests.
//
// go-keyring exposes MockInit so tests don't need a real OS keychain.
func TestKeyringStore_RoundTrip(t *testing.T) {
keyring.MockInit()
t.Cleanup(func() {
// Reset the mock so other test packages don't see leaked state.
keyring.MockInit()
})
k := NewKeyringStore()
// Get on missing returns ErrNotFound.
_, err := k.Get("prod", "access")
require.ErrorIs(t, err, ErrNotFound)
// Set + Get.
require.NoError(t, k.Set("prod", "access", "jwt-x"))
got, err := k.Get("prod", "access")
require.NoError(t, err)
assert.Equal(t, "jwt-x", got)
// Delete + Get.
require.NoError(t, k.Delete("prod", "access"))
_, err = k.Get("prod", "access")
require.ErrorIs(t, err, ErrNotFound)
// Delete on missing is a no-op.
require.NoError(t, k.Delete("prod", "access"))
}
func TestKeyringStore_NamespaceIsolation(t *testing.T) {
keyring.MockInit()
t.Cleanup(func() { keyring.MockInit() })
k := NewKeyringStore()
require.NoError(t, k.Set("prod", "access", "P"))
require.NoError(t, k.Set("staging", "access", "S"))
got, _ := k.Get("prod", "access")
assert.Equal(t, "P", got)
got, _ = k.Get("staging", "access")
assert.Equal(t, "S", got)
}
func TestNewBestEffortStore(t *testing.T) {
keyring.MockInit() // mock backend "supports" keyring → returns KeyringStore
t.Cleanup(func() { keyring.MockInit() })
s, err := NewBestEffortStore()
require.NoError(t, err)
_, ok := s.(*KeyringStore)
assert.True(t, ok, "with mock keyring backend, BestEffort must return KeyringStore")
}
func TestKeyringStore_Ref(t *testing.T) {
k := NewKeyringStore()
got := k.Ref("prod", "access")
assert.Equal(t, "keychain://weknora/prod/access", got)
}