nullkey
f2e8e3f56c
Survey of 10 mainstream CLIs (gh, lark, stripe, vercel, supabase, aws, azure, gcloud, openai/codex, github-copilot-cli) showed env-gated per-command --help blurbs are a Stripe-only pattern; gh uses env detect for telemetry only, and lark relies on installed agent Skills + MCP. Our cmd/mcp/serve already covers the dominant 2025/26 path, so internal/aiclient/ (136 LOC + 38 callsites) is net maintenance burden without precedent. - Drop internal/aiclient/ entirely (annotations + detect + tests) - Remove 38 SetAgentHelp callsites + agentAwareHelpFunc / SetHelpFunc wiring in cmd/root.go - Migrate 4 command-level rules to standard Long help (visible to all, not env-gated): doc upload mode mutex, kb edit at-least-one, kb pin idempotent, search chunks channel mutex - Rewrite AGENTS.md as a developer guide (gh-style 6 H2 / 167 lines): audience preamble + Build / Architecture / Command Structure / Testing / Code Style / Error Handling. Drops sections absent in surveyed projects (Commit & PR Conventions, Who Uses This CLI) - Clean 14 internal doc refs (ADR-N, spec §X, v0.X) in source comments and docs that pointed at docs/superpowers/ — that directory is local-only / uncommitted, so refs are dead for outside readers - Drop forward-looking "once v0.2 ships" from README
47 lines
1.6 KiB
Go
47 lines
1.6 KiB
Go
package compat_test
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/compat"
|
|
)
|
|
|
|
func TestCompat(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
serverVer string
|
|
cliVer string
|
|
wantLevel compat.Level
|
|
wantHintHas string
|
|
}{
|
|
{"equal", "1.2.3", "1.2.3", compat.OK, ""},
|
|
{"client minor lower", "1.5.0", "1.2.0", compat.OK, ""},
|
|
{"client minor higher", "1.2.0", "1.5.0", compat.SoftWarn, "server is older"},
|
|
{"different major", "1.9.9", "2.0.0", compat.HardError, "incompatible"},
|
|
{"client unset", "1.2.3", "(unknown)", compat.OK, ""}, // dev build; no warning
|
|
{"server unset", "", "1.2.3", compat.OK, ""},
|
|
{"malformed server", "garbage", "1.2.3", compat.OK, ""}, // fail-open
|
|
|
|
// "v" prefix tolerance (git describe + Tencent tag convention)
|
|
{"v-prefix both", "v1.2.0", "v1.5.0", compat.SoftWarn, "server is older"},
|
|
{"v-prefix server only", "v1.9.9", "2.0.0", compat.HardError, "incompatible"},
|
|
{"v-prefix cli only", "1.9.9", "v2.0.0", compat.HardError, "incompatible"},
|
|
|
|
// Hint must be empty when level == OK (no false positives)
|
|
{"OK hint empty", "1.2.3", "1.2.3", compat.OK, ""},
|
|
}
|
|
for _, tt := range tests {
|
|
gotLevel, gotHint := compat.Compat(tt.serverVer, tt.cliVer)
|
|
if gotLevel != tt.wantLevel {
|
|
t.Errorf("%s: Level = %v, want %v", tt.name, gotLevel, tt.wantLevel)
|
|
}
|
|
if tt.wantHintHas != "" && !strings.Contains(gotHint, tt.wantHintHas) {
|
|
t.Errorf("%s: hint = %q, should contain %q", tt.name, gotHint, tt.wantHintHas)
|
|
}
|
|
if tt.wantLevel == compat.OK && gotHint != "" {
|
|
t.Errorf("%s: OK level should have empty hint, got %q", tt.name, gotHint)
|
|
}
|
|
}
|
|
}
|