fix(rbac): hide UI mutation surfaces for Viewer / non-creator

Several mutation entry points stayed visible to users who lacked the
backend-required role, so Viewers (and non-creator Contributors) hit
403 on click instead of seeing the disabled state. Surgical fixes,
all matching the existing backend matrix:

  - KnowledgeBaseList: gate the entire 3-dot popup (both the 'all'
    and 'mine' tabs) behind canManageKBCard. Pin/unpin used to be
    unguarded; settings/delete were per-item gated but the trigger
    still showed. Now non-managers don't see the popup at all.

  - AgentList: the popup trigger now requires at least one menu item
    to be visible (edit OR copy OR disable OR delete), via a compound
    v-if on the popup itself. Disable/enable on own custom agents
    and shared agents both gain a hasRole('admin') guard to match
    POST /shared-agents/disabled, which writes a tenant-level
    preference and is Admin-gated.

  - AgentEditorModal: new readOnly prop hides the '确定' (save)
    button and replaces 'Cancel' with 'Close'. AgentList passes
    readOnly when the user can't manage the agent (built-in agents
    and others' custom agents for Viewers). Form-input disabling is
    intentionally NOT wired here yet — the modal has 3000+ lines of
    inputs and the only mutation surface that 403s is the save
    button. Hiding it removes the broken path without rewiring the
    whole form.

  - doc-content: generated-question delete button gated by a new
    canEditKB prop driven by KnowledgeBase.vue's existing canEdit
    computed (KB creator OR Admin OR org-share-edit). Defaults to
    Admin-only when the prop is missing — fail-closed since the
    backend matrix is now stricter (see follow-up commit).

The server still enforces the same matrix on every mutation; these
gates only stop the user from staring at a 'failed' toast.
This commit is contained in:
wizardchen
2026-05-15 12:15:26 +08:00
committed by lyingbug
parent 1e8b5c8d40
commit f7a264ca93
5 changed files with 37 additions and 14 deletions
@@ -136,6 +136,7 @@
<div class="card-header">
<span class="card-title" :title="kb.name">{{ kb.name }}</span>
<t-popup
v-if="canManageKBCard(kb)"
overlayClassName="card-more-popup"
trigger="click"
destroy-on-close
@@ -313,6 +314,7 @@
<div class="card-header">
<span class="card-title" :title="kb.name">{{ kb.name }}</span>
<t-popup
v-if="canManageKBCard(kb)"
v-model="kb.showMore"
overlayClassName="card-more-popup"
:on-visible-change="onVisibleChange"
@@ -334,11 +336,11 @@
<t-icon class="menu-icon" :name="kb.is_pinned ? 'pin-filled' : 'pin'" />
<span>{{ kb.is_pinned ? $t('knowledgeList.pin.unpin') : $t('knowledgeList.pin.pin') }}</span>
</div>
<div v-if="canManageKBCard(kb)" class="popup-menu-item" @click.stop="handleSettings(kb)">
<div class="popup-menu-item" @click.stop="handleSettings(kb)">
<t-icon class="menu-icon" name="setting" />
<span>{{ $t('knowledgeBase.settings') }}</span>
</div>
<div v-if="canManageKBCard(kb)" class="popup-menu-item delete" @click.stop="handleDelete(kb)">
<div class="popup-menu-item delete" @click.stop="handleDelete(kb)">
<t-icon class="menu-icon" name="delete" />
<span>{{ $t('common.delete') }}</span>
</div>