feat: 新增MCP stdio传输安全验证机制,防止命令注入攻击

This commit is contained in:
wizardchen
2025-12-22 10:48:40 +08:00
committed by lyingbug
parent a20541cd9d
commit f7900a5e9a
3 changed files with 215 additions and 0 deletions
+11
View File
@@ -9,6 +9,7 @@ import (
"github.com/Tencent/WeKnora/internal/logger"
"github.com/Tencent/WeKnora/internal/types"
secutils "github.com/Tencent/WeKnora/internal/utils"
"github.com/mark3labs/mcp-go/client"
"github.com/mark3labs/mcp-go/client/transport"
"github.com/mark3labs/mcp-go/mcp"
@@ -122,6 +123,16 @@ func NewMCPClient(config *ClientConfig) (MCPClient, error) {
return nil, fmt.Errorf("stdio_config is required for stdio transport")
}
// Security validation: validate command, args, and env vars before execution
// This prevents command injection attacks (CWE-78)
if err := secutils.ValidateStdioConfig(
config.Service.StdioConfig.Command,
config.Service.StdioConfig.Args,
config.Service.EnvVars,
); err != nil {
return nil, fmt.Errorf("stdio configuration validation failed: %w", err)
}
// Convert env vars map to []string format (KEY=value)
envVars := make([]string, 0, len(config.Service.EnvVars))
for key, value := range config.Service.EnvVars {