refactor(cli): drop aiclient package; align AGENTS.md with mainstream
Survey of 10 mainstream CLIs (gh, lark, stripe, vercel, supabase, aws, azure, gcloud, openai/codex, github-copilot-cli) showed env-gated per-command --help blurbs are a Stripe-only pattern; gh uses env detect for telemetry only, and lark relies on installed agent Skills + MCP. Our cmd/mcp/serve already covers the dominant 2025/26 path, so internal/aiclient/ (136 LOC + 38 callsites) is net maintenance burden without precedent. - Drop internal/aiclient/ entirely (annotations + detect + tests) - Remove 38 SetAgentHelp callsites + agentAwareHelpFunc / SetHelpFunc wiring in cmd/root.go - Migrate 4 command-level rules to standard Long help (visible to all, not env-gated): doc upload mode mutex, kb edit at-least-one, kb pin idempotent, search chunks channel mutex - Rewrite AGENTS.md as a developer guide (gh-style 6 H2 / 167 lines): audience preamble + Build / Architecture / Command Structure / Testing / Code Style / Error Handling. Drops sections absent in surveyed projects (Commit & PR Conventions, Who Uses This CLI) - Clean 14 internal doc refs (ADR-N, spec §X, v0.X) in source comments and docs that pointed at docs/superpowers/ — that directory is local-only / uncommitted, so refs are dead for outside readers - Drop forward-looking "once v0.2 ships" from README
This commit is contained in:
@@ -21,7 +21,7 @@ type KeyringStore struct{}
|
||||
func NewKeyringStore() *KeyringStore { return &KeyringStore{} }
|
||||
|
||||
// service returns the per-context service identifier. Splitting by context
|
||||
// (rather than by host) follows the Supabase pattern (ADR-17): a user with
|
||||
// (rather than by host) follows the Supabase pattern: a user with
|
||||
// two tenants on the same host gets two distinct keyring namespaces.
|
||||
func (k *KeyringStore) service(context string) string {
|
||||
return keyringService + ":" + context
|
||||
|
||||
@@ -1,10 +1,10 @@
|
||||
// Package secrets stores and retrieves credentials.
|
||||
// Package secrets stores and retrieves credentials. Production wires
|
||||
// KeyringStore (OS keychain, primary) with FileStore (0600 plaintext under
|
||||
// $XDG_CONFIG_HOME/weknora/secrets/, used as a fallback when no keyring
|
||||
// backend is available).
|
||||
//
|
||||
// v0.0 ships a file-only Store implementation (0600 perms under
|
||||
// $XDG_CONFIG_HOME/weknora/secrets/). The OS keyring backend lands in v0.1
|
||||
// once auth login is needed in TTY contexts (current PR is foundation only).
|
||||
//
|
||||
// Namespace convention: "weknora:<context>:<key>" where key is "access" or "refresh".
|
||||
// Namespace convention: "weknora:<context>:<key>" where key is "access",
|
||||
// "refresh", or "api_key".
|
||||
package secrets
|
||||
|
||||
import (
|
||||
@@ -34,15 +34,14 @@ type Store interface {
|
||||
}
|
||||
|
||||
// FileStore writes 0600 plain-text files under $XDG_CONFIG_HOME/weknora/secrets/<context>.
|
||||
// It is the headless / CI default and the keychain fallback (see ADR-17 for
|
||||
// namespace strategy).
|
||||
// It is the headless / CI default and the keychain fallback.
|
||||
type FileStore struct {
|
||||
root string
|
||||
}
|
||||
|
||||
// NewFileStore returns a FileStore rooted at $XDG_CONFIG_HOME/weknora/secrets
|
||||
// (or ~/.config/weknora/secrets if XDG_CONFIG_HOME is unset). Same convention
|
||||
// as config.Path — see that file for the rationale (CLI convention).
|
||||
// as config.Path - see that file for the rationale (CLI convention).
|
||||
func NewFileStore() (*FileStore, error) {
|
||||
root, err := defaultRoot()
|
||||
if err != nil {
|
||||
@@ -91,7 +90,7 @@ func (f *FileStore) Delete(context, key string) error {
|
||||
|
||||
// Ref returns the file:// URI under which a secret would be stored. Path
|
||||
// component is forward-slash-normalized per RFC 8089 (file:///path on Unix,
|
||||
// file:///C:/... on Windows) — the wire format must not depend on platform
|
||||
// file:///C:/... on Windows) - the wire format must not depend on platform
|
||||
// path separator since this string is persisted to config.yaml and may be
|
||||
// consumed by tooling on a different OS.
|
||||
func (f *FileStore) Ref(context, key string) string {
|
||||
|
||||
Reference in New Issue
Block a user