refactor(cli): drop aiclient package; align AGENTS.md with mainstream
Survey of 10 mainstream CLIs (gh, lark, stripe, vercel, supabase, aws, azure, gcloud, openai/codex, github-copilot-cli) showed env-gated per-command --help blurbs are a Stripe-only pattern; gh uses env detect for telemetry only, and lark relies on installed agent Skills + MCP. Our cmd/mcp/serve already covers the dominant 2025/26 path, so internal/aiclient/ (136 LOC + 38 callsites) is net maintenance burden without precedent. - Drop internal/aiclient/ entirely (annotations + detect + tests) - Remove 38 SetAgentHelp callsites + agentAwareHelpFunc / SetHelpFunc wiring in cmd/root.go - Migrate 4 command-level rules to standard Long help (visible to all, not env-gated): doc upload mode mutex, kb edit at-least-one, kb pin idempotent, search chunks channel mutex - Rewrite AGENTS.md as a developer guide (gh-style 6 H2 / 167 lines): audience preamble + Build / Architecture / Command Structure / Testing / Code Style / Error Handling. Drops sections absent in surveyed projects (Commit & PR Conventions, Who Uses This CLI) - Clean 14 internal doc refs (ADR-N, spec §X, v0.X) in source comments and docs that pointed at docs/superpowers/ — that directory is local-only / uncommitted, so refs are dead for outside readers - Drop forward-looking "once v0.2 ships" from README
This commit is contained in:
@@ -63,7 +63,7 @@ func TestMapCobraError_PinnedPrefixes(t *testing.T) {
|
||||
})
|
||||
|
||||
t.Run("required flag(s)", func(t *testing.T) {
|
||||
// Self-contained probe — the pin must hold even before resource commands
|
||||
// Self-contained probe - the pin must hold even before resource commands
|
||||
// register their own required flags. RunE is required: without it cobra
|
||||
// treats the command as a parent and skips ValidateRequiredFlags.
|
||||
probe := &cobra.Command{Use: "probe", RunE: func(*cobra.Command, []string) error { return nil }}
|
||||
@@ -77,7 +77,7 @@ func TestMapCobraError_PinnedPrefixes(t *testing.T) {
|
||||
"cobra required-flag prefix changed; update cobraFlagErrorPrefixes. got: %q", err.Error())
|
||||
})
|
||||
|
||||
t.Run("accepts N arg(s) — ExactArgs", func(t *testing.T) {
|
||||
t.Run("accepts N arg(s) - ExactArgs", func(t *testing.T) {
|
||||
probe := &cobra.Command{
|
||||
Use: "probe",
|
||||
Args: cobra.ExactArgs(1),
|
||||
@@ -115,7 +115,7 @@ func TestMapCobraError(t *testing.T) {
|
||||
|
||||
// TestRoot_ContextFlagPropagation guards the cobra → Factory wiring of the
|
||||
// global --context flag. Without this, a future refactor that disconnects
|
||||
// PersistentPreRun from f.ContextOverride would only fail e2e — the
|
||||
// PersistentPreRun from f.ContextOverride would only fail e2e - the
|
||||
// per-package TestFactory_ContextOverride only proves the Factory side.
|
||||
func TestRoot_ContextFlagPropagation(t *testing.T) {
|
||||
cases := []struct {
|
||||
|
||||
Reference in New Issue
Block a user