refactor(cli): drop aiclient package; align AGENTS.md with mainstream
Survey of 10 mainstream CLIs (gh, lark, stripe, vercel, supabase, aws, azure, gcloud, openai/codex, github-copilot-cli) showed env-gated per-command --help blurbs are a Stripe-only pattern; gh uses env detect for telemetry only, and lark relies on installed agent Skills + MCP. Our cmd/mcp/serve already covers the dominant 2025/26 path, so internal/aiclient/ (136 LOC + 38 callsites) is net maintenance burden without precedent. - Drop internal/aiclient/ entirely (annotations + detect + tests) - Remove 38 SetAgentHelp callsites + agentAwareHelpFunc / SetHelpFunc wiring in cmd/root.go - Migrate 4 command-level rules to standard Long help (visible to all, not env-gated): doc upload mode mutex, kb edit at-least-one, kb pin idempotent, search chunks channel mutex - Rewrite AGENTS.md as a developer guide (gh-style 6 H2 / 167 lines): audience preamble + Build / Architecture / Command Structure / Testing / Code Style / Error Handling. Drops sections absent in surveyed projects (Commit & PR Conventions, Who Uses This CLI) - Clean 14 internal doc refs (ADR-N, spec §X, v0.X) in source comments and docs that pointed at docs/superpowers/ — that directory is local-only / uncommitted, so refs are dead for outside readers - Drop forward-looking "once v0.2 ships" from README
This commit is contained in:
+7
-17
@@ -1,18 +1,13 @@
|
||||
// Package agentcmd holds the `weknora agent` command tree:
|
||||
// list / view / invoke. The directory is named `agent/` (matches cobra
|
||||
// noun-verb convention) but the Go package is `agentcmd` to avoid
|
||||
// shadowing cli/internal/agent (which owns SetAgentHelp + agent-aware
|
||||
// help rendering for AI coding agents — a distinct concept from
|
||||
// WeKnora's first-class custom-agent resources).
|
||||
// colliding with cobra's *cobra.Command identifier.
|
||||
//
|
||||
// Disambiguation in cli/AGENTS.md: "agent" in this subtree refers to
|
||||
// WeKnora's user-defined Custom Agents (server resource: GET/POST
|
||||
// /agents/...). The CLI's `agent invoke` calls /agent-chat/:session_id
|
||||
// which dispatches the agent's configured workflow (system prompt,
|
||||
// allowed tools, KB scope, retrieval thresholds, etc.). This is
|
||||
// orthogonal to AGENTS.md / SetAgentHelp, which exists so AI coding
|
||||
// agents (Claude Code, Cursor) consuming the CLI can read structured
|
||||
// hints from --help.
|
||||
// "agent" in this subtree refers to WeKnora's user-defined Custom
|
||||
// Agents (server resource: GET/POST /agents/...). The CLI's
|
||||
// `agent invoke` calls /agent-chat/:session_id which dispatches the
|
||||
// agent's configured workflow (system prompt, allowed tools, KB scope,
|
||||
// retrieval thresholds).
|
||||
package agentcmd
|
||||
|
||||
import (
|
||||
@@ -29,12 +24,7 @@ func NewCmd(f *cmdutil.Factory) *cobra.Command {
|
||||
Short: "Manage and invoke custom agents",
|
||||
Long: `Custom Agents bundle a system prompt, model, tool allow-list, and KB
|
||||
scope into an addressable resource. List visible agents, view a single
|
||||
agent's configuration, or invoke an agent against a query.
|
||||
|
||||
Distinct from the per-CLI ` + "`AGENTS.md`" + ` reference: that file documents the
|
||||
contract for AI coding agents (Claude Code / Cursor) running ` + "`weknora`" + `
|
||||
on a user's behalf. This subtree manages WeKnora's first-class custom-agent
|
||||
resources stored on the server.`,
|
||||
agent's configuration, or invoke an agent against a query.`,
|
||||
Args: cobra.NoArgs,
|
||||
Run: func(c *cobra.Command, _ []string) { _ = c.Help() },
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user