fix: deep-copy stored files and images when cloning a knowledge base

Cloning a knowledge base previously copied only the storage path strings
(knowledge.FilePath and chunk.ImageInfo.URL), so the source and the clone
shared the same physical objects in the storage backend. Once the original
file and extracted images are deleted on source removal, the clone is left
with dangling references and its document and images become unreadable —
data loss that occurs even for same-store clones.

Add a CopyFile primitive to the FileService interface and implement it in
every backend: server-side CopyObject on the object stores
(s3/obs/cos/oss/tos/ks3/minio), io.Copy on local, and a no-op on dummy.
Destinations use the knowledge-owned layout and reuse the existing
path/object-key guards; a sentinel ErrCrossBackendCopy is returned when the
source scheme does not match the backend.

Use CopyFile to deep-copy the document file in cloneKnowledge and the
extracted images in CloneChunk and cloneFAQKnowledgeBase via a shared
cloneChunkImageInfo helper that deduplicates identical image URLs per clone
and rewrites them to the new objects. Copied objects are cleaned up
best-effort if a clone fails partway through. A clone-time preflight rejects
cloning into a target bound to a different storage backend when the tenant
pins providers via StorageEngineConfig.

Adds unit tests for local CopyFile (independent copy survives source
deletion, traversal rejection, cross-backend rejection), cloneChunkImageInfo
(empty/multi/dedup/parse-failure/OriginalURL handling), and the storage
provider preflight.
This commit is contained in:
ochan.kwon
2026-06-02 20:25:38 +09:00
committed by lyingbug
parent f4af9cca97
commit e9980c6011
25 changed files with 918 additions and 12 deletions
+19 -1
View File
@@ -119,7 +119,7 @@ func buildKBResponse(
// - KB has no binding → DefaultStoreDisplay()
// - KB is owned by another tenant (cross-tenant shared) → SharedStoreDisplay()
// - KB is own-tenant bound → look up in the batch result; misses
// fall back to UnavailableStoreDisplay()
// fall back to UnavailableStoreDisplay()
//
// Resolver failures degrade gracefully: every own-tenant bound KB renders
// as unavailable instead of breaking the list response.
@@ -1003,6 +1003,24 @@ func (h *KnowledgeBaseHandler) CopyKnowledgeBase(c *gin.Context) {
"cross-store cloning is not yet supported"))
return
}
// Pre-flight defense 3: storage backend must match — only meaningful
// when the tenant has a StorageEngineConfig. Without it,
// resolveFileService ignores per-KB provider pins and routes ALL KBs to
// the global storage service, so a clone can never span two real
// backends and the pins must NOT be used to reject (false positive).
// When a tenant config exists, pins are honored, so reject a genuine
// cross-backend clone before enqueueing.
if tenant, _ := ctx.Value(types.TenantInfoContextKey).(*types.Tenant); tenant != nil && tenant.StorageEngineConfig != nil {
tenantDefault := tenant.StorageEngineConfig.DefaultProvider
srcProvider := sourceKB.EffectiveStorageProvider(tenantDefault)
dstProvider := targetKB.EffectiveStorageProvider(tenantDefault)
if srcProvider != "" && dstProvider != "" && srcProvider != dstProvider {
c.Error(apperrors.NewBadRequestError(
"source and target knowledge bases use different storage backends (" +
srcProvider + " vs " + dstProvider + "); cross-storage-backend cloning is not supported"))
return
}
}
}
// Generate task ID if not provided