From e4bb97ff67c2cd243f3dbb35e94cc25f4f251b38 Mon Sep 17 00:00:00 2001
From: wizardchen <wizardchen@tencent.com>
Date: Thu, 12 Mar 2026 21:19:30 +0800
Subject: [PATCH] feat: enhance chat model selection logic in session
 management

- Refactored the chat model ID selection process to prioritize the request's summaryModelID, followed by the custom agent's ModelID, and finally a fallback to the default model selection.
- Improved logging to provide clearer insights into which model ID is being used during the selection process.
- Removed the deprecated selectChatModelIDWithOverride function to streamline the codebase and enhance maintainability.

These changes improve the flexibility and clarity of chat model selection, ensuring a more robust session management experience.
---
 internal/application/service/session.go | 68 +++++++++----------------
 1 file changed, 23 insertions(+), 45 deletions(-)

diff --git a/internal/application/service/session.go b/internal/application/service/session.go
index ee953fbf..a1841b25 100644
--- a/internal/application/service/session.go
+++ b/internal/application/service/session.go
@@ -553,10 +553,29 @@ func (s *sessionService) KnowledgeQA(
 		knowledgeBaseIDs = s.resolveKnowledgeBasesFromAgent(ctx, customAgent, session.TenantID)
 	}
 
-	// Determine chat model ID: prioritize request's summaryModelID, then Remote models
-	chatModelID, err := s.selectChatModelIDWithOverride(ctx, session, knowledgeBaseIDs, knowledgeIDs, summaryModelID)
-	if err != nil {
-		return err
+	// Determine chat model ID priority:
+	// 1. Request's summaryModelID (explicit override)
+	// 2. Custom agent's ModelID (agent configuration)
+	// 3. KB / session / system default model (legacy fallback)
+	var chatModelID string
+	if summaryModelID != "" {
+		if model, err := s.modelService.GetModelByID(ctx, summaryModelID); err == nil && model != nil {
+			chatModelID = summaryModelID
+			logger.Infof(ctx, "Using request's summary model override: %s", chatModelID)
+		} else {
+			logger.Warnf(ctx, "Request provided invalid summary model ID %s: %v, falling back", summaryModelID, err)
+		}
+	}
+	if chatModelID == "" && customAgent != nil && customAgent.Config.ModelID != "" {
+		chatModelID = customAgent.Config.ModelID
+		logger.Infof(ctx, "Using custom agent's model_id: %s", chatModelID)
+	}
+	if chatModelID == "" {
+		var err error
+		chatModelID, err = s.selectChatModelID(ctx, session, knowledgeBaseIDs, knowledgeIDs)
+		if err != nil {
+			return err
+		}
 	}
 
 	// Initialize default values from config.yaml
@@ -595,12 +614,6 @@ func (s *sessionService) KnowledgeQA(
 		// Ensure defaults are set
 		customAgent.EnsureDefaults()
 
-		// Override model ID only if request didn't specify summaryModelID
-		// Request's summaryModelID has highest priority
-		if summaryModelID == "" && customAgent.Config.ModelID != "" {
-			chatModelID = customAgent.Config.ModelID
-			logger.Infof(ctx, "Using custom agent's model_id: %s", chatModelID)
-		}
 		// Override system prompt
 		if customAgent.Config.SystemPrompt != "" {
 			summaryConfig.Prompt = customAgent.Config.SystemPrompt
@@ -841,41 +854,6 @@ func (s *sessionService) KnowledgeQA(
 	return nil
 }
 
-// selectChatModelIDWithOverride selects the appropriate chat model ID with priority for request override
-// Priority order:
-// 1. Request's summaryModelID (if provided and valid)
-// 2. Session's SummaryModelID if it's a Remote model
-// 3. First knowledge base with a Remote model
-// 4. Session's SummaryModelID (if not Remote)
-// 5. First knowledge base's SummaryModelID
-func (s *sessionService) selectChatModelIDWithOverride(
-	ctx context.Context,
-	session *types.Session,
-	knowledgeBaseIDs []string,
-	knowledgeIDs []string,
-	summaryModelID string,
-) (string, error) {
-	// First, check if request has summaryModelID override
-	if summaryModelID != "" {
-		// Validate that the model exists
-		model, err := s.modelService.GetModelByID(ctx, summaryModelID)
-		if err != nil {
-			logger.Warnf(
-				ctx,
-				"Request provided invalid summary model ID %s: %v, falling back to default selection",
-				summaryModelID,
-				err,
-			)
-		} else if model != nil {
-			logger.Infof(ctx, "Using request's summary model override: %s", summaryModelID)
-			return summaryModelID, nil
-		}
-	}
-
-	// If no valid override, use default selection logic
-	return s.selectChatModelID(ctx, session, knowledgeBaseIDs, knowledgeIDs)
-}
-
 // selectChatModelID selects the appropriate chat model ID with priority for Remote models
 // Priority order:
 // 1. Session's SummaryModelID if it's a Remote model