fix(agent): exclude wiki-only KBs from quick-answer (RAG) mode
Quick-answer agent mode retrieves purely through vector/keyword chunk search and ships with no `allowed_tools`, so the existing capability filter (which only reads from `allowed_tools`) let wiki-only KBs through in every entry point. End result: users could @-mention, select, and receive suggested questions from wiki-only KBs in quick-answer mode, but the underlying retrieval always returned empty. Treat "RAG-only" as an implicit property of `agent_mode = quick-answer` and union it with the tool-derived filter. The same predicate is now used everywhere the user can pick or be steered toward a KB: Backend - `tools.DeriveKBFilterForAgent` / `KBSatisfiesAgentRequirements` layer the implicit quick-answer requirement on top of tool derivation. - `ListKnowledgeBases`, `SearchKnowledge` (shared-agent `@file`), `resolveKnowledgeBasesFromAgent` (chat runtime), `/search` IM command, and `GetSuggestedQuestions` now all use the agent-mode-aware variant. - `GetSuggestedQuestions` also skips the wiki-page fallback for quick-answer agents to cover the `selected` / explicit-kb-ids paths where a wiki-only KB could still slip through. Frontend - `deriveKbFilterForAgent` / `kbSatisfiesAgentRequirements` mirror the Go helpers. - `@` mention dropdown (`Input-field.vue`) uses the new helper. - Agent editor's "specified KB" picker (`AgentEditorModal.vue`) grays out wiki-only KBs for quick-answer agents with a tooltip, and the pre-save warning fires for quick-answer mode too. - i18n: add `agentEditor.agentType.kbMismatch.quickAnswer` across all four locales.
This commit is contained in:
@@ -1517,14 +1517,16 @@ func (h *KnowledgeHandler) SearchKnowledge(c *gin.Context) {
|
||||
}
|
||||
// `all` mode: authoritative server-side capability filter. Mirrors the
|
||||
// logic in ListKnowledgeBases so @file search, KB listing, and runtime
|
||||
// all agree on what "mode=all" actually means for this agent.
|
||||
filter := tools.DeriveKBFilterFromTools(agent.Config.AllowedTools)
|
||||
// all agree on what "mode=all" actually means for this agent. The
|
||||
// filter is agent-mode aware so quick-answer (RAG-only) skips
|
||||
// wiki-only KBs even though it has no `allowed_tools`.
|
||||
filter := tools.DeriveKBFilterForAgent(agent.Config.AgentMode, agent.Config.AllowedTools)
|
||||
removed := 0
|
||||
for _, kb := range kbs {
|
||||
if kb == nil || kb.Type != types.KnowledgeBaseTypeDocument {
|
||||
continue
|
||||
}
|
||||
if !filter.IsEmpty() && !tools.KBSatisfiesToolRequirements(kb.Capabilities(), agent.Config.AllowedTools) {
|
||||
if !filter.IsEmpty() && !tools.KBSatisfiesAgentRequirements(kb.Capabilities(), agent.Config.AgentMode, agent.Config.AllowedTools) {
|
||||
removed++
|
||||
continue
|
||||
}
|
||||
@@ -1532,7 +1534,7 @@ func (h *KnowledgeHandler) SearchKnowledge(c *gin.Context) {
|
||||
}
|
||||
if removed > 0 {
|
||||
logger.Infof(ctx,
|
||||
"SearchKnowledge(agent=%s, mode=all): tool-capability filter removed %d KBs",
|
||||
"SearchKnowledge(agent=%s, mode=all): capability filter removed %d KBs",
|
||||
agentID, removed)
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user