refactor(cli): --limit/--all-pages, Go 1.26, internal/agent → aiclient
Cross-cutting cleanup that lands alongside the new feature surface: - `--limit / -L` and `--all-pages` on every list command. Default --limit 30 (gh-parity); --all-pages drains every server page client-side, capped by --limit. Closes the audit finding that the old "1000 max per call" implicit cap was undiscoverable. - `auth token` emits a TTY-only stderr advisory when stdout is a terminal (the credential just got displayed in scrollback) plus an api-key-mode rotation hint. - Comment + doc discipline pass: drop external project name references from in-code comments (we reference them in design notes, not inline). - Bump `go` directive to 1.26.0 and CI matrix to 1.26.x to align with the main module's go.mod. - Rename `cli/internal/agent` → `cli/internal/aiclient` to disambiguate from the new `cli/cmd/agent` resource subtree. The package handles AI coding-agent env detection + per-command --help annotations; the new name reflects that more precisely.
This commit is contained in:
@@ -62,6 +62,11 @@ type Risk struct {
|
||||
}
|
||||
|
||||
// Meta carries non-payload context fields useful to agents and observability.
|
||||
//
|
||||
// Pagination metadata (Page / PageSize / Total) lives here rather than in
|
||||
// data.{...} so every list command's `data` field has the same shape —
|
||||
// always `{items: [...]}` — and agents can branch on the resource type
|
||||
// without per-list parser variants.
|
||||
type Meta struct {
|
||||
Context string `json:"context,omitempty"`
|
||||
TenantID uint64 `json:"tenant_id,omitempty"`
|
||||
@@ -69,6 +74,9 @@ type Meta struct {
|
||||
RequestID string `json:"request_id,omitempty"`
|
||||
NextCursor string `json:"next_cursor,omitempty"`
|
||||
HasMore bool `json:"has_more,omitempty"`
|
||||
Page int `json:"page,omitempty"`
|
||||
PageSize int `json:"page_size,omitempty"`
|
||||
Total int64 `json:"total,omitempty"`
|
||||
Warnings []string `json:"warnings,omitempty"`
|
||||
AppliedFilters []string `json:"applied_filters,omitempty"`
|
||||
}
|
||||
|
||||
@@ -60,8 +60,9 @@ func marshalEnvelope(env Envelope) ([]byte, error) {
|
||||
// defensive): filter each [*].
|
||||
// - data is nil / scalar: unchanged.
|
||||
//
|
||||
// Unknown field names are silently ignored (consistent with gh — users may
|
||||
// pass an aspirational field set across heterogenous list outputs).
|
||||
// Unknown field names are silently ignored so a user may pass an
|
||||
// aspirational field set across heterogenous list outputs without per-
|
||||
// command tailoring.
|
||||
func applyFieldFilter(envelopeJSON []byte, fields []string) ([]byte, error) {
|
||||
var raw map[string]json.RawMessage
|
||||
if err := json.Unmarshal(envelopeJSON, &raw); err != nil {
|
||||
@@ -160,9 +161,10 @@ func filterObjectKeys(objRaw json.RawMessage, fields []string) (json.RawMessage,
|
||||
return json.Marshal(dst)
|
||||
}
|
||||
|
||||
// writeJQ evaluates expr against envelopeJSON and writes each result line by
|
||||
// line to w. Mirrors gh's pkg/export/filter.go semantics: results that are
|
||||
// strings render without quotes; everything else uses encoding/json.
|
||||
// writeJQ evaluates expr against envelopeJSON and writes each result line
|
||||
// by line to w. String results render without quotes (so `--jq '.x.name'`
|
||||
// yields shell-friendly bare strings); non-string results use
|
||||
// encoding/json.
|
||||
//
|
||||
// Returns input.invalid_argument-shaped errors via plain errors.New + fmt;
|
||||
// the caller is responsible for wrapping with cmdutil.NewError if it wants
|
||||
|
||||
Reference in New Issue
Block a user