feat(cli): contract test suite + dependabot (PR-8)
cli/acceptance/contract/:
envelope_test.go — 16 envelope golden cases (9 commands × {success/error
variants}; 3 cases dropped with rationale: doctor.success
non-offline has unstable timing detail; auth_login.* needs
stdin/keyring scaffold deferred to v0.2; context_use.error
needs leaf-local --json deferred to follow-up)
errorcodes_test.go — single-direction AST scan of cli/cmd/ extracting first
arg of cmdutil.NewError / cmdutil.Wrapf calls;
ClassifyHTTPError dynamic-classify bridged via
cmdutil.ClassifyHTTPErrorOutputs() per spec §4.3.
testdata/envelopes/ — 16 JSON golden files
helpers_test.go (PR-6 scaffold) extended:
runCmd now wires cobra Out/Err sinks (version uses c.OutOrStdout) AND
replicates cmd.Execute()'s error-envelope path so error-case goldens are
populated. Without this, every error scenario's golden was 0 bytes.
cli/cmd/root.go: mapCobraError → MapCobraError, wantsJSONOutput → WantsJSONOutput
(exported so the contract test helper can replicate Execute()'s
envelope-printing path without calling Execute() itself).
root_test.go updated to use new exported names.
.github/dependabot.yml (新增):gomod /cli + github-actions weekly,gh-style
ignore semver-major to avoid noise. Open-source
dependency safety,independent of release cadence.
v0.1 不发布到任何分发平台 (release infra 推迟到发布窗口 milestone)。
This commit is contained in:
+34
-7
@@ -93,24 +93,51 @@ func TestMapCobraError_PinnedPrefixes(t *testing.T) {
|
||||
|
||||
func TestMapCobraError(t *testing.T) {
|
||||
t.Run("nil passes through", func(t *testing.T) {
|
||||
assert.Nil(t, mapCobraError(nil))
|
||||
assert.Nil(t, MapCobraError(nil))
|
||||
})
|
||||
t.Run("non-matching error passes through", func(t *testing.T) {
|
||||
err := mapCobraError(assert.AnError)
|
||||
err := MapCobraError(assert.AnError)
|
||||
assert.Equal(t, assert.AnError, err)
|
||||
})
|
||||
t.Run("unknown command wraps as FlagError", func(t *testing.T) {
|
||||
err := mapCobraError(errors.New(`unknown command "bogus" for "weknora"`))
|
||||
err := MapCobraError(errors.New(`unknown command "bogus" for "weknora"`))
|
||||
var fe *cmdutil.FlagError
|
||||
assert.True(t, errors.As(err, &fe))
|
||||
})
|
||||
t.Run("required flag wraps as FlagError", func(t *testing.T) {
|
||||
err := mapCobraError(errors.New(`required flag(s) "host" not set`))
|
||||
err := MapCobraError(errors.New(`required flag(s) "host" not set`))
|
||||
var fe *cmdutil.FlagError
|
||||
assert.True(t, errors.As(err, &fe))
|
||||
})
|
||||
}
|
||||
|
||||
// TestRoot_ContextFlagPropagation guards the cobra → Factory wiring of the
|
||||
// global --context flag. Without this, a future refactor that disconnects
|
||||
// PersistentPreRun from f.ContextOverride would only fail e2e — the
|
||||
// per-package TestFactory_ContextOverride only proves the Factory side.
|
||||
func TestRoot_ContextFlagPropagation(t *testing.T) {
|
||||
cases := []struct {
|
||||
name string
|
||||
args []string
|
||||
want string
|
||||
}{
|
||||
{"no flag", []string{"version"}, ""},
|
||||
{"global before subcmd", []string{"--context", "staging", "version"}, "staging"},
|
||||
{"--context=value form", []string{"--context=prod", "version"}, "prod"},
|
||||
}
|
||||
for _, tc := range cases {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
f := cmdutil.New()
|
||||
root := NewRootCmd(f)
|
||||
root.SetArgs(tc.args)
|
||||
root.SetOut(&bytes.Buffer{})
|
||||
root.SetErr(&bytes.Buffer{})
|
||||
require.NoError(t, root.Execute())
|
||||
assert.Equal(t, tc.want, f.ContextOverride)
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestArgsRequestJSON(t *testing.T) {
|
||||
cases := []struct {
|
||||
name string
|
||||
@@ -134,12 +161,12 @@ func TestArgsRequestJSON(t *testing.T) {
|
||||
|
||||
func TestWantsJSONOutput(t *testing.T) {
|
||||
// Build a minimal *cobra.Command with the json flag directly so we test
|
||||
// the helper without going through cobra's parse pipeline. wantsJSONOutput
|
||||
// the helper without going through cobra's parse pipeline. WantsJSONOutput
|
||||
// reads cmd.Flags() which on a fresh command equals LocalFlags().
|
||||
c := &cobra.Command{Use: "x"}
|
||||
c.Flags().Bool("json", false, "")
|
||||
assert.False(t, wantsJSONOutput(c), "default: --json unset")
|
||||
assert.False(t, WantsJSONOutput(c), "default: --json unset")
|
||||
|
||||
require.NoError(t, c.Flags().Set("json", "true"))
|
||||
assert.True(t, wantsJSONOutput(c), "--json=true honored")
|
||||
assert.True(t, WantsJSONOutput(c), "--json=true honored")
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user