From b4ae6091037ca161710bc114df434f928bc6b1ca Mon Sep 17 00:00:00 2001 From: wizardchen Date: Wed, 26 Nov 2025 16:36:09 +0800 Subject: [PATCH] refactor: Sanitize log inputs in chunk and session handlers to enhance security --- internal/application/service/chunk.go | 8 -------- internal/handler/session/qa.go | 3 ++- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/internal/application/service/chunk.go b/internal/application/service/chunk.go index 2e526ce5..803baf70 100644 --- a/internal/application/service/chunk.go +++ b/internal/application/service/chunk.go @@ -145,8 +145,6 @@ func (s *chunkService) ListPagedChunksByKnowledgeID(ctx context.Context, logger.ErrorWithFields(ctx, err, map[string]interface{}{ "knowledge_id": knowledgeID, "tenant_id": tenantID, - "page": page.Page, - "page_size": page.PageSize, }) return nil, err } @@ -211,12 +209,7 @@ func (s *chunkService) UpdateChunks(ctx context.Context, chunks []*types.Chunk) // Returns: // - error: Any error encountered during deletion func (s *chunkService) DeleteChunk(ctx context.Context, id string) error { - logger.Info(ctx, "Start deleting chunk") - logger.Infof(ctx, "Deleting chunk, ID: %s", id) - tenantID := ctx.Value(types.TenantIDContextKey).(uint64) - logger.Infof(ctx, "Tenant ID: %d", tenantID) - err := s.chunkRepository.DeleteChunk(ctx, tenantID, id) if err != nil { logger.ErrorWithFields(ctx, err, map[string]interface{}{ @@ -225,7 +218,6 @@ func (s *chunkService) DeleteChunk(ctx context.Context, id string) error { }) return err } - logger.Info(ctx, "Chunk deleted successfully") return nil } diff --git a/internal/handler/session/qa.go b/internal/handler/session/qa.go index 429b2da4..488a8ccb 100644 --- a/internal/handler/session/qa.go +++ b/internal/handler/session/qa.go @@ -122,7 +122,8 @@ func (h *Handler) KnowledgeQA(c *gin.Context) { } // Use shared function to handle KnowledgeQA request - h.handleKnowledgeQARequest(ctx, c, session, request.Query, knowledgeBaseIDs, assistantMessage, true, request.SummaryModelID, request.WebSearchEnabled) + h.handleKnowledgeQARequest(ctx, c, session, secutils.SanitizeForLog(request.Query), + knowledgeBaseIDs, assistantMessage, true, secutils.SanitizeForLog(request.SummaryModelID), request.WebSearchEnabled) } // AgentQA handles agent-based question answering with conversation history and streaming