feat(security): implement SSRF and path traversal protections in image handling and file downloads
- Added SSRF protection by stripping client-supplied URL and Caption fields from image attachments in the QA request handler. - Introduced a validation function to ensure Feishu API path parameters contain only safe characters, preventing path traversal attacks. - Enhanced the WeCom webhook adapter to reject internal/private URLs unless they are on an allowlist, improving security during file downloads. - Implemented a mechanism to bypass SSRF checks for trusted IM platform API hosts.
This commit is contained in:
@@ -82,6 +82,14 @@ func (h *Handler) parseQARequest(c *gin.Context, logPrefix string) (*qaRequestCo
|
||||
return nil, nil, errors.NewBadRequestError("Query content cannot be empty")
|
||||
}
|
||||
|
||||
// SSRF protection: strip client-supplied URL/Caption fields from image attachments.
|
||||
// The URL field must only be populated server-side by saveImageAttachments; an
|
||||
// attacker could inject internal network URLs to trigger SSRF via the LLM provider.
|
||||
for i := range request.Images {
|
||||
request.Images[i].URL = ""
|
||||
request.Images[i].Caption = ""
|
||||
}
|
||||
|
||||
// Log request details
|
||||
if requestJSON, err := json.Marshal(request); err == nil {
|
||||
logger.Infof(ctx, "[%s] Request: session_id=%s, request=%s",
|
||||
|
||||
Reference in New Issue
Block a user