From b1f240f1b5951abdec1acd88255d30c81f632ade Mon Sep 17 00:00:00 2001 From: gordonlu Date: Wed, 3 Jun 2026 10:34:03 +0800 Subject: [PATCH] fix(event): add panic recovery to async goroutines Add defer recover() to both Emit (async mode) and EmitAndWait goroutines to prevent handler panics from crashing the process. Fixes #1580 --- internal/event/event.go | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/internal/event/event.go b/internal/event/event.go index fcbe6afa..053c0da6 100644 --- a/internal/event/event.go +++ b/internal/event/event.go @@ -6,6 +6,8 @@ import ( "sync" "github.com/google/uuid" + + "github.com/Tencent/WeKnora/internal/logger" ) // EventType represents the type of event in the system @@ -144,6 +146,11 @@ func (eb *EventBus) Emit(ctx context.Context, event Event) error { for _, handler := range handlers { h := handler // capture loop variable go func() { + defer func() { + if r := recover(); r != nil { + logger.Errorf(ctx, "event handler panic recovered (type=%s): %v", event.Type, r) + } + }() _ = h(ctx, event) }() } @@ -186,6 +193,11 @@ func (eb *EventBus) EmitAndWait(ctx context.Context, event Event) error { go func() { defer wg.Done() + defer func() { + if r := recover(); r != nil { + errChan <- fmt.Errorf("event handler panic (type=%s): %v", event.Type, r) + } + }() if err := h(ctx, event); err != nil { errChan <- err }