feat(oss): implement OSS FileService using S3-compatible mode
Add oss.go with full FileService implementation (SaveFile, SaveBytes, GetFile, DeleteFile, GetFileURL, CheckConnectivity) using aws-sdk-go-v2 with path-style addressing for Aliyun OSS. Includes temp bucket support and unit tests for parseOssFilePath and client creation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,332 @@
|
|||||||
|
package file
|
||||||
|
|
||||||
|
import (
|
||||||
|
"bytes"
|
||||||
|
"context"
|
||||||
|
"errors"
|
||||||
|
"fmt"
|
||||||
|
"io"
|
||||||
|
"mime/multipart"
|
||||||
|
"path/filepath"
|
||||||
|
"strings"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"github.com/Tencent/WeKnora/internal/types/interfaces"
|
||||||
|
"github.com/Tencent/WeKnora/internal/utils"
|
||||||
|
"github.com/aws/aws-sdk-go-v2/aws"
|
||||||
|
"github.com/aws/aws-sdk-go-v2/config"
|
||||||
|
"github.com/aws/aws-sdk-go-v2/credentials"
|
||||||
|
"github.com/aws/aws-sdk-go-v2/service/s3"
|
||||||
|
"github.com/aws/aws-sdk-go-v2/service/s3/types"
|
||||||
|
"github.com/google/uuid"
|
||||||
|
)
|
||||||
|
|
||||||
|
// ossFileService implements the FileService interface for Aliyun OSS
|
||||||
|
// using the S3-compatible protocol with path-style addressing.
|
||||||
|
type ossFileService struct {
|
||||||
|
client *s3.Client
|
||||||
|
tempClient *s3.Client
|
||||||
|
pathPrefix string
|
||||||
|
bucketName string
|
||||||
|
tempBucketName string
|
||||||
|
}
|
||||||
|
|
||||||
|
const ossScheme = "oss://"
|
||||||
|
|
||||||
|
// newOSSClient creates a bare s3.Client configured for OSS S3-compatible mode.
|
||||||
|
// OSS always uses path-style addressing.
|
||||||
|
func newOSSClient(endpoint, region, accessKey, secretKey string) (*s3.Client, error) {
|
||||||
|
cfg, err := config.LoadDefaultConfig(context.Background(),
|
||||||
|
config.WithRegion(region),
|
||||||
|
config.WithCredentialsProvider(credentials.NewStaticCredentialsProvider(accessKey, secretKey, "")),
|
||||||
|
)
|
||||||
|
if err != nil {
|
||||||
|
return nil, fmt.Errorf("failed to load AWS config: %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
client := s3.NewFromConfig(cfg, func(o *s3.Options) {
|
||||||
|
o.BaseEndpoint = aws.String(endpoint)
|
||||||
|
o.UsePathStyle = true
|
||||||
|
})
|
||||||
|
|
||||||
|
return client, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// ossBucketExists checks if the bucket exists using the provided client.
|
||||||
|
func ossBucketExists(ctx context.Context, client *s3.Client, bucketName string) (bool, error) {
|
||||||
|
_, err := client.HeadBucket(ctx, &s3.HeadBucketInput{
|
||||||
|
Bucket: aws.String(bucketName),
|
||||||
|
})
|
||||||
|
if err != nil {
|
||||||
|
var notFound *types.NotFound
|
||||||
|
if errors.As(err, ¬Found) {
|
||||||
|
return false, nil
|
||||||
|
}
|
||||||
|
return false, err
|
||||||
|
}
|
||||||
|
return true, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// ossCreateBucket creates a new bucket using the provided client.
|
||||||
|
func ossCreateBucket(ctx context.Context, client *s3.Client, bucketName string) error {
|
||||||
|
_, err := client.CreateBucket(ctx, &s3.CreateBucketInput{
|
||||||
|
Bucket: aws.String(bucketName),
|
||||||
|
})
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
|
||||||
|
// ossEnsureBucket checks if the bucket exists and creates it if missing.
|
||||||
|
func ossEnsureBucket(ctx context.Context, client *s3.Client, bucketName string) error {
|
||||||
|
exists, err := ossBucketExists(ctx, client, bucketName)
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("failed to check bucket: %w", err)
|
||||||
|
}
|
||||||
|
if !exists {
|
||||||
|
if err := ossCreateBucket(ctx, client, bucketName); err != nil {
|
||||||
|
return fmt.Errorf("failed to create bucket: %w", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// NewOssFileService creates an Aliyun OSS file service.
|
||||||
|
// It verifies that the bucket exists and creates it if missing.
|
||||||
|
func NewOssFileService(endpoint, region, accessKey, secretKey, bucketName, pathPrefix string) (interfaces.FileService, error) {
|
||||||
|
return NewOssFileServiceWithTempBucket(endpoint, region, accessKey, secretKey, bucketName, pathPrefix, "", "")
|
||||||
|
}
|
||||||
|
|
||||||
|
// NewOssFileServiceWithTempBucket creates an Aliyun OSS file service with optional temp bucket.
|
||||||
|
func NewOssFileServiceWithTempBucket(endpoint, region, accessKey, secretKey, bucketName, pathPrefix, tempBucketName, tempRegion string) (interfaces.FileService, error) {
|
||||||
|
client, err := newOSSClient(endpoint, region, accessKey, secretKey)
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
|
||||||
|
if err := ossEnsureBucket(context.Background(), client, bucketName); err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
|
||||||
|
var tempClient *s3.Client
|
||||||
|
if tempBucketName != "" {
|
||||||
|
if tempRegion == "" {
|
||||||
|
tempRegion = region
|
||||||
|
}
|
||||||
|
tempClient, err = newOSSClient(endpoint, tempRegion, accessKey, secretKey)
|
||||||
|
if err != nil {
|
||||||
|
return nil, fmt.Errorf("failed to initialize OSS temp client: %w", err)
|
||||||
|
}
|
||||||
|
if err := ossEnsureBucket(context.Background(), tempClient, tempBucketName); err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Normalize pathPrefix: ensure it ends with '/' if not empty
|
||||||
|
if pathPrefix != "" && !strings.HasSuffix(pathPrefix, "/") {
|
||||||
|
pathPrefix += "/"
|
||||||
|
}
|
||||||
|
|
||||||
|
return &ossFileService{
|
||||||
|
client: client,
|
||||||
|
tempClient: tempClient,
|
||||||
|
pathPrefix: pathPrefix,
|
||||||
|
bucketName: bucketName,
|
||||||
|
tempBucketName: tempBucketName,
|
||||||
|
}, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// CheckOssConnectivity tests OSS connectivity using the provided credentials.
|
||||||
|
func CheckOssConnectivity(ctx context.Context, endpoint, region, accessKey, secretKey, bucketName string) error {
|
||||||
|
client, err := newOSSClient(endpoint, region, accessKey, secretKey)
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
|
||||||
|
checkCtx, cancel := context.WithTimeout(ctx, 10*time.Second)
|
||||||
|
defer cancel()
|
||||||
|
|
||||||
|
exists, err := ossBucketExists(checkCtx, client, bucketName)
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("failed to check bucket: %w", err)
|
||||||
|
}
|
||||||
|
if !exists {
|
||||||
|
return fmt.Errorf("bucket %q does not exist", bucketName)
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// parseOssFilePath extracts bucket and object key from: oss://{bucket}/{objectKey}
|
||||||
|
func parseOssFilePath(filePath string) (bucketName string, objectKey string, err error) {
|
||||||
|
if !strings.HasPrefix(filePath, ossScheme) {
|
||||||
|
return "", "", fmt.Errorf("invalid OSS file path: %s", filePath)
|
||||||
|
}
|
||||||
|
|
||||||
|
rest := strings.TrimPrefix(filePath, ossScheme)
|
||||||
|
parts := strings.SplitN(rest, "/", 2)
|
||||||
|
if len(parts) != 2 || parts[0] == "" || parts[1] == "" {
|
||||||
|
return "", "", fmt.Errorf("invalid OSS file path: %s", filePath)
|
||||||
|
}
|
||||||
|
return parts[0], parts[1], nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// CheckConnectivity verifies OSS is reachable and the main bucket exists.
|
||||||
|
func (s *ossFileService) CheckConnectivity(ctx context.Context) error {
|
||||||
|
checkCtx, cancel := context.WithTimeout(ctx, 10*time.Second)
|
||||||
|
defer cancel()
|
||||||
|
|
||||||
|
exists, err := ossBucketExists(checkCtx, s.client, s.bucketName)
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
if !exists {
|
||||||
|
return fmt.Errorf("bucket %q does not exist", s.bucketName)
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// SaveFile saves a file to OSS.
|
||||||
|
func (s *ossFileService) SaveFile(ctx context.Context,
|
||||||
|
file *multipart.FileHeader, tenantID uint64, knowledgeID string,
|
||||||
|
) (string, error) {
|
||||||
|
ext := filepath.Ext(file.Filename)
|
||||||
|
objectName := fmt.Sprintf("%s%d/%s/%s%s", s.pathPrefix, tenantID, knowledgeID, uuid.New().String(), ext)
|
||||||
|
|
||||||
|
src, err := file.Open()
|
||||||
|
if err != nil {
|
||||||
|
return "", fmt.Errorf("failed to open file: %w", err)
|
||||||
|
}
|
||||||
|
defer src.Close()
|
||||||
|
|
||||||
|
contentType := file.Header.Get("Content-Type")
|
||||||
|
if contentType == "" {
|
||||||
|
contentType = getContentTypeByExt(ext)
|
||||||
|
}
|
||||||
|
|
||||||
|
_, err = s.client.PutObject(ctx, &s3.PutObjectInput{
|
||||||
|
Bucket: aws.String(s.bucketName),
|
||||||
|
Key: aws.String(objectName),
|
||||||
|
Body: src,
|
||||||
|
ContentLength: aws.Int64(file.Size),
|
||||||
|
ContentType: aws.String(contentType),
|
||||||
|
})
|
||||||
|
if err != nil {
|
||||||
|
return "", fmt.Errorf("failed to upload file to OSS: %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
return fmt.Sprintf("oss://%s/%s", s.bucketName, objectName), nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// SaveBytes saves bytes data to OSS.
|
||||||
|
// If temp is true and temp bucket is configured, saves to temp bucket.
|
||||||
|
// Otherwise saves to main bucket.
|
||||||
|
func (s *ossFileService) SaveBytes(ctx context.Context, data []byte, tenantID uint64, fileName string, temp bool) (string, error) {
|
||||||
|
safeName, err := utils.SafeFileName(fileName)
|
||||||
|
if err != nil {
|
||||||
|
return "", fmt.Errorf("invalid file name: %w", err)
|
||||||
|
}
|
||||||
|
ext := filepath.Ext(safeName)
|
||||||
|
reader := bytes.NewReader(data)
|
||||||
|
|
||||||
|
// If requesting temp bucket and it is configured, use it
|
||||||
|
if temp && s.tempClient != nil {
|
||||||
|
objectName := fmt.Sprintf("exports/%d/%s%s", tenantID, uuid.New().String(), ext)
|
||||||
|
_, err := s.tempClient.PutObject(ctx, &s3.PutObjectInput{
|
||||||
|
Bucket: aws.String(s.tempBucketName),
|
||||||
|
Key: aws.String(objectName),
|
||||||
|
Body: reader,
|
||||||
|
ContentLength: aws.Int64(int64(len(data))),
|
||||||
|
ContentType: aws.String("text/csv; charset=utf-8"),
|
||||||
|
})
|
||||||
|
if err != nil {
|
||||||
|
return "", fmt.Errorf("failed to upload bytes to OSS temp bucket: %w", err)
|
||||||
|
}
|
||||||
|
return fmt.Sprintf("oss://%s/%s", s.tempBucketName, objectName), nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// Save to main bucket
|
||||||
|
objectName := fmt.Sprintf("%s%d/exports/%s%s", s.pathPrefix, tenantID, uuid.New().String(), ext)
|
||||||
|
_, err = s.client.PutObject(ctx, &s3.PutObjectInput{
|
||||||
|
Bucket: aws.String(s.bucketName),
|
||||||
|
Key: aws.String(objectName),
|
||||||
|
Body: reader,
|
||||||
|
ContentLength: aws.Int64(int64(len(data))),
|
||||||
|
ContentType: aws.String("text/csv; charset=utf-8"),
|
||||||
|
})
|
||||||
|
if err != nil {
|
||||||
|
return "", fmt.Errorf("failed to upload bytes to OSS: %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
return fmt.Sprintf("oss://%s/%s", s.bucketName, objectName), nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// GetFile retrieves a file from OSS by its path.
|
||||||
|
func (s *ossFileService) GetFile(ctx context.Context, filePath string) (io.ReadCloser, error) {
|
||||||
|
bucketName, objectName, err := parseOssFilePath(filePath)
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
if err := utils.SafeObjectKey(objectName); err != nil {
|
||||||
|
return nil, fmt.Errorf("invalid file path: %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
resp, err := s.client.GetObject(ctx, &s3.GetObjectInput{
|
||||||
|
Bucket: aws.String(bucketName),
|
||||||
|
Key: aws.String(objectName),
|
||||||
|
})
|
||||||
|
if err != nil {
|
||||||
|
return nil, fmt.Errorf("failed to get file from OSS: %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
return resp.Body, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// DeleteFile removes a file from OSS.
|
||||||
|
func (s *ossFileService) DeleteFile(ctx context.Context, filePath string) error {
|
||||||
|
bucketName, objectName, err := parseOssFilePath(filePath)
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
if err := utils.SafeObjectKey(objectName); err != nil {
|
||||||
|
return fmt.Errorf("invalid file path: %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
_, err = s.client.DeleteObject(ctx, &s3.DeleteObjectInput{
|
||||||
|
Bucket: aws.String(bucketName),
|
||||||
|
Key: aws.String(objectName),
|
||||||
|
})
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("failed to delete file from OSS: %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// GetFileURL returns a presigned download URL for the file.
|
||||||
|
func (s *ossFileService) GetFileURL(ctx context.Context, filePath string) (string, error) {
|
||||||
|
bucketName, objectName, err := parseOssFilePath(filePath)
|
||||||
|
if err != nil {
|
||||||
|
return "", err
|
||||||
|
}
|
||||||
|
if err := utils.SafeObjectKey(objectName); err != nil {
|
||||||
|
return "", fmt.Errorf("invalid file path: %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
// Determine which client to use
|
||||||
|
var client *s3.Client
|
||||||
|
if bucketName == s.tempBucketName && s.tempClient != nil {
|
||||||
|
client = s.tempClient
|
||||||
|
} else {
|
||||||
|
client = s.client
|
||||||
|
}
|
||||||
|
|
||||||
|
presignClient := s3.NewPresignClient(client)
|
||||||
|
|
||||||
|
presignedReq, err := presignClient.PresignGetObject(ctx, &s3.GetObjectInput{
|
||||||
|
Bucket: aws.String(bucketName),
|
||||||
|
Key: aws.String(objectName),
|
||||||
|
}, s3.WithPresignExpires(24*time.Hour))
|
||||||
|
if err != nil {
|
||||||
|
return "", fmt.Errorf("failed to generate OSS presigned URL: %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
return presignedReq.URL, nil
|
||||||
|
}
|
||||||
@@ -0,0 +1,208 @@
|
|||||||
|
package file
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"strings"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestParseOssFilePath(t *testing.T) {
|
||||||
|
tests := []struct {
|
||||||
|
name string
|
||||||
|
input string
|
||||||
|
wantBucket string
|
||||||
|
wantKey string
|
||||||
|
wantErr bool
|
||||||
|
errContains string
|
||||||
|
}{
|
||||||
|
{
|
||||||
|
name: "valid path with nested key",
|
||||||
|
input: "oss://my-bucket/123/exports/abc123.csv",
|
||||||
|
wantBucket: "my-bucket",
|
||||||
|
wantKey: "123/exports/abc123.csv",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "valid path with simple key",
|
||||||
|
input: "oss://test-bucket/key",
|
||||||
|
wantBucket: "test-bucket",
|
||||||
|
wantKey: "key",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "valid path with deep nesting",
|
||||||
|
input: "oss://bucket/prefix/tenant/exports/uuid.png",
|
||||||
|
wantBucket: "bucket",
|
||||||
|
wantKey: "prefix/tenant/exports/uuid.png",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "invalid scheme",
|
||||||
|
input: "s3://bucket/key",
|
||||||
|
wantErr: true,
|
||||||
|
errContains: "invalid OSS file path",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "empty path",
|
||||||
|
input: "",
|
||||||
|
wantErr: true,
|
||||||
|
errContains: "invalid OSS file path",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "bucket only no key",
|
||||||
|
input: "oss://bucket/",
|
||||||
|
wantErr: true,
|
||||||
|
errContains: "invalid OSS file path",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "scheme only",
|
||||||
|
input: "oss://",
|
||||||
|
wantErr: true,
|
||||||
|
errContains: "invalid OSS file path",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "no slash after bucket",
|
||||||
|
input: "oss://bucket",
|
||||||
|
wantErr: true,
|
||||||
|
errContains: "invalid OSS file path",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "empty bucket name",
|
||||||
|
input: "oss:///some-key",
|
||||||
|
wantErr: true,
|
||||||
|
errContains: "invalid OSS file path",
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tt := range tests {
|
||||||
|
t.Run(tt.name, func(t *testing.T) {
|
||||||
|
bucket, key, err := parseOssFilePath(tt.input)
|
||||||
|
if tt.wantErr {
|
||||||
|
if err == nil {
|
||||||
|
t.Errorf("parseOssFilePath(%q) expected error, got bucket=%q key=%q", tt.input, bucket, key)
|
||||||
|
}
|
||||||
|
if tt.errContains != "" && !strings.Contains(err.Error(), tt.errContains) {
|
||||||
|
t.Errorf("parseOssFilePath(%q) error = %v, want containing %q", tt.input, err, tt.errContains)
|
||||||
|
}
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if err != nil {
|
||||||
|
t.Errorf("parseOssFilePath(%q) unexpected error: %v", tt.input, err)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if bucket != tt.wantBucket {
|
||||||
|
t.Errorf("parseOssFilePath(%q) bucket = %q, want %q", tt.input, bucket, tt.wantBucket)
|
||||||
|
}
|
||||||
|
if key != tt.wantKey {
|
||||||
|
t.Errorf("parseOssFilePath(%q) key = %q, want %q", tt.input, key, tt.wantKey)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestNewOSSClient(t *testing.T) {
|
||||||
|
tests := []struct {
|
||||||
|
name string
|
||||||
|
endpoint string
|
||||||
|
region string
|
||||||
|
accessKey string
|
||||||
|
secretKey string
|
||||||
|
wantErr bool
|
||||||
|
}{
|
||||||
|
{
|
||||||
|
name: "valid parameters create client",
|
||||||
|
endpoint: "https://oss-cn-hangzhou.aliyuncs.com",
|
||||||
|
region: "cn-hangzhou",
|
||||||
|
accessKey: "test-access-key",
|
||||||
|
secretKey: "test-secret-key",
|
||||||
|
wantErr: false,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "custom endpoint",
|
||||||
|
endpoint: "https://custom-oss-endpoint.com",
|
||||||
|
region: "cn-shanghai",
|
||||||
|
accessKey: "ak",
|
||||||
|
secretKey: "sk",
|
||||||
|
wantErr: false,
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tt := range tests {
|
||||||
|
t.Run(tt.name, func(t *testing.T) {
|
||||||
|
client, err := newOSSClient(tt.endpoint, tt.region, tt.accessKey, tt.secretKey)
|
||||||
|
if tt.wantErr {
|
||||||
|
if err == nil {
|
||||||
|
t.Error("expected error but got nil")
|
||||||
|
}
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if err != nil {
|
||||||
|
t.Errorf("newOSSClient() unexpected error: %v", err)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if client == nil {
|
||||||
|
t.Error("expected non-nil client")
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestCheckOssConnectivity_InvalidEndpoint(t *testing.T) {
|
||||||
|
ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
|
||||||
|
defer cancel()
|
||||||
|
|
||||||
|
// Should fail with an invalid/unreachable endpoint
|
||||||
|
err := CheckOssConnectivity(ctx,
|
||||||
|
"https://invalid-oss-endpoint-that-does-not-exist.local",
|
||||||
|
"cn-hangzhou",
|
||||||
|
"invalid-access-key",
|
||||||
|
"invalid-secret-key",
|
||||||
|
"nonexistent-bucket",
|
||||||
|
)
|
||||||
|
|
||||||
|
if err == nil {
|
||||||
|
t.Error("CheckOssConnectivity with invalid endpoint should return an error")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestOssBucketExists_NonExistent(t *testing.T) {
|
||||||
|
client, err := newOSSClient(
|
||||||
|
"https://oss-cn-hangzhou.aliyuncs.com",
|
||||||
|
"cn-hangzhou",
|
||||||
|
"test-invalid-key",
|
||||||
|
"test-invalid-secret",
|
||||||
|
)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("newOSSClient() error: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
|
||||||
|
defer cancel()
|
||||||
|
|
||||||
|
// Bucket that definitely doesn't exist - should return false, not error
|
||||||
|
// (auth may fail first, but we verify the function doesn't crash)
|
||||||
|
exists, err := ossBucketExists(ctx, client, "this-bucket-definitely-does-not-exist-12345")
|
||||||
|
// We don't assert on the result because it depends on network/auth,
|
||||||
|
// but the function should not panic or hang.
|
||||||
|
_ = exists
|
||||||
|
_ = err
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestOssCreateBucket(t *testing.T) {
|
||||||
|
client, err := newOSSClient(
|
||||||
|
"https://oss-cn-hangzhou.aliyuncs.com",
|
||||||
|
"cn-hangzhou",
|
||||||
|
"test-invalid-key",
|
||||||
|
"test-invalid-secret",
|
||||||
|
)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("newOSSClient() error: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
|
||||||
|
defer cancel()
|
||||||
|
|
||||||
|
// Should fail with invalid credentials
|
||||||
|
err = ossCreateBucket(ctx, client, "test-bucket")
|
||||||
|
if err == nil {
|
||||||
|
t.Error("ossCreateBucket with invalid credentials should return an error")
|
||||||
|
}
|
||||||
|
}
|
||||||
Reference in New Issue
Block a user