fix(chat): persist attachment content and fix fallback multi-turn context
Persist resolved temporary-attachment content onto the stored user message so later turns can replay it in history. Close the retrieval progress spinner on early pipeline exits, and reshape model-fallback messages with a proper system role plus trailing user question.
This commit is contained in:
@@ -0,0 +1,81 @@
|
||||
package service
|
||||
|
||||
import (
|
||||
"testing"
|
||||
|
||||
"github.com/Tencent/WeKnora/internal/types"
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
)
|
||||
|
||||
// TestBuildFallbackMessages_PrependsSystemAndEndsWithUser guards the model
|
||||
// fallback path: the LLM input must start with a system message (the fallback
|
||||
// instruction) and end with the user's question, with history in between.
|
||||
// Previously the fallback dropped the system role entirely, producing a
|
||||
// [user, assistant, user] input with no system message.
|
||||
func TestBuildFallbackMessages_PrependsSystemAndEndsWithUser(t *testing.T) {
|
||||
cm := &types.ChatManage{}
|
||||
cm.Query = "这个文件内容"
|
||||
cm.History = []*types.History{
|
||||
{Query: "上一个问题", Answer: "上一个回答"},
|
||||
}
|
||||
|
||||
msgs := buildFallbackMessages(cm, "No content directly matched...\n\nUser question: 这个文件内容")
|
||||
|
||||
require.GreaterOrEqual(t, len(msgs), 2)
|
||||
assert.Equal(t, "system", msgs[0].Role, "fallback input must start with a system message")
|
||||
assert.Contains(t, msgs[0].Content, "No content directly matched")
|
||||
|
||||
// History is replayed between system and the trailing user turn.
|
||||
assert.Equal(t, "user", msgs[1].Role)
|
||||
assert.Equal(t, "上一个问题", msgs[1].Content)
|
||||
assert.Equal(t, "assistant", msgs[2].Role)
|
||||
assert.Equal(t, "上一个回答", msgs[2].Content)
|
||||
|
||||
last := msgs[len(msgs)-1]
|
||||
assert.Equal(t, "user", last.Role, "generation must be prompted by a trailing user turn")
|
||||
assert.Equal(t, "这个文件内容", last.Content)
|
||||
}
|
||||
|
||||
// TestBuildFallbackMessages_PrefersRewriteQuery verifies the trailing user turn
|
||||
// uses the rewritten query when available.
|
||||
func TestBuildFallbackMessages_PrefersRewriteQuery(t *testing.T) {
|
||||
cm := &types.ChatManage{}
|
||||
cm.Query = "它怎么样"
|
||||
cm.RewriteQuery = "混元大模型性能怎么样"
|
||||
|
||||
msgs := buildFallbackMessages(cm, "fallback instruction")
|
||||
|
||||
last := msgs[len(msgs)-1]
|
||||
assert.Equal(t, "user", last.Role)
|
||||
assert.Equal(t, "混元大模型性能怎么样", last.Content)
|
||||
}
|
||||
|
||||
// TestBuildFallbackMessages_EmptyPromptSkipsSystem ensures we don't inject an
|
||||
// empty system message when there is no fallback instruction to carry.
|
||||
func TestBuildFallbackMessages_EmptyPromptSkipsSystem(t *testing.T) {
|
||||
cm := &types.ChatManage{}
|
||||
cm.Query = "hello"
|
||||
|
||||
msgs := buildFallbackMessages(cm, " ")
|
||||
|
||||
require.Len(t, msgs, 1)
|
||||
assert.Equal(t, "user", msgs[0].Role)
|
||||
assert.Equal(t, "hello", msgs[0].Content)
|
||||
}
|
||||
|
||||
// TestBuildFallbackMessages_AttachesImagesToUserTurn confirms images ride on the
|
||||
// trailing user message only when the chat model supports vision.
|
||||
func TestBuildFallbackMessages_AttachesImagesToUserTurn(t *testing.T) {
|
||||
cm := &types.ChatManage{}
|
||||
cm.Query = "看图"
|
||||
cm.Images = []string{"https://example.com/a.png"}
|
||||
|
||||
cm.ChatModelSupportsVision = false
|
||||
noVision := buildFallbackMessages(cm, "fallback")
|
||||
assert.Empty(t, noVision[len(noVision)-1].Images)
|
||||
|
||||
cm.ChatModelSupportsVision = true
|
||||
withVision := buildFallbackMessages(cm, "fallback")
|
||||
assert.Equal(t, cm.Images, withVision[len(withVision)-1].Images)
|
||||
}
|
||||
Reference in New Issue
Block a user